Hi Alexander,
thanks for testing - just committed the fix. Allocation on the heap is
needed as the discovery_etcd needs to pick up the port for its
annunciation.
Regards,
Bjoern
On 2014-10-17 16:50, Alexander Broekhuis wrote:
Hi Bjoern,
This change causes a crash when shutting down th
Hi Bjoern,
This change causes a crash when shutting down the application. More
specific, if the initial port can be used, the port is not allocated, but
once the webserver does not start, an allocation is done. So the free in
endpointDiscoveryServer_destroy is ok in the latter, but not needed in t
2014-10-17 9:25 GMT-04:00 Bjoern Petri :
>
> Ah - sorry, I just see that you refer to the commit from this morning. A
> minute before I saw your mail, I committed some more changes which also
> seems to fix this issue (at least I cannot reproduce it). I was already
> wondering how fast you are che
2014-10-17 9:22 GMT-04:00 Bjoern Petri :
>
>
> Hi Alexander,
>
> Currently, I cannot find the problem. The etcd_watcher.h should not
> contain the function signature shown in the error message any more. Could
> you do me the favor and shortly check whether the etcd_watcher.h (rev
> 1632567) still
Ah - sorry, I just see that you refer to the commit from this morning. A
minute before I saw your mail, I committed some more changes which also
seems to fix this issue (at least I cannot reproduce it). I was already
wondering how fast you are checking commits :).
Regards,
Bjoern
On 201
Hi Alexander,
Currently, I cannot find the problem. The etcd_watcher.h should not
contain the function signature shown in the error message any more.
Could you do me the favor and shortly check whether the etcd_watcher.h
(rev 1632567) still contains this?
Regards,
Bjoern
On 2014-10-17
Hi Bjoern,
I think you forgot to add a file to the commit. It is not building for me:
remote_services/discovery_etcd/private/src/etcd_watcher.c:237:16: error:
conflicting types for ‘etcdWatcher_create’
celix_status_t etcdWatcher_create(discovery_pt discovery, bundle_context_pt
context,
remote_se
