abroekhuis commented on a change in pull request #223:
URL: https://github.com/apache/celix/pull/223#discussion_r426298603
##
File path: bundles/pubsub/pubsub_utils/src/pubsub_serializer_handler.c
##
@@ -0,0 +1,360 @@
+/**
+ *Licensed to the Apache Software Foundation (ASF)
abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-629849705
While this does work, I don't feel really comfortable with it. Even though
this test triggers the problem, the problem also seems to come from the ffi
library.
Are we certain
pnoltes merged pull request #235:
URL: https://github.com/apache/celix/pull/235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes closed pull request #223:
URL: https://github.com/apache/celix/pull/223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes commented on pull request #223:
URL: https://github.com/apache/celix/pull/223#issuecomment-629845894
@abroekhuis and @rbulter ping: Could you see if the PR is ok.
This PR also solves some threading issues, so I would like to merge this to
master asap.
pnoltes commented on pull request #223:
URL: https://github.com/apache/celix/pull/223#issuecomment-629844098
> > When running the test `pubsub_utils_test`, I get the following failed
test:
> > ```
> > [ RUN ]
PubSubSerializationProviderTestSuite.FindSerializationServices
> >
pnoltes commented on a change in pull request #230:
URL: https://github.com/apache/celix/pull/230#discussion_r426292148
##
File path: bundles/pubsub/pubsub_spi/include/pubsub_protocol.h
##
@@ -32,27 +33,29 @@ typedef struct pubsub_protocol_header
pubsub_protocol_header_t;
*
codecov-io edited a comment on pull request #235:
URL: https://github.com/apache/celix/pull/235#issuecomment-629807569
# [Codecov](https://codecov.io/gh/apache/celix/pull/235?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@e630684`). [Click here to
codecov-io edited a comment on pull request #235:
URL: https://github.com/apache/celix/pull/235#issuecomment-629807569
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pnoltes commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426288899
##
File path: .github/workflows/celix_etcdlib.yml
##
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
+
+on:
+ schedule:
+- cron: '0 0 * * 0'
rlenferink commented on a change in pull request #235:
URL: https://github.com/apache/celix/pull/235#discussion_r426281027
##
File path: README.md
##
@@ -15,9 +15,20 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
rlenferink commented on pull request #236:
URL: https://github.com/apache/celix/pull/236#issuecomment-629825368
Also, I just noticed that we have an `ubuntu.yml` for push & pull_requests
(Debug) and an `ubuntu-nightly.yml` for nightly builds (RelWithDebInfo). Maybe
we should do this for
rlenferink commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426280099
##
File path: .github/workflows/celix_etcdlib.yml
##
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
Review comment:
If we build weekly
rlenferink commented on a change in pull request #236:
URL: https://github.com/apache/celix/pull/236#discussion_r426279972
##
File path: .github/workflows/celix_etcdlib.yml
##
@@ -0,0 +1,36 @@
+name: Standalone Celix etcdlib Weekly
+
+on:
+ schedule:
+- cron: '0 0 * * 0'
codecov-io commented on pull request #235:
URL: https://github.com/apache/celix/pull/235#issuecomment-629807569
# [Codecov](https://codecov.io/gh/apache/celix/pull/235?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@e630684`). [Click here to learn
pnoltes opened a new pull request #236:
URL: https://github.com/apache/celix/pull/236
Also updated celix Promise to build weekly instead of nightly.
This is an automated message from the Apache Git Service.
To respond to the
pnoltes commented on issue #196:
URL: https://github.com/apache/celix/issues/196#issuecomment-629805707
This issues is addressed and merged in master
This is an automated message from the Apache Git Service.
To respond to
pnoltes closed issue #196:
URL: https://github.com/apache/celix/issues/196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes closed issue #157:
URL: https://github.com/apache/celix/issues/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnoltes commented on issue #157:
URL: https://github.com/apache/celix/issues/157#issuecomment-629805571
Issues is solved and released in 2.2.1
@andre2007: The hot fix branch is removed, you should now be able to use the
celix 2.2.1 tag instead.
pnoltes edited a comment on issue #157:
URL: https://github.com/apache/celix/issues/157#issuecomment-592951074
- [x] @pnoltes When the hotfix is merged back to develop, also update the
travis config to build etcdlib separately from Celix.
Adding +1 from me and closing the vote
On Thu, May 14, 2020 at 8:39 PM Alexander Broekhuis
wrote:
>
> Ah yes, of course. I knew that ;). Thanks for the reminder!
>
> Op do 14 mei 2020 om 20:03 schreef Pepijn Noltes :
>
> > Vote is on a commit id. After the vote passes a tag is created [1].
> >
>
pnoltes opened a new pull request #235:
URL: https://github.com/apache/celix/pull/235
Adds codecov configuration for coverage reports (instead of coveralls)
See
https://codecov.io/github/apache/celix/commit/923e1e98460aafab9360cc468d9b9bdae03d7437
for coverage report we can
Oipo opened a new pull request #234:
URL: https://github.com/apache/celix/pull/234
This fixes the dfi test problem for me, whilst re-enabling optimizations for
the library.
Waiting on CI build to see if this also works for clang.
Ok. I managed to figure this out. To get a class to pass over you can’t have it
inside your interface In Java but just inside your package and outside of your
interface. Doing thus changes how it is passed and you’ll get a descriptor file
call of “package name”/“class name” thus changing the $
25 matches
Mail list logo
