[GitHub] climate pull request: CLIMATE-634 Fix bug related to month_start ...

2015-05-12 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/196#issuecomment-101155972 thanks @huikyole looking forward to seeing it. Also feel free to simply push it - everything between all of you guys doesn't need to be reviewed. If it looks

[GitHub] climate pull request: CLIMATE-634 Fix bug related to month_start ...

2015-05-12 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/196#issuecomment-101156111 @kwhitehall @huikyole do we have examples of where this code is actually called by something in which tests break? If not, we should write some tests first

[GitHub] climate pull request: CLIMATE-634 Fix bug related to month_start ...

2015-05-12 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/196#issuecomment-101156144 BTW, no need to reply directly - it's late and what are we all doing up??! reply tomorrow! :+1: both of you! :) --- If your project is set up for it, you can

[GitHub] climate pull request: CLIMATE-508: added a class 'Downscaling' and...

2015-04-28 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/112#issuecomment-97177215 Yep no worries I just call them tickle commits change spacing on s text file then add commit msg all good! --- If your project is set up for it, you can reply

[GitHub] climate pull request: Adding RCMES cli code

2015-03-11 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/154#issuecomment-78315995 Why this this just be an app that runs on top of OCW. We have examples of this all the time. For example, in Apache OODT, we have apps that reference config

[GitHub] climate pull request: Adding RCMES cli code

2015-03-11 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/154#issuecomment-78403668 @MJJoyce your statement about endorsed by the project has to do with endorsement by the PMC. The PMC doesn't endorse anything here at the ASF. They do sign

[GitHub] climate pull request: Drop all instances of show() and plt.show()

2014-06-11 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/66#issuecomment-45756757 OCWJenkins please test this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] climate pull request: CLIMATE-472 - Fix overlapping colorbar label...

2014-06-11 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/72#issuecomment-45757808 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] climate pull request: Drop all instances of show() and plt.show()

2014-06-11 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/climate/pull/66#issuecomment-45757999 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have