[GitHub] climate issue #420: CLIMATE-863 - Address warning, etc within Travis-CI log ...

2016-11-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/420 The travis build is failing due to some random issue. See this build https://travis-ci.org/jarifibrahim/climate/builds/174863520 --- If your project is set up for it, you can reply to this

[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.

2016-11-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/418 @Omkar20895 `npm install` would create a folder `node_modules` and install all the dependencies in it. If you do `npm install -g` then the dependencies are installed globally. I tried

[GitHub] climate issue #419: CLIMATE-889 - Fix Travis Build

2016-11-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/419 @agoodm Done via https://github.com/apache/climate/commit/6156eff08b11f92acbfee0ca5be5d78e473483c6 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] climate issue #420: CLIMATE-863 - Address warning, etc within Travis-CI log ...

2016-11-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/420 @lewismc Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] climate issue #419: CLIMATE-889 - Fix Travis Build

2016-11-04 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/419 @agoodm @lewismc I've added some comments to the exception handling. Should I merge it now? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] climate issue #419: CLIMATE-889 - Fix Travis Build

2016-10-29 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/419 Right. That would happen. Maybe we could temporarily skip these tests. Once opendap servers are working we could add these tests back. --- If your project is set up for it, you can reply

[GitHub] climate issue #419: CLIMATE-889 - Fix Travis Build

2016-10-29 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/419 The bug/exceptions are not in ocw but in its dependencies. The downloading of the dataset is handled by the respective packages. So if something goes wrong while downloading the datasets that

[GitHub] climate pull request #420: Climate 863

2016-10-29 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/420 Climate 863 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-863 Alternatively you can review and apply

[GitHub] climate pull request #419: CLIMATE-889 - Fix Travis Build

2016-10-29 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/419 CLIMATE-889 - Fix Travis Build - Skip test if unable to download the dataset You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim

[GitHub] climate pull request #383: Adding PO.DAAC data source along with the tests

2016-08-20 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/383#discussion_r75575893 --- Diff: ocw/data_source/podaac.py --- @@ -0,0 +1,111 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] climate issue #396: CLIMATE-858 - Fix Travis Build

2016-08-19 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/396 @lewismc Please take a look at this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] climate issue #395: CLIMATE-853 Fixing broken documentation in dap.py and ma...

2016-08-19 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/395 The doc build works fine on my machine. Please rebase and then merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] climate pull request #396: CLIMATE-858 - Fix Travis Build

2016-08-19 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/396 CLIMATE-858 - Fix Travis Build You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-858 Alternatively you can

[GitHub] climate pull request #389: Climate-851 - Have nosetests log to STDOUT

2016-08-13 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/389 Climate-851 - Have nosetests log to STDOUT You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-851

[GitHub] climate pull request #388: CLIMATE-844 - Attribute error in test_smoke.py

2016-08-13 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/388 CLIMATE-844 - Attribute error in test_smoke.py This PR fixes the Attribute error in test_smoke.py file. The tests are still failing because of broken test cases. You can merge this pull

[GitHub] climate pull request #:

2016-08-12 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/commit/02dfdec65adb81cdc659764008045e99f61bbf4d#commitcomment-18626164 In ocw/dataset.py: In ocw/dataset.py on line 314: @huikyole Can you please take a look at these tests[0] and fix

[GitHub] climate pull request #:

2016-08-12 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/commit/02dfdec65adb81cdc659764008045e99f61bbf4d#commitcomment-18620602 In ocw/dataset.py: In ocw/dataset.py on line 314: @huikyole Shouldn't we check this in some kind of setter m

[GitHub] climate issue #376: CLIMATE-830 Broken tests in dap.py

2016-08-11 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/376 @Omkar20895 This merge breaks the test instead of fixing it. We might have to undo the changes made by this PR to get the tests working again. --- If your project is set up for it, you can

[GitHub] climate issue #383: Adding PO.DAAC data source along with the tests

2016-08-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/383 @lewismc The exception can be fixed by renaming `time_range` to `temporal_boundaries`. But there are many more exceptions in the unit tests. A lot of new code has been added lately but the

[GitHub] climate issue #376: CLIMATE-830 Broken tests in dap.py

2016-08-10 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/376 @Omkar20895 @huikyole This branch wasn't supposed to be merged, right? It breaks the dap tests --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] climate issue #374: CLIMATE-825 - Coalesce data sources into one module

2016-07-28 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/374 @agoodm I'm not sure why the build is stuck. I tried starting a new build but it also got stuck at `waiting`. The issue seems to be with landscape. Please go ahead and merge this PR. -

[GitHub] climate pull request #378: Climate-833 - Update travis.yml to use smoke test...

2016-07-27 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/378 Climate-833 - Update travis.yml to use smoke tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-833

[GitHub] climate pull request #377: Climate-832 - Add smoke tests

2016-07-27 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/377 Climate-832 - Add smoke tests - Update requirements - Add smoke tests Sample output of smoke tests ``` Checking installed dependencies numpy>=1.10.4 ✓ sc

[GitHub] climate issue #374: CLIMATE-825 - Coalesce data sources into one module

2016-07-26 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/374 @agoodm can you please fix landscape.io issues? The build failed because there were multiple PEP8 violations. Please take a look at this -> [Link](https://landscape.io/diff/413629) ---

[GitHub] climate pull request #375: Climate-486 - Normalize DSP function parameter or...

2016-07-26 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/375 Climate-486 - Normalize DSP function parameter ordering You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-486

[GitHub] climate pull request #373: CLIMATE-488 - Change Dataset.time_range to Datase...

2016-07-24 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/373 CLIMATE-488 - Change Dataset.time_range to Dataset.temporal_boundaries You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim

[GitHub] climate pull request #367: CLIMATE-820 - Update pip requirements

2016-06-27 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/367 CLIMATE-820 - Update pip requirements - Remove unused requirements (nose-exclude, pylint) - Update all packages to latest version You can merge this pull request into a Git repository by

[GitHub] climate pull request #360: CLIMATE-811 - Add landscape.io integration

2016-06-27 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/360#discussion_r68692972 --- Diff: .landscape.yml --- @@ -0,0 +1,18 @@ +python-targets: --- End diff -- Done. --- If your project is set up for it, you can

[GitHub] climate pull request #358: Climate-798 - Redundant code in evaluation.py

2016-06-27 Thread jarifibrahim
Github user jarifibrahim closed the pull request at: https://github.com/apache/climate/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] climate issue #358: Climate-798 - Redundant code in evaluation.py

2016-06-27 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/358 @huikyole Thank you so much. Closing PR because of **Invalid Issue**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] climate issue #358: Climate-798 - Redundant code in evaluation.py

2016-06-27 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/358 @huikyole The link to the image in your comment is broken. Please fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] climate issue #358: Climate-798 - Redundant code in evaluation.py

2016-06-27 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/358 @huikyole Please take a look at this ![image](https://imgur.com/Rzym3jB.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] climate pull request #364: CLIMATE-816 - Add requires.io badge to README.me

2016-06-19 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/364 CLIMATE-816 - Add requires.io badge to README.me You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-816

[GitHub] climate pull request #363: CLIMATE-814 - Fix PEP8 violations in dataset

2016-06-18 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/363 CLIMATE-814 - Fix PEP8 violations in dataset You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-814

[GitHub] climate pull request #363: CLIMATE-814 - Fix PEP8 violations in dataset

2016-06-18 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/363#discussion_r67599325 --- Diff: ocw/dataset.py --- @@ -28,10 +28,9 @@ import ocw.utils as utils -from mpl_toolkits.basemap import shiftgrid --- End

[GitHub] climate pull request #362: CLIMATE-813 - Fix PEP8 violations in utils module

2016-06-18 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/362#discussion_r67599123 --- Diff: ocw/utils.py --- @@ -326,97 +339,107 @@ def calc_climatology_monthly(dataset): raise ValueError(error) else

[GitHub] climate pull request #362: CLIMATE-813 - Fix PEP8 violations in utils module

2016-06-18 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/362 CLIMATE-813 - Fix PEP8 violations in utils module You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-813

[GitHub] climate pull request #361: CLIMATE-812 - Fix PEP8 violations in dataset proc...

2016-06-18 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/361#discussion_r67598748 --- Diff: ocw/dataset_processor.py --- @@ -202,130 +214,158 @@ def spatial_regrid(target_dataset, new_latitudes, new_longitudes, boundary_check

[GitHub] climate pull request #361: CLIMATE-812 - Fix PEP8 violations in dataset proc...

2016-06-18 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/361#discussion_r67598737 --- Diff: ocw/dataset_processor.py --- @@ -51,107 +53,114 @@ def temporal_subset(month_start, month_end, target_dataset, average_each_year=Fa

[GitHub] climate pull request #361: CLIMATE-812 - Fix PEP8 violations in dataset proc...

2016-06-18 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/361 CLIMATE-812 - Fix PEP8 violations in dataset processor - Fix PEP8 violations - Remove unused variables (also a PEP8 violation) You can merge this pull request into a Git repository by

[GitHub] climate pull request #360: CLIMATE-811 - Add landscape.io integration

2016-06-18 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/360 CLIMATE-811 - Add landscape.io integration - Add .landscape.yml file - Remove .pylintrc file - Add landscape.io badge You can merge this pull request into a Git repository by running

[GitHub] climate pull request #358: Climate-798 - Redundant code in evaluation.py

2016-06-16 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/358 Climate-798 - Redundant code in evaluation.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-798

[GitHub] climate pull request #357: CLIMATE-809 - Fix coveragerc file

2016-06-16 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/357 CLIMATE-809 - Fix coveragerc file You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-809 Alternatively you can

[GitHub] climate pull request #355: CLIMATE-808 - Add tests for plotter module

2016-06-14 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/355 CLIMATE-808 - Add tests for plotter module - Add tests to verify computations in plotter module - Update .coveragerc file to ignore image generation code You can merge this pull request

[GitHub] climate pull request #354: CLIMATE-807 - Add test coverage badge to README

2016-06-13 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/354 CLIMATE-807 - Add test coverage badge to README You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-807

[GitHub] climate issue #348: CLIMATE-802 - Add evaluation module tests

2016-06-13 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/348 @lewismc conflict resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] climate issue #347: CLIMATE-800 - TypeError in _rcmes_calc_average_on_new_ti...

2016-06-13 Thread jarifibrahim
Github user jarifibrahim commented on the issue: https://github.com/apache/climate/pull/347 @lewismc Yes. I'll update the JIRA ticket to explain the issue. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] climate pull request #341: CLIMATE-791 - temporal_subset does not work for m...

2016-06-13 Thread jarifibrahim
Github user jarifibrahim closed the pull request at: https://github.com/apache/climate/pull/341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] climate pull request #341: CLIMATE-791 - temporal_subset does not work for m...

2016-06-13 Thread jarifibrahim
Github user jarifibrahim commented on a diff in the pull request: https://github.com/apache/climate/pull/341#discussion_r66836127 --- Diff: ocw/dataset_processor.py --- @@ -68,8 +68,6 @@ def temporal_subset(month_start, month_end, target_dataset, average_each_year=Fa

[GitHub] climate pull request #353: Climate-806 - Add tests for local module

2016-06-13 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/353 Climate-806 - Add tests for local module You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-806 Alternatively

[GitHub] climate pull request #352: Climate-805 - Add tests for Utils module

2016-06-12 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/352 Climate-805 - Add tests for Utils module You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-805 Alternatively

[GitHub] climate pull request #351: CLIMATE-804 - normalize_lat_lon_values does not w...

2016-06-12 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/351 CLIMATE-804 - normalize_lat_lon_values does not work - Fix trivial bug in utils module You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] climate pull request #350: Climate-801

2016-06-05 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/350 Climate-801 Add new tests for dataset processor module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-795

[GitHub] climate pull request #349: Climate-801

2016-06-05 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/349 Climate-801 Add new tests for dataset module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-801

[GitHub] climate pull request #348: Climate 802

2016-06-05 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/348 Climate 802 Add new tests for evaluation module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-802

[GitHub] climate pull request #347: CLIMATE-800 - TypeError in _rcmes_calc_average_on...

2016-06-03 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/347 CLIMATE-800 - TypeError in _rcmes_calc_average_on_new_time_unit - Fix TypeError in dataset processor You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] climate pull request #346: CLIMATE-799 - TypeError in subset function

2016-06-02 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/346 CLIMATE-799 - TypeError in subset function - Fix TypeError in subset function You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim

[GitHub] climate pull request: CLIMATE-796 - TypeError in temporal_slice fu...

2016-05-30 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/345 CLIMATE-796 - TypeError in temporal_slice function Fix TypeError in temporal_slice You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] climate pull request: CLIMATE-793 - Update install-ubuntu.sh scrip...

2016-05-28 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/343#issuecomment-222323332 * conda_environment.txt file is useless. * install-conda.sh can be merged to install-ubuntu.sh to improve the process of installation. The user has to run only

[GitHub] climate pull request: CLIMATE-794 - Update travis.yml

2016-05-28 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/344#issuecomment-222318186 The builds failed because the travis is using the old version of the install-ubuntu.sh script. Please merge the CLIMATE-793 to fix the build. Please check

[GitHub] climate pull request: CLIMATE-793 - Update install-ubuntu.sh scrip...

2016-05-28 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/343#issuecomment-222318099 The Jenkins build is failing due to some permission issues with the conda installation. The script works fine on a bare machine. Please check this

[GitHub] climate pull request: CLIMATE-794 - Update travis.yml

2016-05-25 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/344 CLIMATE-794 - Update travis.yml - Use easy-ocw script for build - Track coverage - Upload code coverage report to coveralls.io You can merge this pull request into a Git repository by

[GitHub] climate pull request: CLIMATE-793 - Update install-ubuntu.sh scrip...

2016-05-25 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/343 CLIMATE-793 - Update install-ubuntu.sh script - Merge install-ubuntu.sh and install-conda.sh - Delete install-conda.sh - Delete conda_environment.txt You can merge this pull request

[GitHub] climate pull request: CLIMATE-789 - Remove redundant code in tempo...

2016-05-24 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/337#issuecomment-221347963 The commit has been merged. Hence closing #337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] climate pull request: CLIMATE-789 - Remove redundant code in tempo...

2016-05-24 Thread jarifibrahim
Github user jarifibrahim closed the pull request at: https://github.com/apache/climate/pull/337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] climate pull request: CLIMATE-785 - RCMED.py: optimize code

2016-05-16 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/334#issuecomment-219536362 [INFRA-11783 Add Github integration to jenkins](https://issues.apache.org/jira/browse/INFRA-11783) --- If your project is set up for it, you can reply to this

[GitHub] climate pull request: CLIMATE-785 - RCMED.py: optimize code

2016-05-16 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/334#issuecomment-219529546 @lewismc The builds for the PR's aren't working right now. The code is built only after it is merged to master branch. I've raised a JIRA ticket an

[GitHub] climate pull request: test 1

2016-05-16 Thread jarifibrahim
Github user jarifibrahim closed the pull request at: https://github.com/apache/climate/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] climate pull request: test 1

2016-05-16 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/335#issuecomment-219528399 Yeah. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] climate pull request: Fix PEP8 violations

2016-05-16 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/342#issuecomment-219524436 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] climate pull request: Fix PEP8 violations

2016-05-16 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/342 Fix PEP8 violations Following PEP8 violations are fixed - Remove trailing whitespaces - Fix lines with length > 79 - Add two blank lines after every function You can me

[GitHub] climate pull request: Fix temporal_subset() function

2016-05-11 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/341 Fix temporal_subset() function - Add tests for temporal_subset() Fixes https://issues.apache.org/jira/browse/CLIMATE-791 You can merge this pull request into a Git repository by

[GitHub] climate pull request: Remove redundant code in temporal_resolution...

2016-05-04 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/337 Remove redundant code in temporal_resolution function Fixes https://issues.apache.org/jira/browse/CLIMATE-789 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] climate pull request: CLIMATE-786 - Update rcmed.py and test_rcmed...

2016-04-29 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/336 CLIMATE-786 - Update rcmed.py and test_rcmed.py - Update rcmed.py file - Fix test_rcmed.py file Function `test_function_parameter_dataset_lats_monthly` is added to improve test

[GitHub] climate pull request: test 1

2016-04-29 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/335#issuecomment-215851989 Please do no close the PR. I'm waiting for OCWJenkins to comment on this PR with the test results. --- If your project is set up for it, you can reply to

[GitHub] climate pull request: test 1

2016-04-29 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/335 test 1 Jenkins test branch. Do Not Merge this branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate test

[GitHub] climate pull request: CLIMATE-785 - RCMED.py: optimize code

2016-04-28 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/334 CLIMATE-785 - RCMED.py: optimize code Fixes https://issues.apache.org/jira/browse/CLIMATE-785 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] climate pull request: CLIMATE-780 - Add Travis-CI build status to ...

2016-04-13 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/329 CLIMATE-780 - Add Travis-CI build status to README.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-780

[GitHub] climate pull request: CLIMATE-760 - Address documentation warnings

2016-04-13 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/328#issuecomment-209411521 @lewismc I'm not getting any such errors. I'm using sphinx 1.3.6 ``` docs[CLIMATE-760] % make html sphinx-build -b html -d build/doctrees so

[GitHub] climate pull request: CLIMATE-760 - Address documentation warnings

2016-04-12 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/328#issuecomment-208852444 @lewismc I was unable to reproduce all the errors in the Jira issue. I just pulled from the master branch and fixed all the issues that the documentation had

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-04-09 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-207817574 Yes Lewis. Exciting days ahead :dancers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] climate pull request: CLIMATE-760 - Address documentation warnings

2016-04-09 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/328 CLIMATE-760 - Address documentation warnings - Fix configuration_writer import error - Update table of contents tree You can merge this pull request into a Git repository by running

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-04-09 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-207815116 Here's the latest [build](https://travis-ci.org/jarifibrahim/climate/builds/121927729). Btw the Travis-CI does not use the install-ubuntu.sh scri

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-04-09 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-207812290 @Omkar20895 All dependency conflicts have been resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-04-07 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-207066640 @lewismc No. This issue has not been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] climate pull request: CLIMATE-776 - Update conda dependencies

2016-04-07 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/324#issuecomment-207040203 Thank you @lewismc @Omkar20895. Please take a look at the PR for [ubuntu-install.sh](https://github.com/apache/climate/pull/318) and [utils_tests](https

[GitHub] climate pull request: CLIMATE-776 - Update conda dependencies

2016-04-07 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/324#issuecomment-206982581 @Omkar20895 @lewismc Please merge this branch ASAP. The travis-ci build is failing because of conflicting dependencies. --- If your project is set up for it, you

[GitHub] climate pull request: CLIMATE-776 - Update conda dependencies

2016-04-06 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/324#issuecomment-206457535 @Omkar20895 Basemap does not work with numpy 1.11.0. It requires numpy 1.10* . I'll update h5py to 2.6.0. --- If your project is set up for it, you can rep

[GitHub] climate pull request: CLIMATE-776 - Update conda dependencies

2016-03-29 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/324 CLIMATE-776 - Update conda dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-776 Alternatively

[GitHub] climate pull request: CLIMATE-775 - Fix failing tests in ocw_confi...

2016-03-29 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/323#issuecomment-203018094 The tests failed on executing `nosetests` from the root climate folder. The tests had some improper imports. --- If your project is set up for it, you can reply

[GitHub] climate pull request: CLIMATE-774 - Fix failing tests

2016-03-29 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/322#issuecomment-203016653 The tests failed when they were executed from the root folder of climate project. Try executing `nosetests` from the root climate folder to reproduce these errors

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-03-29 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-203015997 @lewismc The script works fine. But there's a dependency issue. Is there a wiki page that lists the dependencies ? The existing `ocw-conda-dependency` fil

[GitHub] climate pull request: CLIMATE-773 - Add Continuous Integration (Tr...

2016-03-29 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/321#issuecomment-202998033 @lewismc Yes. The Travis build fails because of the bad tests but Travis works as expected. I've created a Travis-test branch which works fine after fixin

[GitHub] climate pull request: CLIMATE-775 - Fix failing tests in ocw_confi...

2016-03-28 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/323 CLIMATE-775 - Fix failing tests in ocw_config_runner You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-775

[GitHub] climate pull request: CLIMATE-774 - Fix failing tests

2016-03-28 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/322 CLIMATE-774 - Fix failing tests - Add 'mock' to pip-dependencies - Fix file path in test_utils.py You can merge this pull request into a Git repository by running: $ git

[GitHub] climate pull request: add Travis-CI config

2016-03-28 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/321 add Travis-CI config You can merge this pull request into a Git repository by running: $ git pull https://github.com/jarifibrahim/climate CLIMATE-773 Alternatively you can review and

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-03-04 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/318#issuecomment-192293306 @MichaelArthurAnderson @lewismc Could you please test this script? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] climate pull request: CLIMATE-766 Easy-ocw/install-ubuntu.sh scrip...

2016-03-02 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/318 CLIMATE-766 Easy-ocw/install-ubuntu.sh script is broken Can anyone please test this script and post the results. I have not tested it. I didn't want to mess with my installation. Yo

[GitHub] climate pull request: CLIMATE-759 - Fix failing test in test_datas...

2016-02-28 Thread jarifibrahim
GitHub user jarifibrahim opened a pull request: https://github.com/apache/climate/pull/315 CLIMATE-759 - Fix failing test in test_dataset_processor.py - fix tests in TestTemporalRebin class `TemporalRebin()` function passes the received parameters to

[GitHub] climate pull request: fix issue CLIMATE-759

2016-02-26 Thread jarifibrahim
Github user jarifibrahim commented on the pull request: https://github.com/apache/climate/pull/312#issuecomment-189380356 Yeah. I had fixed the issue but the tests were still returning false. I'll fix the tests and then push a PR. --- If your project is set up for it, you can

  1   2   >