Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-01 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs:

Review Request 23193: mark the test_01_primary_storage_iscsi as test that requires hardware

2014-07-01 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23193/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-7026

Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23194/ --- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs:

Re: 4.4 upgrade issues

2014-07-01 Thread ilya musayev
Carlos, Thanks for trying this out, If you want to understand how encryption and decryption works, look into /usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt as an example Specifically, these lines: #get the key from /etc/cloudstack/management/key msKey=$(cat

Re: 4.4 upgrade issues

2014-07-01 Thread ilya musayev
Also, the password is salted with timestamp (i assume), it will look different each time - but should decrypt correctly with proper key. On 6/30/14, 1:16 PM, Carlos Reátegui wrote: I found the comments in: https://issues.apache.org/jira/browse/CLOUDSTACK-3990 useful but how do I find out the

Network usage in Basic Zone

2014-07-01 Thread sebgoa
Morning, Nux opened https://issues.apache.org/jira/browse/CLOUDSTACK-6993 Talking to Fabrice it seems to be expected behavior. In Basic zones, traffic does not go through the VR and the network is shared. Fabrice pointed me to:

Re: Network usage in Basic Zone

2014-07-01 Thread Wei ZHOU
The network usage for individual vms can be fetched from hypervisor. I have changed for KVM (only), but not committed yet. 2014-07-01 9:59 GMT+02:00 sebgoa run...@gmail.com: Morning, Nux opened https://issues.apache.org/jira/browse/CLOUDSTACK-6993 Talking to Fabrice it seems to be

Re: Network usage in Basic Zone

2014-07-01 Thread Nux!
Thanks Sebastian and Wei, looking forward to having this working. Wei, if you have any patches for 4.3 I'd be more than willing to test. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Wei ZHOU ustcweiz...@gmail.com To:

Re: Network usage in Basic Zone

2014-07-01 Thread Wei ZHOU
Nux, I will change and commit it to 4.3 branch in the next days. -Wei 2014-07-01 10:28 GMT+02:00 Nux! n...@li.nux.ro: Thanks Sebastian and Wei, looking forward to having this working. Wei, if you have any patches for 4.3 I'd be more than willing to test. Lucian -- Sent from the Delta

Re: [QUERY] CLOUDSTACK-6885 Rsyslog not rotating

2014-07-01 Thread Sonal Ojha
The configuration for the rsyslog could be modified to add a size parameter to rotate the file if a specific size is reached. Modifying the rsyslog configuration under /etc/logrotate.d/ would do the job. Here is what I tried /var/log/mail.info /var/log/mail.warn /var/log/mail.err

[ACS 4.4] cherry-pick

2014-07-01 Thread Jayapal Reddy Uradi
Hi Daan, Please cherry-pick the following commits to 4.4 commit e336796cd5eae39bf7755d981426160a15bc6e9f CLOUDSTACK-7028: Fixed adding route for additional public nic on fail over commit a69c1ee31d233d4a6f77d68fd70b9cfe3c85f89b CLOUDSTACK-7027: Removing left over static nat rule

Re: [QUERY] CLOUDSTACK-6885 Rsyslog not rotating

2014-07-01 Thread Sonal Ojha
Forgot to mention , the default size defined in the logrotate.conf file is 50M which is applicable to all the log rotate configuration files. On Tue, Jul 1, 2014 at 3:23 PM, Sonal Ojha sonal.o...@sungardas.com wrote: The configuration for the rsyslog could be modified to add a size parameter

Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6873

Re: vhd-util location

2014-07-01 Thread Rohit Yadav
Hi Carlos, Carlos Reátegui wrote: Hi All, When does stuff get copied from [1] to [2] ? I ask because the docs (http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/latest/installation.html) say to download vhd-util and place it in [1] however the script that pushes it to

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/#review47049 --- Why are tests using simulator mock moved to 'maint' folder? If you

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Gaurav Aradhye
On July 1, 2014, 4:06 p.m., Koushik Das wrote: Why are tests using simulator mock moved to 'maint' folder? If you remove test_deploy_vm.py make sure that the following test is moved to another file. This is meant to test list VM with multiple 'ids'. @attr(tags = ['advanced',

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Koushik Das
On July 1, 2014, 10:36 a.m., Koushik Das wrote: Why are tests using simulator mock moved to 'maint' folder? If you remove test_deploy_vm.py make sure that the following test is moved to another file. This is meant to test list VM with multiple 'ids'. @attr(tags = ['advanced',

Re: OpenVM.eu - repository of Cloudstack images and appliances

2014-07-01 Thread Ian Duffy
Hi All, Debian templates have been added - http://dl.openvm.eu/cloudstack/debian They are built using debootstrap scripts, the packer/veewee route is slow without baremetal for template generation.

[ACS44][ACS431] Jira issues

2014-07-01 Thread Daan Hoogland
editting subject to attract attention On Mon, Jun 30, 2014 at 10:26 PM, sebgoa run...@gmail.com wrote: Folks, I am spending a couple minutes on jira tonight :) looking for bugs that are reported in 4.3.0 and may have been fixed in master but not cherry picked.. We have a lot of bugs… It

Re: [ACS4.4] Text change to cherry pick if it's not too late

2014-07-01 Thread Daan Hoogland
On Tue, Jul 1, 2014 at 5:33 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: 76930f6eab01d8659b71e5753111de52eca73b5b in -- Daan

Re: [ACS4.4] RC1

2014-07-01 Thread Daan Hoogland
Animesh, Do you send this as a counter proposal or overriding the procedure on the wiki? That is the one I am following. On Mon, Jun 30, 2014 at 9:56 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Daan We have been following the convention for Release VOTE threads like [1] as

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/ --- (Updated July 1, 2014, 5:54 p.m.) Review request for cloudstack and Santhosh

RE: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Santhosh Edukulla
Daan, You are added as reviewer, not sure why comments were disabled. Do you see it as an issue when used in its current form, considering original issue is to minimize the lookups? Can be helpful with this way, down the lane if we are to use entry for some other purpose? Assuming putall

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Gaurav Aradhye
On July 1, 2014, 4:06 p.m., Koushik Das wrote: Why are tests using simulator mock moved to 'maint' folder? If you remove test_deploy_vm.py make sure that the following test is moved to another file. This is meant to test list VM with multiple 'ids'. @attr(tags = ['advanced',

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

2014-07-01 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/ --- (Updated July 1, 2014, 5:56 p.m.) Review request for cloudstack, Koushik Das

Re: [ACS 4.4] cherry-pick

2014-07-01 Thread Daan Hoogland
2 in On Tue, Jul 1, 2014 at 11:56 AM, Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com wrote: Hi Daan, Please cherry-pick the following commits to 4.4 commit e336796cd5eae39bf7755d981426160a15bc6e9f CLOUDSTACK-7028: Fixed adding route for additional public nic on fail over commit

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Daan Hoogland
I think putAll is more efficient. On Tue, Jul 1, 2014 at 2:25 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Daan, You are added as reviewer, not sure why comments were disabled. Do you see it as an issue when used in its current form, considering original issue is to minimize

Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.

2014-07-01 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/#review47059 --- CLOUDSTACK-6665 says this is a problem in 4.3, but this patch only

RE: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Santhosh Edukulla
Daan, It seems equivalent, as per docs, Copies all of the mappings from the specified map to this map (optional operation). The effect of this call is equivalent to that of calling put(k, v) on this map once for each mapping from key k to value v in the specified map.

RE: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Santhosh Edukulla
Sorry, ver7 docs: http://docs.oracle.com/javase/7/docs/api/java/util/Map.html Santhosh From: Santhosh Edukulla [santhosh.eduku...@citrix.com] Sent: Tuesday, July 01, 2014 9:20 AM To: Daan Hoogland Cc: Abhinandan Prateek; cloudstack Subject: RE: Review

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Daan Hoogland
I like the concise syntax, not demanding. On Tue, Jul 1, 2014 at 3:32 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Sorry, ver7 docs: http://docs.oracle.com/javase/7/docs/api/java/util/Map.html Santhosh From: Santhosh Edukulla

RE: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Santhosh Edukulla
Sure, from next submission, will check on this. Please review other issues as well, it will help,and so not to introduce regression issues, please push accordingly. Santhosh From: Daan Hoogland [daan.hoogl...@gmail.com] Sent: Tuesday, July 01, 2014 9:38

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Daan Hoogland
I did review all, this was my only remark. You can push now, can you? On Tue, Jul 1, 2014 at 3:44 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Sure, from next submission, will check on this. Please review other issues as well, it will help,and so not to introduce regression

Re: [ACS4.4] RC1

2014-07-01 Thread Daan Hoogland
Rayees, I think setnextversion is not used. The code I see in there is copied and called from build_asf.sh these two issues are confirmed? On Mon, Jun 30, 2014 at 10:08 PM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi Daan, We need to remove SNAPSHOT from all pom.xml

Re: Review Request 23197: CLOUDSTACK-7031 Improve error handling in deployDataCenter.py

2014-07-01 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23197/#review47064 --- tools/marvin/marvin/deployDataCenter.py

Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin

2014-07-01 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23169/#review47065 --- tools/marvin/marvin/configGenerator.py

Re: Review Request 19616: Added check for null return.

2014-07-01 Thread Alex Hitchins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19616/ --- (Updated July 1, 2014, 3:29 p.m.) Review request for cloudstack. Changes

Re: vhd-util location

2014-07-01 Thread Carlos Reátegui
On Jul 1, 2014, at 3:25 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi Carlos, Carlos Reátegui wrote: Hi All, When does stuff get copied from [1] to [2] ? I ask because the docs (http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/latest/installation.html)

system VM looking for cloud0 bridge when OVS/GRE isolation is enabled

2014-07-01 Thread Kuang-Ching Wang
Hi, I am trying to set up my cloudstack using OVS plugin. I created an advanced zone with GRE isolation. When enabling zone, system VMs cannot start with the following exception. What did I miss? 2014-06-30 21:46:38,382 WARN [kvm.resource.LibvirtComputingResource]

openvswitch version with cloudstack

2014-07-01 Thread Kuang-Ching Wang
With ubuntu apt-get, openvswitch 1.4.6 is installed. Is there any reason that cloudstack cannot work with 1.4.6, and have to work with 1.9.0 as documented here https://cwiki.apache.org/confluence/display/CLOUDSTACK/KVM+with+OpenVSwitch? Thanks, KC

Re: Host in Alert state after upgrade

2014-07-01 Thread Carlos Reategui
So upset is part of the CSP. I tried re-installing it but the kernel modules are not there for my current kernel version. Here are the contents of the CSP: mount -o loop xenserver-cloud-supp.iso /mnt/tmp # ll /mnt/tmp/ total 1437 -r--r--r-- 1 root root 31340 Jan 24 2012

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

2014-07-01 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47114 --- http://i.imgur.com/PW7lqbs.png Six fields have been removed from

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Mike Tutkowski
This diff shows some of the problem: http://i.imgur.com/PW7lqbs.png Six fields have been removed from the volume_view and five of those six are still in use. It is not a simple matter of adding them back in, however, because the iso table that used to be used is no longer present in 4.5. That

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

2014-07-01 Thread Yoshikazu Nojima
On July 1, 2014, 6:19 p.m., Mike Tutkowski wrote: http://i.imgur.com/PW7lqbs.png Six fields have been removed from the volume_view and five of those six are still in use. Hi Mike, Thank you for let me know. I reproduced the issue. It seems this commit made change to the schema of

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

2014-07-01 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47133 --- Thanks! Also, thanks for opening a JIRA ticket. We can track this

Re: [ACS4.4] RC1

2014-07-01 Thread Daan Hoogland
thats the one, On Tue, Jul 1, 2014 at 8:16 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Daan Which wiki are you referring to. I am looking at this one https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure which was setup by Chip and we have followed all

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Yoshikazu Nojima
Hi Mike, I suppose iso is an alias for vm_template. See the left join syntax you refered. left join `cloud`.`vm_template` iso ON iso.id = volumes.iso_id Regards, Noji 2014-07-01 12:19 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com: This diff shows some of the

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Mike Tutkowski
Ah, yes, good point. On Tue, Jul 1, 2014 at 2:02 PM, Yoshikazu Nojima m...@ynojima.net wrote: Hi Mike, I suppose iso is an alias for vm_template. See the left join syntax you refered. left join `cloud`.`vm_template` iso ON iso.id = volumes.iso_id Regards, Noji

createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Demetrius Tsitrelis
registerTemplate has both the passwordenabled and sshkeyenabled parameters. So why doesn't createTemplate have both? Reference: http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/createTemplate.html

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Mike Tutkowski
Somehow I didn't see that aliasing going on there. On Tue, Jul 1, 2014 at 2:05 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Ah, yes, good point. On Tue, Jul 1, 2014 at 2:02 PM, Yoshikazu Nojima m...@ynojima.net wrote: Hi Mike, I suppose iso is an alias for vm_template. See

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23194/#review47136 --- Ship it! 97d296bfbd328f2c45e5be22c769447b7aa006df - daan Hoogland

Re: createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Wei ZHOU
ssh key is not fully implemented on UI. for example, on instance Wizard, create/register/delete ssh key, resetsshkey for vm, register template, etc. I have implemented some of them on 4.2 , it need to be changed for 4.3/4.4/master -Wei 2014-07-01 22:06 GMT+02:00 Demetrius Tsitrelis

RE: createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Demetrius Tsitrelis
Thanks, but I am not talking about the UI but the API. -Original Message- From: Wei ZHOU [mailto:ustcweiz...@gmail.com] Sent: Tuesday, July 01, 2014 1:18 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? ssh key is not fully implemented on UI. for

Re: createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Nux!
Isn't this feature inheritable? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Demetrius Tsitrelis demetrius.tsitre...@citrix.com To: dev@cloudstack.apache.org Sent: Tuesday, 1 July, 2014 9:24:55 PM Subject: RE:

RE: createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Demetrius Tsitrelis
Is it OK if I ask a stupid question? Inheritable from what? -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Tuesday, July 01, 2014 1:35 PM To: dev@cloudstack.apache.org Subject: Re: createTemplate API lacks sshkeyenabled? Isn't this feature inheritable? Lucian -- Sent

Doc on Network Throttling

2014-07-01 Thread Alena Prokharchyk
As I remember seeing the question on how Network throttling works in CS, so I’ve created a wiki page explaining the CS implementation. Feel free to review/update/fix: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack Anthony/Kelven/Edison/Rajesh, can you

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Yoshikazu Nojima
Hi all, I pushed a commit to fix this issue. I confirmed listVolumes doesn't throw an error now in my environment. Commit 890e71cb5c2f80b09cd4db7947d94e325d7bd182 in cloudstack's branch refs/heads/master from Yoshikazu Nojima [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=890e71c ]

RE: createTemplate API lacks sshkeyenabled?

2014-07-01 Thread Demetrius Tsitrelis
I see - thanks. But what if I created a VM from an .ISO? It still seems that I have to use createTemplate to make a template which CloudStack could use, but that API will not let me tell CloudStack that my new VM is running the SSH key reset script! Or is there some other API which I could

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Mike Tutkowski
Thanks! On Tue, Jul 1, 2014 at 4:26 PM, Yoshikazu Nojima m...@ynojima.net wrote: Hi all, I pushed a commit to fix this issue. I confirmed listVolumes doesn't throw an error now in my environment. Commit 890e71cb5c2f80b09cd4db7947d94e325d7bd182 in cloudstack's branch refs/heads/master from

Re: [ACS4.5] Can't access volumes on storage tab in GUI

2014-07-01 Thread Mike Tutkowski
Actually, this is a good opportunity to remind devs in general that if you make a change to a schema-upgrade file for a release and you are not on master that you should take a peek at the schema-upgrade file on master to see if it needs to be updated, as well. In this case, it would have been OK

[FYI] Interesting dashboard for ACS development process.

2014-07-01 Thread Nguyen Anh Tu
Hi guys, I just found an interesting dashboard about ACS development process. Fantasy: http://projects.bitergia.com/apache-cloudstack/browser/ Cheers, --Tuna

Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method

2014-07-01 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/#review47175 --- Commit 1e72e5a818b7bcc738262a2b10794a17fbb0076b in cloudstack's

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23194/#review47176 --- Can you attach a bug id ? Preferably the umbrella ticket id for

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Abhinandan Prateek
Santhosh, Do have a bug id with the patch, helps in tracking. -abhi On 01/07/14 5:55 pm, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: Daan, You are added as reviewer, not sure why comments were disabled. Do you see it as an issue when used in its current form, considering original

Re: Review Request 23194: Fixed Coverity reported performance issues

2014-07-01 Thread Daan Hoogland
Abhi, Why is this needed? It is a general code improvement inspired by the coverity report. In the past we did such improvements prefixing the comment with 'findbugs:' when we started on the findbugs reports. I think that suffices. On Wed, Jul 2, 2014 at 5:29 AM, Abhinandan Prateek