[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98250942 @koushik-das You sure this is needed for this PR to work? it seems to me this can be future work. Nothing will be broken more then it is now. --- If your projec

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98247992 @bhaisaab I'm preparing my lab to test your branch. Will do that in the weekend and let you know! --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: UI localization - hu

2015-05-01 Thread K0zka
GitHub user K0zka opened a pull request: https://github.com/apache/cloudstack/pull/224 UI localization - hu Added hungarian to the list of languages - resource file can be pulled from transifex You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] cloudstack pull request: Added new committer

2015-05-01 Thread thinktwo
GitHub user thinktwo opened a pull request: https://github.com/apache/cloudstack/pull/223 Added new committer You can merge this pull request into a Git repository by running: $ git pull https://github.com/thinktwo/cloudstack patch-2 Alternatively you can review and apply the

Build failed in Jenkins: build-master-slowbuild #1435

2015-05-01 Thread jenkins
See -- [...truncated 27152 lines...] [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cl

Build failed in Jenkins: simulator-singlerun #1185

2015-05-01 Thread jenkins
See -- Started by upstream project "build-master-simulator" build number 2002 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely o

Re: marvin test cases + travis

2015-05-01 Thread Rajani Karuturi
-1 on increasing the time As a reviewer, I would like an immediate response on a pull request. By the time I review the code, if CI gives a +1(or -1) I can close the PR then and there instead of coming back again to merge. I would suggest running all the jobs under 30 min and increasing the number

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98183123 Also callers for investigate()/isAgentAlive() methods needs to be fixed to handle Unknown instead of null. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98181315 @bhaisaab The 'null' semantics of all investigators needs to change to 'Unknown'. Just look at all classes that implements Investigator interface. (XS, KVM, Simul

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Simon Weller
Congratulations Remi. Much deserved! From: Daan Hoogland Sent: Friday, May 01, 2015 1:45 AM To: dev Subject: [ANNOUNCE] New committer: Remi Bergsma The Project Management Committee (PMC) for Apache CloudStack has asked Remi Bergsma to become a committer

[GitHub] cloudstack pull request:

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-11003795 Abhi, I think you can open a ticket with ASF infra to proxy asking Travis to increase build timeout to say 120mins instead of

[GitHub] cloudstack pull request:

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-11003784 In tools/travis/install.sh: In tools/travis/install.sh on line 28: Let's keep it, what if a commit passes a travis run

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Marcus
Congrats, well deserved. On Fri, May 1, 2015 at 8:39 AM, Rafael Fonseca wrote: > Congrats Remi :) > > On Fri, May 1, 2015 at 4:06 PM, Ahmad Emneina wrote: > > > Congrats Remi! > > > > On Thu, Apr 30, 2015 at 11:45 PM, Daan Hoogland > > > wrote: > > > > > The Project Management Committee (PMC)

Build failed in Jenkins: simulator-4.5-singlerun #233

2015-05-01 Thread jenkins
See -- Started by upstream project "build-4.5-simulator" build number 288 originally caused by: Started by upstream project "build-4.5" build number 470 originally caused by: Started by an

Jenkins build is still unstable: simulator-4.5-singlerun #232

2015-05-01 Thread jenkins
See

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Rafael Fonseca
Congrats Remi :) On Fri, May 1, 2015 at 4:06 PM, Ahmad Emneina wrote: > Congrats Remi! > > On Thu, Apr 30, 2015 at 11:45 PM, Daan Hoogland > wrote: > > > The Project Management Committee (PMC) for Apache CloudStack > > has asked Remi Bergsma to become a committer and we are pleased to > > annou

Jenkins build is still unstable: simulator-singlerun #1184

2015-05-01 Thread jenkins
See

Re: please help trying to change the ip of my secondary storage

2015-05-01 Thread Prashant s
Thanks for looking Somesh, i updated my dns to point to the new ip for the secondary storage url ... that solved my issue. But yes this document did not help me https://github.com/apache/cloudstack-docs/blob/master/en-US/changing-secondary-storage-ip.xml *we at isightpartners are runni

RE: Disable treshold for Secondary Storage?

2015-05-01 Thread Somesh Naidu
AFAIK, it does not. The global config is used by storage allocator. At the moment, we do not use allocators for Secondary Storage. Somesh CloudPlatform Escalations Citrix Systems, Inc. -Original Message- From: Andrija Panic [mailto:andrija.pa...@gmail.com] Sent: Thursday, April 30, 201

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Laszlo Hornyak
Congrats Remi! And happy Friday! :) On Fri, May 1, 2015 at 8:45 AM, Daan Hoogland wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in invest

RE: KVM HA

2015-05-01 Thread Somesh Naidu
There may not be any specific KVM.HA configuration. What are you looking for? Somesh CloudPlatform Escalations Citrix Systems, Inc. -Original Message- From: Budur Nagaraju [mailto:nbud...@gmail.com] Sent: Thursday, April 30, 2015 5:38 AM To: dev@cloudstack.apache.org Subject: KVM HA H

RE: please help trying to change the ip of my secondary storage

2015-05-01 Thread Somesh Naidu
Prashant, Looks like the doc you are referring to might be for older version. What version of ACS are you using? Somesh CloudPlatform Escalations Citrix Systems, Inc. -Original Message- From: Prashant s [mailto:opsrunb...@gmail.com] Sent: Saturday, April 25, 2015 2:47 PM To: dev@clouds

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98149776 @bhaisaab Thanks for the review. please dont merge this yet. Travis is still failing and would like to fix it. It would be good to have abhi's opinion.. --- If

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98148840 Another thing to note is that while changing some of this legacy understanding, it is not just the code that needs improvement/change, it is all the existin

[GitHub] cloudstack pull request: CLOUDSTACK-8335: removed ceph repository

2015-05-01 Thread K0zka
Github user K0zka commented on the pull request: https://github.com/apache/cloudstack/pull/221#issuecomment-98148819 Thank you @bhaisaab ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8335: removed ceph repository

2015-05-01 Thread K0zka
Github user K0zka closed the pull request at: https://github.com/apache/cloudstack/pull/221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread David Nalley
Sysadmins generally enjoy a single source of truth about what packages are installed on a machine. Telling folks to use gem, pypi and rpm/yum leads to many, occasionally conflicting, reports of what is actually installed on a machine. Hence the suggestion for OS-native packages. On Fri, May 1, 201

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98147939 LGTM, @abhinandanprateek - do you want to review and merge this one? --- If your project is set up for it, you can reply to this email and have your reply appear on

Build failed in Jenkins: build-master-slowbuild #1434

2015-05-01 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-6139: Fix regression, allow zone level systemvm localstorage config -- [...truncated 27144 lines...] [cobertura] INFO [main] net.sourceforge.co

[GitHub] cloudstack pull request: CLOUDSTACK-8335: removed ceph repository

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/221#issuecomment-98147733 @K0zka for some reason it did not close the PR, please close it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8335: removed ceph repository

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/221#issuecomment-98147509 Thanks for this @K0zka LGTM, merging on 4.5 now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread sebgoa
On May 1, 2015, at 3:27 PM, Jeff Moody wrote: > Rohit, > > I understand and have no issues with this, however, I can forsee parts > of our support organization wanting a binary package (from Citrix) > when this change hits. > > I was just adding my $0.02 to the discussion of "does anyone use t

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98146018 @DaanHoogland thanks, I've fixed the issues now. Removed dead code where null check is not required as the method only return Unknown/Up/Down. --- If your project i

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98143582 @dahn you're right, I looked at the code and made some semantic changes around debugging/logging and return value type. I guess there are some parts in the source co

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98143398 @bhaisaab Remi told me he will test. LGTM except that the null check is redundant. We could remove it --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/222#discussion_r29503805 --- Diff: server/src/com/cloud/ha/ManagementIPSystemVMInvestigator.java --- @@ -78,7 +78,7 @@ public Boolean isVmAlive(VirtualMachine vm, Host host) {

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98142160 @dahn @snuf @remibergsma @koushik-das @abhinandanprateek can anyone of you help review this patch? It simply replaces the null semantics with the Status.Unknown sta

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-01 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/222 server: Introduce Unknown Status to be used in AbstractInvestigatorImpl The PR #211 introduced changes where the abstract investigator testIpAddress() would return other Status, which previ

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Ahmad Emneina
Congrats Remi! On Thu, Apr 30, 2015 at 11:45 PM, Daan Hoogland wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in investigating and solving

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Erik Weber
Congratulations Remi! Erik Den fredag 1. mai 2015 skrev Daan Hoogland følgende: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in investigating

Re: [GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread Daan Hoogland
I finally got around a further code analysis and must conclude that returning ALERT is no problem. Status testIpAddress(Long hostId, String testHostIp), is called twice and in both cases null is checked for avoiding NPE and next only the cases UP and DOWN are handled. So the behaviour on a null re

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread Jeff Moody
Rohit, I understand and have no issues with this, however, I can forsee parts of our support organization wanting a binary package (from Citrix) when this change hits. I was just adding my $0.02 to the discussion of "does anyone use the AWS API" and expressing that my employer has little to no co

Re: Jenkins build is back to normal : build-master-slowbuild #1429

2015-05-01 Thread Daan Hoogland
I gave it a first shot, please shoot back Op vr 1 mei 2015 om 13:33 schreef Daan Hoogland : > I have no idea. will have a look > > Op vr 1 mei 2015 om 13:31 schreef Koushik Das : > > Hi Daan, >> In the slow build report mails, is it possible to add the findbug >> failures at the top along with th

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread Rohit Yadav
Hi Jeff, Thanks for sharing. ec2stack is available from pypi, so while we can build debs/rpms it can be easily installed using “pip install ec2stack”. The only migration path required by your users would be to change the consumer URL and re-register apikey/secretkey. > On 01-May-2015, at 3:11

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread Jeff Moody
As this change will likely affect Citrix CloudPlatform, I can say that at Datapipe we offer the AWS API endpoint to customers because we had a request for it in the past. It was used once by a customer who then changed to using the native CloudStack API. When this change hits a release of Citrix C

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Nux!
Congratulations! :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Daan Hoogland" > To: "dev" > Sent: Friday, 1 May, 2015 07:45:12 > Subject: [ANNOUNCE] New committer: Remi Bergsma > The Project Management Committee (PMC) for Apach

Re: jenkins jobs

2015-05-01 Thread Daan Hoogland
there is an account named laszlo.hornyak Op vr 1 mei 2015 om 14:11 schreef Laszlo Hornyak : > Hi Daan, > > I tried to dig into the problem, but I have no access to the agents. If you > can give me an account, I'd really like to help! > > Best regards, > Laszlo > > On Fri, May 1, 2015 at 1:27 PM,

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98127447 Please don't revert. It is on the 4.4 branch as well. It passes all tests and we have yet to create a test that show this hypothetical regression. If we have I'l

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98126407 Guys - do we have any consensus on this issue? I'm planning to cut a 4.5.1 RC on Monday, if we are not very clear I would like to revert this on 4.5 to avoid any reg

Jenkins build is still unstable: simulator-singlerun #1183

2015-05-01 Thread jenkins
See

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Pierre-Luc Dion
Congrats Remi! On Fri, May 1, 2015 at 8:07 AM, Mike Tutkowski wrote: > Congratulations, Remi! > > On Friday, May 1, 2015, Daan Hoogland wrote: > > > The Project Management Committee (PMC) for Apache CloudStack > > has asked Remi Bergsma to become a committer and we are pleased to > > announce

Re: Routing Feature while registering template.

2015-05-01 Thread Prashant Kumar Mishra
Which template r u using ? ,Try with default system vm template. After registering go to global settings and search for router.template ,depend on hypervisor update the setting with template id/uuid . prashant On 5/1/15, 12:44 PM, "raja sekhar" wrote: >Hi all, > >while we are uploading templa

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98124888 these tests are explicitly disabled in the pom.xml using skipTests=true refactored a but and not using skipTests now. --- If your project is set up for it, you c

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread sebgoa
On May 1, 2015, at 12:02 PM, Daan Hoogland wrote: > OK, I do not want to push a formal point, just warning. > understood. let's see if other folks are worried about ec2interface upgrade/change. > Op vr 1 mei 2015 om 09:57 schreef Wido den Hollander : > >> -BEGIN PGP SIGNED MESSAGE-

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Mike Tutkowski
Congratulations, Remi! On Friday, May 1, 2015, Daan Hoogland wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in investigating and solving m

Re: jenkins jobs

2015-05-01 Thread Laszlo Hornyak
Hi Daan, I tried to dig into the problem, but I have no access to the agents. If you can give me an account, I'd really like to help! Best regards, Laszlo On Fri, May 1, 2015 at 1:27 PM, Daan Hoogland wrote: > LS, > > For anybody looking for a pastime; Our jenkins jobs are far from clean at >

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98120238 @remibergsma Yes XS (6.5) pool HA was enabled. @DaanHoogland Agree on the new state UNKNOWN --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8335: removed ceph repository

2015-05-01 Thread K0zka
GitHub user K0zka opened a pull request: https://github.com/apache/cloudstack/pull/221 CLOUDSTACK-8335: removed ceph repository Backport to 4.5 Signed-off-by: Laszlo Hornyak Signed-off-by: Rajani Karuturi You can merge this pull request into a Git repository by runni

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98117972 There are two unittests failing with the below error ```java Running org.apache.cloudstack.storage.resource.NfsSecondaryStorageResourceTest Tests run: 1,

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98114499 job 1: timed out in the deploy datacenter phase. debugging job10: timed out. removed one more test file --- If your project is set up for it, you can reply to th

Re: Jenkins build is back to normal : build-master-slowbuild #1429

2015-05-01 Thread Daan Hoogland
I have no idea. will have a look Op vr 1 mei 2015 om 13:31 schreef Koushik Das : > Hi Daan, > In the slow build report mails, is it possible to add the findbug failures > at the top along with the commit ids? > > -Koushik > > -Original Message- > From: Daan Hoogland [mailto:dhoogl...@schu

jenkins jobs

2015-05-01 Thread Daan Hoogland
LS, For anybody looking for a pastime; Our jenkins jobs are far from clean at the moment. I spent far to much time on them the past few weeks and am far from done. Please feel free to chip in. thanks Daan

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Wilder Rodrigues
Woot! Congratulations and welcome to the club, Remi! :) Cheers, Wilder On 01 May 2015, at 08:45, Daan Hoogland wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi h

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Koushik Das
Congrats Remi! On 01-May-2015, at 12:15 PM, Daan Hoogland wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in investigating and solving man

RE: Jenkins build is back to normal : build-master-slowbuild #1429

2015-05-01 Thread Koushik Das
Hi Daan, In the slow build report mails, is it possible to add the findbug failures at the top along with the commit ids? -Koushik -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: Friday, 1 May 2015 14:31 To: dev@cloudstack.apache.org Subject: FW: Jenki

Re: [DISCUSS] 4.6 release management

2015-05-01 Thread Daan Hoogland
Let's not do more quality improvement proces but just improve quality. If anybody want to add to the pages on the wiki, you're welkom but nobody did for long time. +1 for the present state of Sebastien's views on things. We can refine at any time. Op vr 1 mei 2015 om 09:55 schreef sebgoa : > > On

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98104904 Koushik, I'd rather have the state machine never return null and create a state UNKNOWN. The alert.wait parameter can check for this before setting the sta

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98104693 @koushik-das Since CloudStack 4.4 XenHA is the one to elect the new pool master. Before, CloudStack would force an election. Personally I do not like this new beh

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98100569 One possible solution I can think of the original problem for this PR is to wait for sometime (say based on the config parameter alert.wait) and if even after tha

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98100363 I looked at the code and saw that if investigate() is not able to determine the state of host then by default Alert is returned, earlier it was null. This may not

[GitHub] cloudstack pull request: maven plugin cleanup

2015-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: maven plugin cleanup

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/220#issuecomment-98099270 travis failures are not related to this change. Pushing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Re: [DISCUSS] Moving to Java 8

2015-05-01 Thread Wilder Rodrigues
Hi Marcus, Sorry for the push, I think after doing the whole CitrixResourceBase refactor I also got a bit attached to the whole thing/solution. ;) Thanks for the input you gave. I will finish the refactor and apply it to both implementations. Cheers, Wilder On 01 May 2015, at 09:06, Marcus

[GitHub] cloudstack pull request: Fixed two coverity reported issues

2015-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/218#issuecomment-98097425 @abhinandanprateek job 1: timedout. since its running unittests, should we decrease the tests there? may be run only unit tests job 9: timedout job

[GitHub] cloudstack pull request: Fixed two coverity reported issues

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/219#issuecomment-98095126 In the current usage of it, they are utf8. Also, it uses UTF-8 for the key. I will go ahead and merge. Thanks for the review Daan. --- If your project is s

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98093700 Daan, Yes, I agree. We can define a proper state and introduce it. I guess there is some tribal knowledge involved here that Koushik and myself were

RE: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Giles Sirett
Congrats Remi - well deserved Kind Regards Giles D: +44 20 3603 0541 | M: +44 796 111 2055 giles.sir...@shapeblue.com > -Original Message- > From: Abhinandan Prateek [mailto:abhinandan.prat...@shapeblue.com] > Sent: 01 May 2015 08:43 > To: dev@cloudstack.apache.org > Subject: Re: [ANN

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98091401 I agree with Koushik here. The purpose of an HA investigator is to either say that host is UP or Down or it does not know for sure. A host that has not ret

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98091566 Abhinandan, I think that is a design flow and we should revisit. I doubt that it is relevant to this fix however. The stjatemachine was resetting the state

Re: [4.5.1] cloudstack HA

2015-05-01 Thread Abhinandan Prateek
Ok did more investigation into the code, I am adding my comments to the pull request. > On 01-May-2015, at 2:21 pm, Abhinandan Prateek > wrote: > > > The commit to 4.5 - b222386bcb777bbdc2504e01fa60c0ded466c96d, has the > potential to interfere with cloudstack HA. > The way HA is implemented

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread Daan Hoogland
OK, I do not want to push a formal point, just warning. Op vr 1 mei 2015 om 09:57 schreef Wido den Hollander : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > > On 01-05-15 09:17, sebgoa wrote: > > > > On Apr 30, 2015, at 11:06 PM, Rohit Yadav > > wrote: > > > >> Hi, > >> > >>> On 30-Apr

Jenkins build is still unstable: simulator-singlerun #1182

2015-05-01 Thread jenkins
See

[GitHub] cloudstack pull request: Fixed two coverity reported issues

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/219#issuecomment-98087976 travis has errors in one of the jobs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98087158 The way HA is implemented, “null” is a valid return value from an investigator. The valid values are Up, Down or null. https://cwiki.apache.org/conf

[GitHub] cloudstack pull request: Fixed two coverity reported issues

2015-05-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/219#issuecomment-98087059 LGTM. If you are sure the bytes are always UTF8 and not platform defined, this is fine. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: maven plugin cleanup

2015-05-01 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/220 maven plugin cleanup 1. removed redundant maven-site-plugin 2. added maven-resources-plugin version 2.7 which has the fix for http://jira.codehaus.org/browse/MRESOURCES-140 You can m

Jenkins build is still unstable: simulator-4.5-singlerun #231

2015-05-01 Thread jenkins
See

[GitHub] cloudstack pull request: Fixed two coverity reported issues

2015-05-01 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/219 Fixed two coverity reported issues Dereference after null check Dm: Dubious method used You can merge this pull request into a Git repository by running: $ git pull https://github.com/

FW: Jenkins build is back to normal : build-master-slowbuild #1429

2015-05-01 Thread Daan Hoogland
Guys and dolls, Let¹s all keep our eyes on the jenkins to make sure the slow build keeps clean. I know everybody has been numbed by the mail bombardement over the past, but it would really help keeping an eye on this. The last fix I made was not interesting at the moment. Some others are, though.

[GitHub] cloudstack pull request: travis: run junit tests only in one job

2015-05-01 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/218 travis: run junit tests only in one job added DONOTRUNUNITTESTS variable for each of the jobs. The value is false only in the first job You can merge this pull request into a Git repository

[4.5.1] cloudstack HA

2015-05-01 Thread Abhinandan Prateek
The commit to 4.5 - b222386bcb777bbdc2504e01fa60c0ded466c96d, has the potential to interfere with cloudstack HA. The way HA is implemented, “null” is a valid return value from an investigator. The valid values are Up, Down or null. https://cwiki.apache.org/confluence/display/CLOUDSTACK/High+

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Suresh Ramamurthy
Great... Congrats Remi.. Thanks, Suresh On Fri, May 1, 2015 at 9:40 AM, Rohit Yadav wrote: > Congrats Remi! > > > On 01-May-2015, at 8:45 am, Daan Hoogland > wrote: > > > > The Project Management Committee (PMC) for Apache CloudStack > > has asked Remi Bergsma to become a committer and we are

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Rohit Yadav
Congrats Remi! > On 01-May-2015, at 8:45 am, Daan Hoogland wrote: > > The Project Management Committee (PMC) for Apache CloudStack > has asked Remi Bergsma to become a committer and we are pleased to > announce that he has accepted. > > Remi has reported and helped in investigating and solving ma

[GitHub] cloudstack pull request:

2015-05-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-10998875 All the jobs except the first failed. looks like there are some unitest failures. will debug and then put a PR. Also, the var

Jenkins build is still unstable: simulator-singlerun #1181

2015-05-01 Thread jenkins
See

Re: RFC: Removing 1M lines of junk

2015-05-01 Thread Wido den Hollander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01-05-15 09:17, sebgoa wrote: > > On Apr 30, 2015, at 11:06 PM, Rohit Yadav > wrote: > >> Hi, >> >>> On 30-Apr-2015, at 7:43 pm, Daan Hoogland >>> wrote: >>> >>> We will have to provide a migration path if anybody is actually >>> using it. >

Re: [DISCUSS] 4.6 release management

2015-05-01 Thread sebgoa
On May 1, 2015, at 12:52 AM, Pierre-Luc Dion wrote: > Hi, > > In my mind it was kind of making more sense to start by keeping 4.6 into a > separate branch, enforce pull-requests and deploy the CI. smaller step but > faster result, and from there, once we get stable with the CI I hear you. But

Re: [ANNOUNCE] New committer: Remi Bergsma

2015-05-01 Thread Abhinandan Prateek
Congrats Remi, welcome to the team ! -abhi > On 01-May-2015, at 12:37 pm, sebgoa wrote: > > Well done, > > > On May 1, 2015, at 9:04 AM, Rajani Karuturi wrote: > >> congratulations Remi :) >> >> ~Rajani >> >> On Fri, May 1, 2015 at 12:15 PM, Daan Hoogland >> wrote: >> >>> The Project Managemen

  1   2   >