[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082107 @DaanHoogland @runseb @bhaisaab @remibergsma Does the LGTM idea also apply to integration tests? Cheers, Wilder --- If your project

New Defects reported by Coverity Scan for cloudstack

2015-07-07 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 2 new defect(s) introduced to cloudstack found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New

New Defects reported by Coverity Scan for cloudstack

2015-07-07 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 2 new defect(s) introduced to cloudstack found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New

marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

2015-07-07 Thread Urvi Shah
Hi, I am trying to run marvin tests on cloudstack 4.3. the steps that i followed are as follows : 1. build marvin from cloudstack 4.3 local repo using : 'mvn -P developer -pl :cloud-marvin' 2. copied tools/marvin/dist/Marvin-0.1.0.tar to the server where i want to run marvin tests. 3.

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread nitt10prashant
GitHub user nitt10prashant reopened a pull request: https://github.com/apache/cloudstack/pull/507 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone disable enable cluster ... === TestName: test_01_disable_enable_cluster | Status : SUCCESS === ok disable enable

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082514 I have let Gaurav take care of things before because he was the only one actually looking. I don't think we can afford to demand 2 LTGM on integration tests. I

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119082808 Fair enough. I'm just asking because it should be made clear on the list. It's already difficult to get 2 LGTM on the Java stuff, not many people

Re: marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

2015-07-07 Thread Daan Hoogland
Can you try unistalling or using --upgrade in the pip command? If that doesn't work can you try a 4.6/master version of marvin? rgards, On Tue, Jul 7, 2015 at 4:30 AM, Urvi Shah urvi.s...@nuagenetworks.net wrote: Hi, I am trying to run marvin tests on cloudstack 4.3. the steps that i

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/507#issuecomment-119083411 first let us not limmit the LTGM to commiters in the case of integration tests. As for information, we will have to ask for it. Finally I want for us to have a

[ACS4.5] status

2015-07-07 Thread Daan Hoogland
I haven't heard of this in a few days. Does anyone keep track of 4.5 releasebility at the moment? I would like to move on to 4.6:) So can we make a release candidate for 4.5.2 yet? -- Daan

Re: marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

2015-07-07 Thread Santhosh Edukulla
Hi Urvi, Just go to ../tools/marvin directory under CS and run *python setup.py install.* Regards, Santhosh On Tue, Jul 7, 2015 at 4:10 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Can you try unistalling or using --upgrade in the pip command? If that doesn't work can you try a

pull request builder for rat

2015-07-07 Thread Daan Hoogland
H, for my own and your convenience I made a pull request builder at builds.a.o yesterday. It seems to work and it will report license issues in the PR or give an ok. I haven't seen an error apear yet So no idea how that looks but I imagine it'll give you a link from the PR to the build pointing

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-07-07 Thread nitt10prashant
Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/507 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/539#issuecomment-119087564 @bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [ACS4.5] status

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 11:47 am, Daan Hoogland daan.hoogl...@gmail.com wrote: I haven't heard of this in a few days. Does anyone keep track of 4.5 releasebility at the moment? Yes. I’ve shared this earlier that I plan to start this in 1-2 weeks time, till then I’m looking for regressions and

Re: [PROPOSAL] Commit to master through PR only

2015-07-07 Thread sebgoa
On Jul 3, 2015, at 12:01 PM, Wilder Rodrigues wrodrig...@schubergphilis.com wrote: Hi John, If you look at the discrete operations wearing a hat of a Project Manager, you won’t care… neither would I. However, from a Software Engineer perspective, as much as the other people contributing

[GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc

2015-07-07 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/558#discussion_r34012792 --- Diff: test/integration/component/test_vpc_redundant.py --- @@ -0,0 +1,506 @@ +# Licensed to the Apache Software Foundation (ASF) under one

Re: [ACS4.5] status

2015-07-07 Thread sebgoa
On Jul 7, 2015, at 8:17 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: I haven't heard of this in a few days. Does anyone keep track of 4.5 releasebility at the moment? I would like to move on to 4.6:) So can we make a release candidate for 4.5.2 yet? if you think it needs to be done, just

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-07-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-119087493 @bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear

RE: marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

2015-07-07 Thread SHAH, Urvi (Urvi U)
Hi Santosh, I had already tried doing “python setup.py install”. Thanks, Urvi -- Forwarded message -- From: Santhosh Edukulla santhosh.eduku...@gmail.commailto:santhosh.eduku...@gmail.com Date: Mon, Jul 6, 2015 at 11:17 PM Subject: Re: marvin installation error on cloudstack

Re: defects cleanup drive...

2015-07-07 Thread Daan Hoogland
To avoid misunderstanding arising from my unclear way of communicating: I propose(d): Let us base ourselves on integration testing whenever we can. Let us seek affirmation by reporters whenever we can. Let us not take the luxury to require both before closing issue but act on either. On Tue,

CS DR Staus

2015-07-07 Thread Keerthiraja SJ
Hi All, Will the DR solution of Alena Prokharchyk will be implemented in the next release of CS. Or is there any DR solution available other than this. Thanks, Keerthi

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi raj...@apache.org wrote: This not a good candidate for squashing/huge commit. If a regression is found in any of the fixes, it will be easier to just revert it than reverting all the 70 commits. ~Rajani Thanks Rajani, I allready made a booboo

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-07-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-singlerun #1342

2015-07-07 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1342/ -- Started by upstream project build-master-simulator build number 2159 originally caused by: Started by an SCM change Started by upstream project build-master build number 2449 originally

defects cleanup drive...

2015-07-07 Thread Raja Pullela
Hi, There are a number of Resolved Defects and was wondering if some of us can work on closing the defects - I know this is one of the things that Sebastien had on the To Dos... Following is a snapshot from today... Blockers : 114 Criticals: 556 Majors

RE: defects cleanup drive...

2015-07-07 Thread Raja Pullela
Daan, appreciate the quick response... we can go that route for the less Priorities ones and higher priorities ones, we should make an effort to validate/close. Otherwise, not sure when we will be able to bring the counts down ? blockers/criticals are higher risk items as well... Other

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rajani Karuturi
This not a good candidate for squashing/huge commit. If a regression is found in any of the fixes, it will be easier to just revert it than reverting all the 70 commits. ~Rajani On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 07-Jul-2015, at 3:40 pm, Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

2015-07-07 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119188008 Test assign Vm to different account ... SKIP: unsupported storage type Test assign Vm to different account ... SKIP: unsupported storage type Stop

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

2015-07-07 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119189897 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 3:29 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: I want permission to go ahead and address these issues and not create one huge or 73 small PRs. Can I? One huge commit would be fine, testing/merging 73 small PRs is going to be some work.

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread sebgoa
On Jul 7, 2015, at 12:10 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. are you automating those commits ? I would not mind scanning through them and giving green light. and in that case squash might be

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-07 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/539#discussion_r34026647 --- Diff: server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java --- @@ -52,17 +55,25 @@ public void

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
Rohit, are you basing this on 4.5? seems like a feature (meaning it should be based on master). On Tue, Jul 7, 2015 at 11:42 AM, bhais...@apache.org wrote: Repository: cloudstack Updated Branches: refs/heads/4.5-ui-plugin-enhancement [created] f8693d24a ui: Allow UI plugins to be shown

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 12:16 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Depends - I would want this. One could say it’s a bug that UI plugins are listed but hidden (see the code, a li is added, but if the section is a plugin it hides it by setting display:none). ​I can go for that :) ​

Re: defects cleanup drive...

2015-07-07 Thread Daan Hoogland
Raja, thanks for picking this up. I have practiced the principle of awaiting (at least verbal) confirmation from the reporter that an issue could indeed be closed. With the increased activity on integration tests we might base ourselves on that. ideas? On Tue, Jul 7, 2015 at 11:42 AM, Raja

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-07-07 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-119151038 changes looks good. Please go ahead with the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
Guys `n' Dolls, I want an exception to the rule requiring two LGTMs for any commit: coverity reports 73 high impact issues at the moment. All of them are resource leaks that can be solved by the well known pattern of using try-with-resource. We (and I do mean a lot of us) have been fixing this in

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 07-Jul-2015, at 3:29 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: I want permission to go ahead and address these issues

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
ok, but we should not wait with a release for this or wait releasing 4.6? On Tue, Jul 7, 2015 at 12:02 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 07-Jul-2015, at 3:17 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Rohit, are you basing this on 4.5? seems like a feature (meaning it

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Rohit Yadav
Depends - I would want this. One could say it’s a bug that UI plugins are listed but hidden (see the code, a li is added, but if the section is a plugin it hides it by setting display:none). Quick question - if a new feature, refactoring work or enhancement is sent for master, will they be

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits. On Tue, Jul 7, 2015 at 12:15 PM, sebgoa run...@gmail.com wrote: On Jul 7, 2015, at 12:10 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: I will not do it in one commit, if we insist on a PR i will do 73 commits

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 3:40 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. Fine. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]

[GitHub] cloudstack pull request: coverity resource leaks

2015-07-07 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/564 coverity resource leaks This PR holds fixes for different resource leaks of the type that can be fixed by using try-with resource. The complete category is to be absent from coverity

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

2015-07-07 Thread nitt10prashant
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/565 CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc issue --- All test cases are failing due to unsupported storage type solution --- skip

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

2015-07-07 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/563 ui: Allow UI plugins to be shown on navigation bar Introduces a boolean option in UI plugins setting it to 'true' would display the UI plugin on the left navigation bar.

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 3:17 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: Rohit, are you basing this on 4.5? seems like a feature (meaning it should be based on master). Not a feature but refactoring - I want to show any UI plugin on left nav without forking the

Any Plan on developing the cloudstack on this

2015-07-07 Thread Keerthiraja SJ
Hi All, Since the DR structure is not ready yet in the CS 4.5.x is there any plan to on Zone to Zone VM Migration this will really help us to make the DR implementation or region to region migration for both xenserver and kvm. Thanks, Keerthi