Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/662#issuecomment-129323691
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/668
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
-Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
-Fixed pep8 issues
You can merge this pull request
Github user pritisarap12 closed the pull request at:
https://github.com/apache/cloudstack/pull/645
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/645#issuecomment-129316634
C
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/665#issuecomment-129314182
Updated testcase:
-Removed redundant code
-Added validate_list function for list snapshot operation
---
If your project is set up for it, you
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129310396
Updated testcase with review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129300344
@remibergsma Thanks for testing the PR. This is a best-effort fix. The
change just schedules the restart of the system VMs ahead of the user VMs. Now
if there ar
Github user manuiiit commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129300171
@remibergsma I used it for debugging purpose as a build failed.Removed it
now.Thanks.
---
If your project is set up for it, you can reply to this email and have yo
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36602070
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+
Hi Mike,
Thanks! It seems the testing / verification is still to do and that is the
work. Merging itself can be done with a one-liner.
Are you able to verify the fix in your lab?
Sent from my iPhone
> On 10 Aug 2015, at 04:13, Mike Tutkowski wrote:
>
> I could take this one:
>
> CLOUDSTACK
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36601640
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36601607
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under on
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36601462
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under on
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36601402
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under on
Hi Remi,
I'll work on these PRs and finalize them. Will send new PRs for them. As
Likitha is not responding, Can we take up the testcases for LGTM(s) PRs later
and merge them?
Thanks,
Suresh
-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: Monday, 10
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-129292846
@remibergsma,
Rebased the branch to latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
I could take this one:
CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
#547
https://github.com/apache/cloudstack/pull/547
==> 1x LGTM
I asked this in the PR discussion, but are we under the impression that
this code has been tested well enough? If so, I can just merge it
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129276125
The code LGTM. Are we under the assumption that it was properly tested? If
so, I can just merge it at this point.
---
If your project is set up for it, you c
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r36592822
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description = "
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-129228698
@DaanHoogland So, you suggest putting the new tests in a separate PR and
add relevant unit tests that test the change in this PR? That sounds good to
me. Let's c
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/645#issuecomment-129228411
@pritisarap12 Any update on this PR? We cannot merge with conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129228123
@manuiiit It seems an extra change got in (tools/travis/before_install.sh)
apart from the template permission issue. Please remove it from this PR as it
is not r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/562#issuecomment-129227087
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/540#issuecomment-129227064
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129227036
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/548#issuecomment-129227023
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/544#issuecomment-129227052
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-129227018
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/555#issuecomment-129227012
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/556#issuecomment-129227002
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/561#issuecomment-129226987
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Hi all,
These are 9 PRs sent by Likitha. If I understand correctly Likitha is no longer
working with Citrix/ACS. The PRs seem mostly VMware related. Some have LGTM(s),
most have comments about missing unit tests.
What do we want to do with them? There's probably not gonna be an update from
Lik
32 matches
Mail list logo
