[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-142515867 @wilderrodrigues test cases 1. advanced zone (1) a shared network for domain domain1. account1: in domain 1, one isolated net

debugging in eclipse

Hi friends, I'm not a Java developer but I'm interested to do some discoveries in CloudStack code. I have created a development environment with Eclipse in Ubuntu and I can successfully compile and run CloudStack 4.5.2 in this environment. The question is how can I use Eclipse to debug and trace

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-142520701 I am not merging this as I see a -1 from @wilderrodrigues @wilderrodrigues, unittests are added and steps to test are also available. Can you review again? --

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-142520584 Tested this on a xenserver 6.5 setup. delete host/storage pool/cluster/pod/network/zone are all successful. :+1: --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/683#issuecomment-142531937 The result of operation is captured in the list volume validation following the call to query_async_job method. Hence didn't capture the return value of call to fu

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142532171 LGTM !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/871 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

LGTM!! On Wed, Sep 23, 2015 at 2:15 PM, pavanb018 wrote: > Github user pavanb018 commented on the pull request: > > https://github.com/apache/cloudstack/pull/683#issuecomment-142531937 > > The result of operation is captured in the list volume validation > following the call to query_asy

[GitHub] cloudstack pull request: Cloudstack 8902

GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/877 Cloudstack 8902 In an EIP zone, restarting a network with cleanup option checked , is failing with NumberFormatException. tested manually. You can merge this pull request into a Git

[GitHub] cloudstack pull request: Cloudstack 8902

Github user bvbharatk closed the pull request at: https://github.com/apache/cloudstack/pull/877 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-142570859 Okay... we got 2 LGTM with proper testing/reporting. Thanks guys for taking your time to look into it. ping @borisroman @remibergsma @karuturi @wido

BVT report 9/22

BVT report XS Basic – 98.6%, one test failed; a test script issue XS Adv – 93.4%, one test failed; a test script issue XS EIP – 98.5%, VMWare Adv – 82.4% KVM Basic – Deployment failed/KVM agent issue – scheduled another run in 2 hrs with Boris’ checkin to fix the agent issue. Ran the tests o

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/845 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r40195709 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List volumes, StoragePool

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/867#discussion_r40195834 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py --- @@ -116,6 +116,7 @@ def has_chain(self, table, chain): def has_rule(self

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/864#discussion_r40195974 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid, f

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-142581607 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/875#issuecomment-142596258 Thank you @pdion891 @karuturi. Fixed in the last commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/878 [4.6][BLOCKER]CLOUDSTACK-8890: Added isEmpty() check to prevent nullPointerException. Check if the list is empty before trying to get the first entry. If the list is empty, in example when d

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/878#issuecomment-142601843 This looks good, but does this have an impact elsewhere? Did you test listing vms by user_id? --- If your project is set up for it, you can reply to this email and ha

Re: debugging in eclipse

Hi Alireza, A way to do it is to run CS from the terminal with these 2 commands from the root of your CS directory: $ export MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=800m -Xmx2g -Xdebug -Xnoagent -Djava.compiler=NONE -Xrunjdwp:transport=dt_socket,address=4000,server=y,suspend=n -Djava.net.preferIPv4S

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/878#issuecomment-142604837 Seems good to me. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/878#issuecomment-142605044 Listing vm's by user_id will work as assumed; for projects the vm will be listed by the user who created it. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/878#issuecomment-142606607 @borisroman True, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-142608948 @jburwell, I've adapted the PR and implemented your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8890: Added isEm...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/878 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-142621231 Thanks @nlivens. I will review your comment and the updates later today or early tomorrow (24 Sept 2015). --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/875#issuecomment-142633106 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

GitHub user pdube opened a pull request: https://github.com/apache/cloudstack/pull/879 CLOUDSTACK-8793 Enable s2s VPN connection for projects You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdube/cloudstack CLOUDSTACK-8793 Alter

Re: new user in Jira

Thanks Rajani, PL On Wed, Sep 23, 2015 at 12:29 AM, Rajani Karuturi < rajani.karut...@citrix.com> wrote: > Hi PL, > I added Patrick to the contributors list. > I also added you to the PMC list on jira. > > ~Rajani > > > > On 23-Sep-2015, at 3:59 am, Pierre-Luc Dion wrote: > > > Thanks guys for

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142696052 @pavanb018 @nitt10prashant Could you please add what you tested next time? A LGTM without any explanation doesn't really tell me anything to be honest. --- If y

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-142697372 Hi @wido can you please add what you tested so the person to do the other review can focus on something else? Thanks! --- If your project is set up for it, you

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-142722939 @remibergsma, my LGTM was based on the code. I was not able to fully test it. I checked the diff and it was very small --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/875#issuecomment-142807954 :+1: merging.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: Fixed box location on vagrant files for d...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/875 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: 4.6 release

Thanks Boris(@borisroman) for fixing 3 blockers. We now have 7 blockers for the 4.6 release https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765 T Key P Summary Assignee Creator [image: Bug] CLOUDSTACK-8881

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142819336 An LGTM is given after going through the code and understanding what the code is accomplishing. The PR already has the test results and if i am not wrong an LGTM i

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142820449 @remibergsma Next time sure I will add some details .for this PR i have updated my comments . --- If your project is set up for it, you can reply to this e

Re: 4.6 release

(resending in plain text) Thanks Boris(@borisroman) for fixing 3 blockers. We now have 7 blockers for the 4.6 release https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765 Key Summary Assignee Creator CLOUDSTACK-8881[Blocker] PF , static nat , LB , egress rul

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/880 CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads The thread pool was hardcoded to use 8 threads, com.cloud.template.TemplateManagerImpl.configure(String, Map):

[Blocker] Egress rules are not configured in VR

Hi, Hopefully this will be the last Blocker on the VR functionality ? Can someone please pick this bug – ASAP ? https://issues.apache.org/jira/browse/CLOUDSTACK-8905 best, Raja

Re: [Blocker] Egress rules are not configured in VR

Hi Raja, I think CLOUDSTACK-8905, CLOUDSTACK-8881 and CLOUDSTACK-8795 are all related. Wilder, Can you comment? ~Rajani On 24-Sep-2015, at 11:52 am, Raja Pullela wrote: > Hi, > > > > Hopefully this will be the last Blocker on the VR functionality ? > > Can someone please pick this bug –