Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/921#discussion_r41705286
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -509,7 +509,7 @@ private String extract(Account caller, Long templateI
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/921
CLOUDSTACK-8944 Template download possible from new nfs secondary storage
before download is 100 % complete
Steps to test This
1. Add a new NFS storage
2. Start dowloading any pub
Github user svenvogel commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147118164
Thirst
I don't know how I change it to one commit in github.
Second
I don't know why shapeblue change this for their version. I asked agai
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-147118153
I've fixed most of the issues mentioned in this PR. In many VO classes, an
empty constructor was needed as tests were creating objects using that
signature. Logs an
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147117991
@remibergsma @bhaisaab Updated the description with testing requirements.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-147117406
@pdion891 Thanks! Build succeeded :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Hello,
Thanks Go.
I will get the localization strings from Transifex to a new PR (for all
languages) on master, but only in a couple of days, because I'm waiting
for others languages completion.
In all cases, I will made a PR just before the first RC of 4.6 (arround
24h before after Remi pin
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700263
--- Diff: usage/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java
---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700260
--- Diff:
usage/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java ---
@@ -0,0 +1,239 @@
+// Licensed to the Apache Software Foundation
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700252
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700255
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700250
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700240
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700244
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700228
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700225
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700218
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700213
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700207
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700206
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,397 @@
+//Licensed to the Apache Software Foundation (ASF) under
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700190
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700180
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700171
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700167
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700162
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/888#discussion_r41700161
--- Diff: packaging/centos7/cloud-management.service ---
@@ -15,22 +15,19 @@
# specific language governing permissions and limitations
# unde
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700137
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700157
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700118
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700109
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700101
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700092
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700095
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700087
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700082
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700075
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,444 @@
+//Licensed to the Apache Software Foundation (ASF)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700068
--- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java ---
@@ -373,6 +381,26 @@ protected void runInContextInternal() {
}
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700064
--- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java ---
@@ -373,6 +381,26 @@ protected void runInContextInternal() {
}
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700060
--- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java ---
@@ -373,6 +381,26 @@ protected void runInContextInternal() {
}
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700049
--- Diff: usage/src/com/cloud/usage/UsageManagerImpl.java ---
@@ -373,6 +381,26 @@ protected void runInContextInternal() {
}
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700048
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700045
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700042
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700035
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700030
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700021
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700015
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,304 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41700013
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java
---
@@ -0,0 +1,130 @@
+//Licensed to the Apache
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4163
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4173
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementItemResponse.java
---
@@ -0,0 +1,143 @@
+//Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4160
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699986
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699976
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699975
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699970
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699964
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699961
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699953
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699949
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,422 @@
+//Licensed to the Apach
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699930
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699928
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java
---
@@ -0,0 +1,153 @@
+//Licensed to the Apache So
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699853
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java
---
@@ -0,0 +1,102 @@
+//Licensed to the Apache Sof
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699848
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,143 @@
+//Licensed to the Apache Softwa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699851
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java
---
@@ -0,0 +1,95 @@
+//Licensed to the Apache Softwa
Hi Frank/Rohit,
Many thanks to you both for getting back to me, very much appreciated.
Running it without this:
Mvn.skip.tests=true
Appears to have fixed it for me... :-) Should have given it a try, I
thought having that in there would be helping to get past this issue.
So for anyone else who
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699842
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,143 @@
+//Licensed to the Apache Softwa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699840
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateListCmd.java
---
@@ -0,0 +1,60 @@
+//Licensed to the Apache
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699836
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699841
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java
---
@@ -0,0 +1,122 @@
+//Licensed to the Apa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699838
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699835
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,136 @@
+//Licensed to the Apache Software
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699833
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,136 @@
+//Licensed to the Apache Software
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699826
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/UserVmDetailVO.java ---
@@ -0,0 +1,83 @@
+//Licensed to the Apache Software Foundation (
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699824
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -0,0 +1,336 @@
+//Licensed to the Apache Software Foundati
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699816
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,172 @@
+//Licensed to the Apache Software Foundation (A
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699812
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaTariffVO.java ---
@@ -0,0 +1,162 @@
+//Licensed to the Apache Software Foundation (
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699807
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaEmailTemplatesVO.java
---
@@ -0,0 +1,109 @@
+//Licensed to the Apache Software Fou
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699802
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java ---
@@ -0,0 +1,117 @@
+//Licensed to the Apache Software Foundation
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699804
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java ---
@@ -0,0 +1,117 @@
+//Licensed to the Apache Software Foundation
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699797
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaBalanceVO.java ---
@@ -0,0 +1,127 @@
+//Licensed to the Apache Software Foundation
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-147113348
The jenkins job is created: build-systemvm64-GithubPullRequest and is
currently building this branch as tests. will see the result of the job#1 ...
---
If your pr
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699787
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/UserVmDetailsDaoImpl.java
---
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Fou
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699786
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java
---
@@ -0,0 +1,86 @@
+// Licensed to the Apache Software F
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699779
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,81 @@
+//Licensed to the Apache Software Foundati
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699781
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,81 @@
+//Licensed to the Apache Software Foundati
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699776
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,81 @@
+//Licensed to the Apache Software Foundati
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699770
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,81 @@
+//Licensed to the Apache Software Foundati
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699765
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,137 @@
+//Licensed to the Apache Software Founda
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699743
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,137 @@
+//Licensed to the Apache Software Founda
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699728
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,137 @@
+//Licensed to the Apache Software Founda
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699715
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,82 @@
+//Licensed to the Apache Softwar
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-147113023
I commented on #883 and will merge this in a few days. Let's hope
@SudharmaJain responds.
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-147112896
We won't merge this PR, we should merge #861 instead. Final call to
@SudharmaJain to confirm if PR #861 also fixes your issue. If I do not get a
response in the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-147112744
Once rebased we can run tests, otherwise we will find false positives.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699658
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,82 @@
+//Licensed to the Apache Softwar
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-147112657
@jayapalu Please rebase against current master, as in this branch the
default route is broken so it doesn't work. Also, there's an open question on
'rightsubnetw
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699647
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,88 @@
+//Licensed to the Apache Software Founda
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-147112559
It's not only remote access VPN, also site-to-site VPN.
When testing, one need to build a cloud with a systemvm template generated
from this branch. Curr
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41699609
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,214 @@
+//Licensed to the Apache Software Found
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147112390
LGTM, let's merge this after testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
1 - 100 of 148 matches
Mail list logo
