Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Rajani Karuturi
+1 (Binding) setup: RHEL 6.5 Management server, xen 6.5 Hypervisor, NFS storage, Advanced zone without sg (Manual testing) Rpm creation, install worked fine Was able to succesfully launch a vm, destroy etc. Upload template worked fine LDAP new as well existing integration worked fine RabbitMQ

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Daan Hoogland
+1 (binding) tentative, all my reasons to vote in the previous rc still stand and the improvements on centos7 packaging are fine. I wanted to do extra tests on upgrades hence tentative but it seems I wont make the deadline. On Fri, Nov 13, 2015 at 12:40 PM, Rajani Karuturi <

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156414832 @DaanHoogland That's already being done by @wilderrodrigues. Therefore this one is obsolete. --- If your project is set up for it, you can reply to this email

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Milamber
Hello, My vote : +1 (binding) Tests on Ubuntu 14.04 / KVM / Adv Network without SG Some tests (register template, create vm, create network, etc) with the ansible cloudstack module : ok Manual tests (register template, create vm, migration, start/stop vm, user mgt, snapshot volume, view

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-156360759 @ustcweizhou Yes, it does. See the patches I posted above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156368254 @ustcweizhou @dsclose Dude, this script is not used anymore! Please test it with maven, or manually, and you will see that it doesn't apply.

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156365263 I will test the upgrade, @DaanHoogland and LGTM afterwards. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156382390 @dsclose Scripts not in use since 4.6.0: ``` public static final String FIREWALL_EGRESS = "firewall_egress.sh"; public

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156379177 @dsclose, please have a look at: ``` ./cloud-systemvm/patches/debian/config/opt/cloud/bin/configure.py ``` Cheers, Wilder ---

[RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Remi Bergsma
Hi all, After 72 hours, the vote for CloudStack 4.6.0 [1] *passes* with 7 PMC + 2 non-PMC votes. +1 (PMC / binding) * Wilder * Nux (Lucian) * Rajani * Daan * Milamber (Bruno) * Wido * Remi +1 (non binding) * Raja * Boris 0 none -1 none A huge Thank You to everyone participating! :-) I will

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Nux!
Good job, everyone! :-) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Remi Bergsma" > To: dev@cloudstack.apache.org > Sent: Friday, 13 November, 2015 15:16:33 > Subject: [RESULT] [VOTE] Apache

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Daan Hoogland
thanks all, great. let's improve even further, after we had a great party to celebrate our selves. On Fri, Nov 13, 2015 at 4:16 PM, Remi Bergsma wrote: > Hi all, > > After 72 hours, the vote for CloudStack 4.6.0 [1] *passes* with 7 PMC + 2 > non-PMC votes. > > +1

RE: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Suresh Sadhu
+1(binding) Performed basic sanity using xenserver hypervisor as of now not found any major issue but noticed an exception while ms start initially Noticed below exception during upgrade times. If its known issue ,please ignore or else will raise a bug for tracking purpose. (main:null)

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Sebastien Goasguen
Congratulations to all, this could be our strongest release to date. Sorry I could not vote, I have been traveling. > On Nov 13, 2015, at 4:23 PM, Daan Hoogland wrote: > > thanks all, great. let's improve even further, after we had a great party > to celebrate our

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Remi Bergsma
Hi all, I've run the, by now, famous set of tests we've executed on the last ~100 or so PRs that we merged into master aka 4.6. It's all looking good. Apart from that, I worked with Wilder and we did many tests. Proud to be voting +1 (binding) as well! Regards, Remi Environment: KVM on

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread John Burwell
Wilder, For now, I am just concerned with averting the security nightmare of shipping a CVE regression. In terms of process, I don’t know how we proceed. Were the vote still open, a single binding -1 would abort the RC. We can either all decide by consensus not to pull back the RC or I can

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread John Burwell
All, I just noticed that the fix for CVE 2015-3251 [1] which shipped in 4.5.2 was not merged to master. Therefore, 4.6.0 contains a security regression. For this reason, I am -1 (binding) on RC2 due to the lack of this fix. There were also other CVE’s addressed in 4.5.2 which we need to

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Remi Bergsma
Hi John, Thanks for your concerns. I believe the patch for CVE 2015-3251 is included in 4.6 aka master. See commit ef44c7d. We should always merge forward, then your method would have worked. And that's exactly what we'll do from now on. Regards, Remi Sent from my iPhone > On 13 Nov

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread John Burwell
Rafeal, Excellent news. Since we found the fix in master, I withdraw my -1 and any concerns. Per the steps I listed, I simply checked that the commit was pulled forward. Since I wrote the patch, I didn’t actually apply the changes to 4.5 or master — the reviewer performed these actions. I

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Wilder Rodrigues
:( Sad to hear that just that late in the release process, John. Even worse to hear that it was already happening in 4.5.2 - released some months ago. But no worries! With our new release process, we can do things, in a proper way, quicker than before. The ACS 4.6.1 RC1 will be out within 2

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread John Burwell
Wilder, As a community, we cannot knowingly ship a release containing a CVE regression. The industry best practice in this circumstance would be pull the release and notify users not to use it. Luckily, the release hasn’t shipped yet, we can simply abort and create a new RC with CVE fix(es)

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Remi Bergsma
Thanks Rafael for confirming it too! I also tested it now and it really is not returning usernames and passwords. @John please confirm this is what you wanted to see included. On 13 Nov 2015, at 20:40, Rafael Weingärtner > wrote:

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Rafael Weingärtner
Hi John Burwell, Did you test the RC? Or you just checked if the commit was present? I have just checked and your changes that were introduced using the commit "3a48171bd8a70c6012afce32c7636afffc1d2f7d" to the tag 4.5.2 are indeed in master. The point here is that, when you do a rebase, a new

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread John Burwell
All, I realize when I reported my issue, I failed to state my methodology for determining the fix was not present in RC2. I performed the following steps: 1. git fetch origin 2. git checkout master 3. git rebase origin/master 4. git tag --contains 3a48171b Steps 2 and 3 shouldn’t be

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread John Burwell
All, I realize my vote is coming in after the vote has closed. However, I found that a fix [1] for at least one CVE that shipped in 4.5.2, CVE 2015-3251, is not present in 4.6.0. I just happened to notice because someone asked me within the last half hour about the availability of that fix.

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Wilder Rodrigues
Hi John, If that actually goes agains a community/industry standard, I will support you. It is not in my bucket list to be part of a group that released something that was already destined to fail. However, I would like to make 2 points in this whole thing: 1. it’s a big shame to see that it

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Remi Bergsma
Hi John, Great news, thanks for confirming. Regards, Remi > On 13 Nov 2015, at 20:53, John Burwell wrote: > > Rafeal, > > Excellent news. Since we found the fix in master, I withdraw my -1 and any > concerns. > > Per the steps I listed, I simply checked that

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Rafael Weingärtner
Cool ;) I agree with you that applying a patch using FF is easier to trace. On Fri, Nov 13, 2015 at 5:53 PM, John Burwell wrote: > Rafeal, > > Excellent news. Since we found the fix in master, I withdraw my -1 and > any concerns. > > Per the steps I listed, I simply

Re: [RESULT] [VOTE] Apache CloudStack 4.6.0

2015-11-13 Thread Wilder Rodrigues
Great news! Let’s now focus on 4.6.1/4.7.0 Cheers, Wilder On 13 Nov 2015, at 20:57, Rafael Weingärtner > wrote: Cool ;) I agree with you that applying a patch using FF is easier to trace. On Fri, Nov 13, 2015 at 5:53 PM, John

Preparing 4.6.0 for announce

2015-11-13 Thread Remi Bergsma
Hi all, Now that we have a 4.6.0 GA release, we need to do some extra work to get it to our users. Let’s share the load and make it happen fast! What’s on my list: * Release Notes for 4.6.0 (let’s list the cool new stuff) * Jira needs to be up2date (was everything tagged with

Re: Preparing 4.6.0 for announce

2015-11-13 Thread Boris Schrijver
Hi, Once branched and tagged, I'll create the packages and upload them to cloudstack.apt-get.eu! Already busy on 4.7!! --  Met vriendelijke groet / Kind regards, Boris Schrijver PCextreme B.V. http://www.pcextreme.nl/contact Tel direct: +31 6 33784542 > On November 13, 2015 at 9:44 PM Remi

Still no direct commit on master

2015-11-13 Thread Sebastien Goasguen
Folks just a quick note, While 4.6.0 is out (almost) we should not direct commit on master. Master is now our release branch fir 4.7. Let's be patient a bit more to finish the 4.6 items remi mentioned and we will have a clear process for 4.7. -Sebastien

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-156384240 @dsclose Thanks for your PR, it shows support! As the script is not in use anymore, would you close the PR? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9050 Virtual router should onl...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1063#issuecomment-15648 @borisroman @dsclose how about changing it to a pr that removes the script ;) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread wenwenxiong
GitHub user wenwenxiong opened a pull request: https://github.com/apache/cloudstack/pull/1065 update for comment in cancelMaintin on start VR change comment //if the instance is of type ssvm, call the ssvm manager to //if the instance is of type domain router vm, call

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156388025 Harmless commit, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156394882 LGTM :+1: Improving comments, always :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] Shared Networks on Nicira NVP Plugin

2015-11-13 Thread Rajani Karuturi
Hi Nicolas, Right now master is frozen and RC2 is in progress (welcome to test and got :)). Once RC2 is voted, 4.6 branch would be created and master would become 4.7 At this point, schema-460to470.sql will also be created on master. Your changes should go in this file. 4.6.* will only be a bug

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156400401 Not sure if we need this comment but the old version was a harmfull misqguidance, the new one is correct. LGTM --- If your project is set up for it, you can

Build failed in Jenkins: build-4.6-api-docs #3

2015-11-13 Thread jenkins
See -- [...truncated 28 lines...] [INFO] Apache CloudStack Utils [INFO] Apache CloudStack Framework [INFO] Apache CloudStack Framework - Event Notification [INFO] Apache CloudStack Framework -

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156434491 Before you run the Xen tests, I think you should apply the changes in "XenServerGuru.java" and remove the method "EndPoint selectHypervisorHost(Scope

Build failed in Jenkins: build-4.6-api-docs #1

2015-11-13 Thread jenkins
See -- [...truncated 34 lines...] [INFO] Apache CloudStack Utils [INFO] Apache CloudStack Framework [INFO] Apache CloudStack Framework - Event Notification [INFO] Apache CloudStack Framework -

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156430873 did the sbp regression tests on this: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156434822 @rafaelweingartner too late :cry: is running, next spin. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Wido den Hollander
+1 (binding) from me. I've verified that 4.6.0 works and I tested ACS 4.6.0 with Boris as he described below. Our tests were all with Basic Networking and KVM. Wido On 13-11-15 14:10, Boris Schrijver wrote: > Hi all, > > Hereby my vote for ACS 4.6.0 based on branch 4.6.0-RC20151110T1545. > >

Build failed in Jenkins: build-4.6-api-docs #2

2015-11-13 Thread jenkins
See -- [...truncated 29 lines...] [INFO] Apache CloudStack Utils [INFO] Apache CloudStack Framework [INFO] Apache CloudStack Framework - Event Notification [INFO] Apache CloudStack Framework -

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Boris Schrijver
Hi all, Hereby my vote for ACS 4.6.0 based on branch 4.6.0-RC20151110T1545. +1 Based on testing with: - KVM Ubuntu 14.04.3 - Basic networking - Ceph (Primary storage) - S3 (Secondary storage) - NFS (Secondary storage / Staging store) Tested the following: - Template Uploading /

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-13 Thread Daan Hoogland
The upgrade test I am planning is not going to happen today. The db is to big so I'll test in the weekend and report the unlikely event of problems after the release to be fixed in 4.6.1: +1 (binding) On Fri, Nov 13, 2015 at 2:46 PM, Wido den Hollander wrote: > +1 (binding)