[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159430073 this problem, was solved when this PR was merged. The problem we were talking about was the build of f5 plugin project that is not building with Java

[GitHub] cloudstack pull request: CLOUDSTACK-9065: fix bug when creating pa...

2015-11-24 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1114 CLOUDSTACK-9065: fix bug when creating packaging with noredist flag You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request:

2015-11-24 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14604799 https://github.com/apache/cloudstack/pull/1114 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek reopened a pull request: https://github.com/apache/cloudstack/pull/1113 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… Fix for https://issues.apache.org/jira/browse/CLOUDSTACK-9064 The users should be able to create

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1115 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… …ared Networks in same Vlan ID, same Physical Network and same network, just with a different IP ranges.

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1116 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… https://issues.apache.org/jira/browse/CLOUDSTACK-9064 CLOUDSTACK-9064: The users should be able to

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1117 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… https://issues.apache.org/jira/browse/CLOUDSTACK-9064 CLOUDSTACK-9064: The users should be

[GitHub] cloudstack pull request: CLOUDSTACK-9081 Migration of vm across cl...

2015-11-24 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1118 CLOUDSTACK-9081 Migration of vm across clusters fails in clustered MS setup Storage motion of vm across clusters/xenserver-pools fails in a clustered management server setup. In xen

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1117#issuecomment-159501118 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1116#issuecomment-159501130 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-159501138 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159519154 manually tested it with rabbitmq integration Here are the events before and after the fix Before: {"eventDateTime":"2015-11-25 11:39:27

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159429530 This build problem happens to me on Java 1.7. Isn't this just a syntax error? The annotation markers are missing. --- If your project is set up for it, you

[GitHub] cloudstack pull request:

2015-11-24 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14604451 Found the offending bit. It is missing double quotes surrounding that variable in line 105. --- If your project is

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159418662 Interesting, so it looks like a Java problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9051: update nic IP address of...

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1086#issuecomment-159391187 tests performed [1086.network.results.txt](https://github.com/apache/cloudstack/files/43165/1086.network.results.txt)

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159402363 1.8.0_05 works, 1.8.0_25 doesn't --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1113#issuecomment-159411260 What about 4.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request:

2015-11-24 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14601119 Since this change, ``./package.sh -p noredist -d centos63`` is not working on centos6 OS with following error:

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159386959 i have some lying around: ``` 1.8.0_25, x86_64: "Java SE 8" /Library/Java/JavaVirtualMachines/jdk1.8.0_25.jdk/Contents/Home

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159526803 @remibergsma as a project we don't ship official repository or packages yet, until that happens we need to state that the packages/link we've provided are 3rd

[GitHub] cloudstack-www pull request: add swiss txt to cloudstack users

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-www/pull/19#issuecomment-159521672 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-www pull request: add swiss txt to cloudstack users

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-www/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-24 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack-www/pull/20 downloads: State packages on downloads page are 3rd party - Adds statement that packages on the download page are not official releases similar to Cassandra's page

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159526854 @remibergsma If we state that packages are 3rd party it gives sense (imho) to inform who makes those packages. the regular ones from apt-get.eu could be

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159526424 @bhaisaab what do you want to achieve? What's different with the shapeblue packages? Why mentioning company names? It's highly confusing if you ask me,

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-24 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1112#issuecomment-159370086 @remibergsma, yep, let me test this, we would also like to have this into 4.6.1 if we can test it on time. Thanks. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159341450 Example with the fix: ``` { eventDateTime=2015-11-24 16:57:58 +, status=Completed, description=Successfully completed

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159318964 Hi @ProjectMoon Thanks for taking this up. If possible, can you put in a sample event before and after the fix? I will test this tomorrow with rabbitmq ---

Re: New Defects reported by Coverity Scan for cloudstack

2015-11-24 Thread Rajani Karuturi
I don’t know if it can be done (especially with free coverity integration, I don’t think its possible.) ~ Rajani -Original Message- From: Erik Weber Reply-To: "dev@cloudstack.apache.org" Date: Tuesday, 24 November 2015 at 12:48 PM

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

2015-11-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-159338806 @nitin-maharana , I do not have CS 4.6 or 4.5.1 here to test. However, I have compared those files from CS 4.3.2 with files from 4.5.1 and 4.6.0. I could

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

2015-11-24 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-159346524 I tested in chrome and firefox. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159379578 @DaanHoogland , I have just checked with @cristofolini, I also had the problem you described here. I did not see that before because I had compiled

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-159190185 @pedro-martins checkstyle is complaining about trailing spaces in CitrixResourceBaseTest --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1113 CLOUDSTACK-9064: The users should be able to create multiple Guest Sh… Fix for https://issues.apache.org/jira/browse/CLOUDSTACK-9064 The users should be able to create

Re: New Defects reported by Coverity Scan for cloudstack

2015-11-24 Thread Daan Hoogland
I think we all need to triage this. Not just PR authors. On Tue, Nov 24, 2015 at 7:46 AM, Rajani Karuturi wrote: > *98* New defects. > All the latest merged PR authors, can you please go through the list of > new defects? > > ~ Rajani > > > > > > > > > -Original

Build failed in Jenkins: build-master-slowbuild #2706

2015-11-24 Thread jenkins
See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159230031 It is missing a review and LGTM, (with proper motivation) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159219262 Currently unable to build the branch due to https://github.com/apache/cloudstack/pull/1110. What's the status of that request being merged in? --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9051: update nic IP address of...

2015-11-24 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1086#issuecomment-159211074 Just added a new commit in this PR. CLOUDSTACK-9051: reprogram network as a part of vm nic ip update Review and testing are welcome! --- If your

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159277838 The commit has been updated with a unit test. I also rebased this branch to latest master since my apparent accidental review of #1110 got the syntax error fix

Build failed in Jenkins: build-master-slowbuild #2707

2015-11-24 Thread jenkins
See -- [...truncated 25566 lines...] [INFO] Done FindBugs Analysis [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-f5 <<< [INFO] [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

2015-11-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1113#issuecomment-159234061 LGTM (yet to test it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Fix event UUIDS missing on event bus

2015-11-24 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/#issuecomment-159231415 For now I will cherry-pick that commit and use it locally to build my tests. It will not become part of this pull request of course. --- If your project is

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159267770 Guys, why didn't we get 2x LGTM on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: release managers wanted

2015-11-24 Thread Rafael Weingärtner
Out of curiosity, What are the responsabilities of a release manager? On Tue, Nov 24, 2015 at 11:06 AM, Daan Hoogland wrote: > People, > > We now have two release manager who both live in UTC+1. It would be nice to > have some one from UTC-11 or there abouts and even

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

release managers wanted

2015-11-24 Thread Daan Hoogland
People, We now have two release manager who both live in UTC+1. It would be nice to have some one from UTC-11 or there abouts and even better to have two extra people, one from between UTC+5 and +10, and one from UTC-6 to UTC-11. ​I think we can all see why,​ -- Daan

[GitHub] cloudstack pull request: PR1102 regression fix; half the annotatio...

2015-11-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1110#issuecomment-159268349 My bad @remibergsma I counted @ProjectMoon as lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: release managers wanted

2015-11-24 Thread Daan Hoogland
shortly: check if PRs have enough review and merge to the right branch and forward. long story: [1], [2] and [3] [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Releases [2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure [3]