AW: AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, system unbootable!

2015-12-10 Thread Jochim, Ingo
Nux, I worked with the SUSE VMDP drivers (downloaded from SUSE) on Xen quite a lot in the past. Upgrading the drivers was always a nightmare and we ran into bluescreens very often. Since version 2 they also come with Virtio. I don't know if those are the same drivers which come with Windows. An

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163867518 Might only be me, but I think it is a bit assumptious to assume that the internal network is routable for everyone. To clarify I am mostly worried about the conso

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163867468 @remibergsma @DaanHoogland This PR Looks Okay To Me, no good, but okay. Please merge it and I will improve the code and add Marvin tests to cover i

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47328907 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163865718 @terbolous In the example above, I show a cloud that uses RFC1918 space only. That works fine, as these routes are more specific than the generic ones I add.

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163865197 @wilderrodrigues @ustcweizhou I can confirm that tests fails for me too, even when I rebased before testing it. ```

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163864347 FYI, run integration tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163862541 What about users who solely use rfc1918 address space? That could easily be the case for internal or enterprise users. I am in doubt about this change, as I fe

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-163862343 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1216#discussion_r47322960 --- Diff: setup/db/db/schema-452to460.sql --- @@ -420,3 +420,7 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2015-12-10 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-163835153 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-10 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r47320168 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +35,5 @@ conn L2TP-PSK # ---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2015-12-10 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-163834017 @nitin-maharana The current way was to move the service offering to a similar or a more flexible one in terms of deployment. While this change will make the new s

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

2015-12-10 Thread maneesha-p
Github user maneesha-p commented on the pull request: https://github.com/apache/cloudstack/pull/1159#issuecomment-163831485 @jburwell @DaanHoogland Raised a new PR(1216) with changes suggested . @bhaisaab As master is in 4.7 we dont need the change in every upgrade path before 4.6

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

2015-12-10 Thread maneesha-p
GitHub user maneesha-p opened a pull request: https://github.com/apache/cloudstack/pull/1216 CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0 Added suitable db entries in tables hypervisor_capabilities and guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excludi

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

2015-12-10 Thread maneesha-p
Github user maneesha-p closed the pull request at: https://github.com/apache/cloudstack/pull/1159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, system unbootable!

2015-12-10 Thread Nux!
Ingo, Yes, I use the same. But the drivers "SUSE Storage/Net" in Windows Optional updates override them. Verified on 2008r2 and 2012r2. Luckily the damage is limited as they are in the Optional channel, not sure how many people chose to install those alongside the Important ones, but hopefully

Build failed in Jenkins: build-master-slowbuild #2776

2015-12-10 Thread jenkins
See -- [...truncated 28699 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Better way to do development for SSVM agent code

2015-12-10 Thread Syed Mushtaq
Thanks for your responses guys, I ended up copying the jar that was generated and restarting the SSVM. One thing to note though is that the SSVM has a default DROP policy so I needed to change it before I could scp my jar. -Syed On Wed, Dec 9, 2015 at 11:08 PM, Anshul Gangwar wrote: > You can u

Re: [DISCUSS] KVM HA with IPMI Fencing

2015-12-10 Thread John Burwell
Ronald and Ilya, Reviewing this FS, I feel that it is a very good idea. However, I think it needs the following refinements to ensure the HA fencing/recovery operations do not overwhelm the management server and that the capabilities could be used to provide HA for non-KVM resources: * Sepa

Build failed in Jenkins: build-master-slowbuild #2775

2015-12-10 Thread jenkins
See Changes: [atrbgithub] Sorting of security groups [bharat.kumar] CLOUDSTACK-8852 Database shows that management server is UP when it is [Daan Hoogland] CLOUDSTACK-9047 use 'State's only with context there are more t

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread igor.wiese
Really nice ideia. I got your point. I will test. Thanks for the suggestion:) Sent from Samsung tablet Mensagem original De : Patrick Dube Data: 10/12/2015 18:26 (GMT-03:00) Para: dev@cloudstack.apache.org Assunto: Re: Feedback of my Phd work in Cloudstack Project T

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Patrick Dube
The history around the new file isn't the file itself, but in which directory/package it would be in. Cheers, On Thu, Dec 10, 2015 at 3:01 PM, Igor Wiese wrote: > Hi Patrick > > The problem with new files is the absence of history to build the > prediction models. I need at least some commits (

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Igor Wiese
Hi Patrick The problem with new files is the absence of history to build the prediction models. I need at least some commits (10 commits for example). Yes, the link between files is what we are predicting. We can predict changes involving commands.properties, XML files in general, .txt files, or a

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Patrick Dube
Are you handling new files as well, or the links between sets of files (or packages)? As an example, if a user creates a new API cmd, then he will update the "commands.properties" file. Another example, if a VO file is updated, then there will be a db migration file added as well. Cool work, On Th

Jenkins build is still unstable: build-systemvm64-master #691

2015-12-10 Thread jenkins
See

[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1215#issuecomment-163723768 Ping @remibergsma @DaanHoogland @miguelaferreira @michaelandersen @bhaisaab * Environment - 1 KVM host on CentOS 7.1 - Management Server

[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...

2015-12-10 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1215 CLOUDSTACK-9138 - Adds multiple providers back to VPC implementation - It is need and already allowed/used in the current implementation. For example, the Default [redundant] VPC off

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

2015-12-10 Thread remibergsma
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1214 Setup routes for RFC 1918 ip space Setup general route for RFC 1918 space, as otherwise it will be sent to the public gateway and likely to be dropped (internet providers do not route ip s

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-10 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761 Assuming everything else is ready e.g. service controllers, transport zone, management server, STT tunnels in-between then to create L2 gateway (page 89 of the User

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1213#issuecomment-163683468 It seems this is more complex than it seemed. Since we've to put in a 'physical network id' (which is obviously owned by ROOT domain, this does not work yet.

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

2015-12-10 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1213#issuecomment-163674707 @remibergsma Can domain admin1 delete gateway created by domain admin2? If the existing code is properly handling these scenarios then fine. --- If your projec

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1204#issuecomment-163660061 FYI: my tests also succeeded. ``` [root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_88R1S8/results.txt Test to verify access to lo

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

2015-12-10 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1213 CLOUDSTACK-9137 Allow domain admin to manage private gw To create a private gateway you need a root admin account. This does not make sense, as you can do a lot more with such a powerful ac

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Igor Wiese
Hi Sebastien. We used only 141 commits because we needed data from the issues. As my assumption is related to the contextual information from Issues and Social aspects, we need to aggregate commits and Issues. First, I collected the issues from JIRA and then i tryed to aggregate the commits that

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1208#issuecomment-163624151 LGTM ![screen shot 2015-12-10 at 14 50 08](https://cloud.githubusercontent.com/assets/1630096/11716922/61d60aa8-9f4d-11e5-9ac0-d442a74cd55c.png) --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2015-12-10 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1212 CLOUDSTACK-9136: remove ssh keypairs along with removing account We also allow ROOT Admin to remove remained ssh keypairs of removed account You can merge this pull request into a Git repos

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread sebgoa
On Dec 10, 2015, at 12:31 AM, Igor Wiese wrote: > Hi, Cloudstack Community. > > My name is Igor Wiese, phd Student from Brazil. In my research, I am > investigating two important questions: What makes two files change > together? Can we predict when they are going to co-change again? > > I've

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

2015-12-10 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1211 [UI] bug fix: Delete added ACL lists is not available for Domain Admin and normal users Only the owner or domain admin/admin can access the page (vpc->Network ACL Lists), they are also abl

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Igor Wiese
Hi Vadim! In fact, we are recomending files to change together without the developers/newcomer need to know about the code (structural dependencies for example), or need to make debugging to find with files could change together in a task. We found many situations that files are changed together

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/1210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

2015-12-10 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1210 [UI] bug fix: Delete added ACL lists is not available for Domain Admin and normal users Only the owner or domain admin/admin can access the page (vpc->Network ACL Lists), they are also abl

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

2015-12-10 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1209 CLOUDSTACK-9134: set device_id as the first device_id not in use instead of nic count when we restart vpc tiers, the old nics will be removed, and create a new nic. however, the d

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163604337 That's odd! :( Same test was executed by @remibergsma and I this week and everything went fine. But if that was rebased, the test should no

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Vadim Kimlaychuk
Do I understand correctly that purpose of this work is to find tightly coupled classes automatically in order to inverse dependency later on? Vadim. On 2015-12-10 01:31, Igor Wiese wrote: Hi, Cloudstack Community. My name is Igor Wiese, phd Student from Brazil. In my research, I am investiga

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Igor Wiese
Hi Anshul. Thanks for your answer First of all, sorry about the webpage. I checked and now it is working http://flosscoach.com/index.php/17-cochanges/67-cloudstack. Let me know if you still having problem to access the webpage. About your questions: 1) What do you mean by "correctly predict 60%

AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, system unbootable!

2015-12-10 Thread Jochim, Ingo
Hi, you can use the virtio drivers from the Fedora Project. I didn't have problems on W2k12 and W2k12R2. https://fedoraproject.org/wiki/Windows_Virtio_Drivers Regards, Ingo -Ursprüngliche Nachricht- Von: Nux! [mailto:n...@li.nux.ro] Gesendet: Mittwoch, 9. Dezember 2015 10:42 An: dev C

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1185#issuecomment-163590671 LGTM, I hit the unit test failure today with Jenkins while building master branch (4.7) and @nlivens 's fix worked for me :) cc @DaanHoogland @remibergsma pl do

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1187#issuecomment-163590636 LGTM, I hit the unit test failure today with Jenkins while building master branch (4.7) and @nlivens 's fix worked for me :) cc @DaanHoogland @remibergsma pl do

[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations

2015-12-10 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1194#issuecomment-163586496 @GabrielBrascher Noted, I think I need to submit translation via Transfix. I am working on it. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-163586170 @nvazquez I suggested to add the config to the test itself, but I gave it some more thought and I agree with you that the test should just assume the config

[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations

2015-12-10 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1194#issuecomment-163584797 I think it would be better to change “Quota” by “cota”. Both are correct, but Brazilians are used with “cota”. It seems that the Jenkins

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1201#issuecomment-163583068 ... slightly late, LGTM (did code review) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163579922 I reran the test and it failed again: ``` Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false |

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1201#issuecomment-163579051 Had a look at the code and trusting @remibergsma his test work: LGTM --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-163578421 Thanks for testing and adding the screenshots, @SudharmaJain! Waiting for you reply on the unit test question I asked. --- If your project is set u

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1196#discussion_r47212450 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java --- @@ -236,4 +236,15 @@ public static Str

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1201#issuecomment-163578041 Integration tests are also OK: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/t

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1208#issuecomment-163574449 I like angry fruit salads, how about a grey icon that colours all up on hovering? serious? ok, i'm fine with both. --- If your project is set up for

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1208#issuecomment-163570500 I don't think it is. :D Would be nice to see a review from a colour-blind person though. :D LGTM Cheers, Wilder --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-163570286 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1208#issuecomment-163568069 @wilderrodrigues @remibergsma @DaanHoogland LGTM :+1: Better styling this way. No unit or integration tests run. Though in this case I don't thi

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1208 ui/quota: Make the quota UI plugin icon gray Makes the quota ui plugin icon gray, based on comment at: https://github.com/apache/cloudstack/pull/768#issuecomment-163364606 You can merge th

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1208#issuecomment-163566614 cc @remibergsma @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Implement Quota service

2015-12-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-163565254 @milamberspace okay, sending a new PR for that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169 LGTM, both users and admins can login with/without this plugin enabled. User login with plugin disabled: ![screen shot 2015-12-10 at 10 52 03](https

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163560328 LGTM Tested the actual feature: Created a VPC: ![screen shot 2015-12-10 at 10 49 05](https://cloud.githubusercontent.com/assets/1630096/11712205/b9f

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163557163 I know this issue. You can get it working with @Autowire and @Quialifier annotations. If BaseCmd does the same, then it should be fine. Cheers,

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163554256 @wilderrodrigues I used VirtualNetworkApplianceService at first, and met an issue like: "spring autowiring with unique beans: Spring expected single

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163554166 @ustcweizhou, @wilderrodrigues is right to ask for a retest anyway, will do --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2015-12-10 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-163550095 @DaanHoogland : No, it needn't not be an exact match but the new one should be a superset of the current one. According to your scenario, as the new one suppo

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47204914 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean res

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47204055 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-10 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-163542539 @DaanHoogland I did this change because UI does not allow migration between different versions of hyper-visors of but sometimes user wants to do migration f

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163542373 @harikrishna-patnala This is reverted because of the lack of test report, not the logic of your code. If you feel it must go in anyway please rebase the code a

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1204#issuecomment-163542058 Thanks, @michaelandersen! Ping @remibergsma @DaanHoogland - this one is ready to be merged. Cheers, Wilder --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163541774 Hi @ustcweizhou, The content is a bit misleading because you used the ```VpcVirtualNetworkApplianceService``` instead of ```VirtualNetworkAppliance

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163541483 @wilderrodrigues yes, it is rebased with latest master. going through the files changed in this PR, I think the failure is not related to it. This PR doe

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163540517 One of the tests (network_results) says: Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163540200 @wilderrodrigues thanks for review! This PR apply on redundant networks, not redundant VR for VPC. I tested it several times. you may get a result from my

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1204#issuecomment-163539898 Ran tests on Xenserver 6.2: Results: ``` Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_

Deleted projects cannot be billed

2015-12-10 Thread Jochim, Ingo
Hi all, does anybody knows how deletion of a project works and why records get deleted or replace by NULL? A much more detailed description of the issue got posted by Norbert here: https://issues.apache.org/jira/browse/CLOUDSTACK-9096 Thanks and regards, Ingo Teaser: Deleted projects cannot

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@Wilder, forgot to mention, either we should also add template for LXC or skip the test for LXC. On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N wrote: > @wilder, I am ok with it. You can take it over. > One comment, is ostype "Other PV (64-bit)" valid for other hypervisors > otherthan Xenserver? And

Re: Feedback of my Phd work in Cloudstack Project

2015-12-10 Thread Anshul Gangwar
Before giving feedback I have some questions 1) What do you mean by "correctly predict 60% commits”? 2) What are the feature measures you are giving as input here to system (prediction model)? 3) What kind of output you are expecting? Web page link you have provided is not working. > On 10-Dec-

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2015-12-10 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-163539799 @DaanHoogland Sure will try. Will take some time as I have to go through the documentation first. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1204#issuecomment-163539777 Thanks, @borisroman! @michaelandersen, have you already tested this against Xen? By the way, I did both already. Cheers, Wilder

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@wilder, I am ok with it. You can take it over. One comment, is ostype "Other PV (64-bit)" valid for other hypervisors otherthan Xenserver? And vmware template format should be in .ova The one you have mentioned in the Services class won't work. On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues wr

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47202713 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean res

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-163539499 Hi @ustcweizhou, I made a couple of comments in your code that would need addressing. Could you have a look at that? In addition, would you

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163539316 Did the regression tests: [1197.network.results.txt](https://github.com/apache/cloudstack/files/57825/1197.network.results.txt) [1197.vpc.results.txt](

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

2015-12-10 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1197#issuecomment-163538722 You are right @ustcweizhou . My branch was not up to date. Applied the patch on latest master. - Able to see vpcname and vpcid in listRouters response -

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47201935 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

2015-12-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163537454 @wilderrodrigues it was merged before the freeze so I didn't revert it as RM. But you are right about the not being tested. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1198#discussion_r47201591 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2558,6 +2575,62 @@ public boolean

  1   2   >