[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-178167084 LGTM based on the code. any test for this available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1386#issuecomment-178165074 makes sense looks good, was it put in production without test? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-178190394 Hi @rafaelweingartner Thanks for your comments! I've been working following your indications, however I didn't create any test case. I wanted to ask

Build failed in Jenkins: build-master-slowbuild #3130

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Display hostname the VPC router runs on

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1384#issuecomment-178165509 convenient cos(mat)ic change: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1389#issuecomment-178209325 @borisroman systemvm/patches/debian/config/opt/cloud/bin/cs_iptables_save.py needs a license. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-7836: Make s2s VPN CIDR list l...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1388#issuecomment-178211407 @remibergsma a better solution in the make? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Unable Create/CleanUp Virual Router After upgraded to ACS 4.6.2

Hi All, I have tested ACS 4.7.1 with 4.6 template and getting same below “flask” error in Virtual Router, due to this error we are unable to create new networks/clean up existing Virtual Router. File “/opt/cloud/bin/baremetal-vr.py”, line 28, in from flask import Flask ImportError: No

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/672#discussion_r51486290 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -4251,6 +4257,34 @@ public void

Build failed in Jenkins: build-master-slowbuild #3131

See -- [...truncated 28685 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-178267025 Hi @nvazquez, I see that you have created a spring bean as I said. However, I noticed some things that may not be needed or that seemed out of place

Re: upgrading 4.5.2 -> 4.6.0 virtualrouter upgrade timeout

Hi Remi, Is this patched merged into 4.7.1 or 4.8.0, which was recently released? I am planning to do the upgrade and wanted to double check. Thanks Andrei - Original Message - > From: "Remi Bergsma" > To: "dev" > Sent: Tuesday,

Re: [RESULT][VOTE] Apache CloudStack 4.8.0

Hi Could you please point to the release notes document for both 4.8.0 and 4.7.1? I couldn't find anything on the cloudstack.org. Many thanks Andrei - Original Message - > From: "Remi Bergsma" > To: "dev" > Sent: Tuesday, 26

Build failed in Jenkins: build-master-slowbuild #3126

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-177962933 I would prefer just leaving one pull request here, but with two commits. Each commit would have the file changes + unit tests for the SSVM and CPVM,

[GitHub] cloudstack pull request: CLOUDSTACK-7836: Make s2s VPN CIDR list l...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Display hostname the VPC router runs on

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1384#issuecomment-178064538 LGTM :+1: Based on screenshots and code-review Already running in PROD at SBP. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1386#issuecomment-178064345 LGTM :+1: Already running in PROD at SBP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-178064659 LGTM :+1: Based on codereview Already running in PROD at SBP. --- If your project is set up for it, you can reply to this email and have your reply

Build failed in Jenkins: build-master-slowbuild #3127

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: [PROPOSAL] Freeze everything until we get CI

Sure Remi, Once I am done consolidating the scripts i will put them in a separate repo on github. Thanks, Bharat. > On 30-Jan-2016, at 5:14 PM, Remi Bergsma wrote: > > Please put it in a separate repo. There’s way too much stuff in the > cloudstack repo

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-177942109 @rodrigo93 I think that a JIRA ticket wouldn't help much, considering that JIRA is for report issues (not PRs). I think that the point here is to analyze

[GitHub] cloudstack pull request: Display hostname the VPC router runs on

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/1379#issuecomment-178400682 I will add the suggested changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-178346694 @rafaelweingartner thanks for your reply! I'm familiar to Spring, I've worked with it, I know how it works but I wouldn't say I know it in depth. If you

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1389#issuecomment-178000474 Integration test results: ``` Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS === ok

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1389 Restore iptables at once using iptables-restore instead of calling ip tables numerous times You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

Github user rodrigo93 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/672#discussion_r51428218 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -4251,6 +4257,34 @@ public void

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-178002003 @GabrielBrascher @ProjectMoon, You are right. I thought I saw a some section in Jira for minor improvements, but I was wrong. Besides that, the code and work

Build failed in Jenkins: build-master-slowbuild #3128

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-8830 CLONE - VM snapshot fails...

Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-178042092 Hi @maneesha-p I see you did the extraction, but could you also write the method javadoc along with it? As simple as it is, it can help people

Build failed in Jenkins: build-master-slowbuild #3129

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check