Re: [GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

@remibergsma, I did not notice that there were two commits in it. I only looked at the modified content of the file. Thanks for reverting it. On Fri, Feb 12, 2016 at 1:00 AM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/

Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit

Is it okay to merge this PR or we need to wait for two LGTMs, since original PR 667 already has two LGTMs ? On Fri, Feb 12, 2016 at 1:59 PM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537 >

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

GitHub user pritisarap12 reopened a pull request: https://github.com/apache/cloudstack/pull/1031 CLOUDSTACK-9026: Modifying testpath for adding missing parameter Adding service_offering creation in testpath_storage_migration.py testpath which is missing right now You can merge thi

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Github user pritisarap12 closed the pull request at: https://github.com/apache/cloudstack/pull/1031 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-184053093 @rafaelweingartner : Its already present in our code. It translates the dictionary keys. --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r52853711 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java --- @@ -0,0 +1,46 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-184008194 Hi Daan, Since you are cleaning things up, what about changing those “pokemons” try-catches for specific ones? --- If your project is set up fo

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1390#issuecomment-184007356 @nitin-maharana, Your changes LGTM. I just noticed that function “_l”, is that something we have created? --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9280: Allow system VM volumes ...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1406#discussion_r52851113 --- Diff: engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java --- @@ -350,6 +359,24 @@ public EndPoint select

[GitHub] cloudstack-www pull request: 4.8.0 with APIs, change copyright dat...

GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-www/pull/24 4.8.0 with APIs, change copyright date to 2016 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdion891/cloudstack-www 4.8.0 Alternativ

[GitHub] cloudstack pull request: [4.5] vmware: improve support for disk co...

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1366#issuecomment-183970215 @bhaisaab Did you get to see the output of the jenkins build? Was it just another false positive? I don't see anything in the code that could cause it to fail.

[GitHub] cloudstack pull request: Fix unique mac address per rVPC router

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1413#issuecomment-183966121 During the tests we found a couple of issues: 1. Default route was being set to private gateway interface after the master router went through a cra

[GitHub] cloudstack pull request: CLOUDSTACK-8959: Option to attach the con...

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/938#issuecomment-183965957 Ping @kansal. Could you take a look at @pedro-martins's and @GabrielBrascher's suggestions? They seem worth it to me... Also, if you do, please go ahead and reb

[GitHub] cloudstack-docs-rn pull request: 4.8

GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/28 4.8 4.8.0 release-notes The about.md is fairly empty, so if someone can add stuff it would help. I'm not aware of a lot of changes in 4.8.0 Thanks. You can merge this

Re: [PROPOSAL] - Reference Guide for CloudStack configuration parameters

Yes, I agree. This is great! From: Paul Angus Sent: Sunday, February 14, 2016 1:08 PM To: us...@cloudstack.apache.org; dev@cloudstack.apache.org Subject: RE: [PROPOSAL] - Reference Guide for CloudStack configuration parameters Awesome initiative. I expect tha

RE: [PROPOSAL] - Reference Guide for CloudStack configuration parameters

Awesome initiative. I expect that we’ll be able to cull some unused or repeated parameters as well. [ShapeBlue] Paul Angus VP Technology , ShapeBlue d: +44 203 617 0528 | s: +44 203 603 0540 | m: +44 7711 418784 e: paul.an...@shape

[GitHub] cloudstack pull request: CLOUDSTACK-8829 : Consecutive cold migrat...

Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/797#discussion_r52846855 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1776,19 +1773,26 @@ private void orchestrateStorageMi

[GitHub] cloudstack pull request: CLOUDSTACK-8897: baremetal:addHost:make h...

Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/874#discussion_r52846753 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -680,6 +680,13 @@ public Discoverer getMatchingDiscover(final Hyperv

Build failed in Jenkins: build-master-noredist #4830

See -- [...truncated 895 lines...] at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) 2016-02-14 18:30:31,073 DEBUG [utils.script.Script] (main:) Executing:

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1410#discussion_r52846110 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java --- @@ -207,10 +211,14 @@ public Vol

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user rodrigo93 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r52845493 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,6 +195,12 @@ private voi

[GitHub] cloudstack pull request: CLOUDSTACK-8609. [VMware] VM is not acces...

Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/556#issuecomment-183909796 Could someone put this PR to test again? If it fails, it could be closed since the author seems to be inactive on github since September of the last year and the P