Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-187054205
LGTM, based on the code and the presented output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1421#discussion_r53593074
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
def __moveFile(self, origP
I ran into that as well, a while ago. IMNSHO the VM record should be
deleted after the state expunging, so a state of expunged would never make
sense. Deabatable of course.
On Mon, Feb 22, 2016 at 7:03 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
> Hi,
>
> Is anyone able to confirm t
Hi,
Is anyone able to confirm that when you delete and expunge a VM in 4.9 that
the state finishes with "Expunging" instead of "Expunged".
I don't think it really "harms" much as the removed column is populated
(so, for example, the GUI doesn't show these VMs), but it does seem a bit
odd (and fro
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1252#discussion_r53579947
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1472,6 +1473,12 @@ private void advanceStop(final VMInstance
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/797#discussion_r53579417
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1776,19 +1773,26 @@ private void orchestrateStorageMigration(
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1422
Improve ordering of fields of VPC router detail tab
The field we use most are now on the top:
- name
- state
- hypervisor
- link local ip
- redundant state
The o
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/556#discussion_r53570662
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -880,6 +880,38 @@ else if (prop.getName().startsWith("value[
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/876#discussion_r53570532
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2378,6 +2378,23 @@ public boolean maintenanceFailed(final long hostI
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-186875522
Hi @kansal, can you make a test with this change? Try issuing an request
with more than 2048 characters to see if everything still works fine then.
-
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-186823236
This looks like a sensible fix. Code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1203#issuecomment-186820477
@ghxandsky Would you please go ahead and rebase this PR against the current
master? Thanks!
---
If your project is set up for it, you can reply to this email
12 matches
Mail list logo
