Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1496#discussion_r60004052
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r60003773
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -677,6 +679,17 @@ public boolean deleteAccount(AccountVO account, long
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/1499
Undetected bug correct and refactor of the class NfsSecondaryStorageResource
Im in process of rewriting the unit test for this class' mount method.
Before I can do that, the
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-211149034
@abhinandanprateek How about extracting lines 70-82 in `KVMInvestigator` to
their own method? I think it would be nice to get a test case going for that
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-211140525
@ProjectMoon May I suggest extracting lines 778-784 in `AccountManagerImpl`
to a separate method? That would allow you to write your comment in a proper
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-26802
@DaanHoogland That's a good suggestion. We will discuss on the optimal
location in the plugin's project directory, and incorporate them in the next PR.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099345
@swill LGTM based on testing and code walkthrough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099195
@prashanthvarma maybe you can incorporate it in the project dir for the
plugin somehow. It seems to me to be the best place for it. maybe accompanied
with a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-211094168
@jayapalu The strongswan service is now started automatically on all
systemvms (including console proxy and seconday storage vm). I think we should
start it
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211092880
@DaanHoogland you are right, that is the main motive :). Let me know, if
you want me to publish it elsewhere as well for easier user access.
Thank
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211060040
thanks @prashanthvarma , mostly usefull for users of your sdn solution.
Hopefully some of them will test ;)
---
If your project is set up for it, you can
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211044426
@DaanHoogland Sure, here is an example Nuage VSP SDN plugin specific Marvin
tests config file contents:
{
"zones": [
{
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211038147
@prashanthvarma can you publish nuage_ant.cfg?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211032986
did the tests and again two failures, replay succeeded
14 matches
Mail list logo
