Congratulations Simon!!
Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com
-Original Message-
From: Ahmad Emneina [mailto:aemne...@gmail.com]
Sent: Wednesday, May 04, 2016 8:11 AM
To: dev@cloudstack.apache.org
Subj
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216751340
I am getting this error during deploy DB "Specified key was too long; max
key length is 767 bytes". I have provided another inline comment in the code
which is
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r61992331
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,26 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude propert
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216749200
@jburwell The API is transactional and you're right if more than one admin
decide to change the order, client side final order checking will be needed.
This is also t
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216743316
@jburwell I actually like this better because it tells me specifically what
the particular failure is.
assert validationresult is not None, "
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216742996
@jburwell How's about this?
assert validationresult is not None and isinstance(validationresult, list)
and len(validationresult) == 3,\
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216735024
@mike-tutkowski I apologize for being behind on my review queue. I will
move #1403 up on my list and get to it as quickly as I can.
---
If your project is set up
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216734107
@rhtyd I am trying to understand how reordering should work. User creates
a role with rules ordered as follows:
1. Rule A
1. Rule B
1. Rule C
Congratulations Simon!
On Thu, Apr 28, 2016 at 12:23 AM, Erik Weber wrote:
> The Project Management Committee (PMC) for Apache CloudStack
> has asked Simon Weller to become a committer and we are pleased to
> announce that they have accepted.
>
>
> Being a committer allows many contributors to c
Congrats Rafael!
On Thu, Apr 28, 2016 at 3:59 AM, Daan Hoogland
wrote:
> People,
>
> The PMC has ask Rafael to join them to oversee the project and he has
> gracefully accepted. Please join me in congratulating Rafael and wish him
> wisdom in his new task.
>
> on behalve of the PMC,
> --
> Daa
Congratulations Rafael!
Nicolas
2016-05-03 19:20 GMT-03:00 John Burwell :
> Congrats Rafael.
>
> >
> Regards,
>
> John Burwell
>
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
> On May 2, 2016, at 9:21 AM, Rohit Yadav wrote:
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61979134
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-216709951
Tested this in a hardware 4.8 lab: I was able to migrate VXLAN enabled VMs
between hosts as expected.
LGTM
---
If your project is set up for it, you can
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61974541
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyper
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61974533
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyper
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61974484
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyper
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61974295
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyper
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61974235
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyper
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216696449
Thanks @jburwell While you're in a code-review mood, maybe you take a look
at #1403 again as that one is pretty high value to a bunch of people. :)
---
If y
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216684125
@mike-tutkowski the ``wait_until`` version looks very nice ;) A definite
improvement in the reliability of the test case.
I added a couple of minor commen
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61967545
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61967452
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61967329
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61967231
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1529#discussion_r61967100
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2459,13 +2460,31 @@ def create(cls, apiclient, cluster, services,
zoneid=None, podid=None, hyperviso
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-216683077
@rhtyd rebased and squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Congrats Rafael.
>
Regards,
John Burwell
john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 2, 2016, at 9:21 AM, Rohit Yadav wrote:
>
> Congrats Rafael.
>
> Regards,
> Rohit Yadav
>
>
> Regards,
>
> Rohit Yadav
>
> rohit.
Congrats, Simon.
>
Regards,
John Burwell
john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 2, 2016, at 9:21 AM, Rohit Yadav wrote:
>
> Congrats Simon.
>
> Regards,
> Rohit Yadav
>
>
> Regards,
>
> Rohit Yadav
>
> rohit.y
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216678631
@jburwell Thanks for pointing out that utility method. I have updated the
code.
---
If your project is set up for it, you can reply to this email and have y
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-216650029
All checks passed. @rhtyd, @wido or @GabrielBrascher can you review and
give second OK.
---
If your project is set up for it, you can reply to this email and hav
Hi Rohit, thanks ;)
I will answer your questions in line.
I did not look at the code but I'm curious on how you're powering off
hosts, I think with my out-of-band management PR you can use the oobm
subsystem to perform power management operations for IPMI 2.0 enabled hosts.
A: when we developed
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216646244
@remibergsma you want to consider cribbing
[``wait_until``](https://github.com/apache/cloudstack/blob/12d8e53dd54d83242b3dabf2151249ab7963d5a8/tools/marvin/marvin/l
Github user ymolinet commented on the pull request:
https://github.com/apache/cloudstack/pull/1040#issuecomment-216646082
Tomcat6 is End Of Life : https://tomcat.apache.org/tomcat-60-eol.html
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/1040#issuecomment-216645498
I know you can get it to work with ease on CentOS6 and 7..
Cant really comment on Debian as i don't have any instances.
---
If your project is set up f
Github user ymolinet commented on the pull request:
https://github.com/apache/cloudstack/pull/1040#issuecomment-216634399
I'm just trying to use with Tomcat7 ( cloudstack-setup-management --tomcat7)
>
Starting to configure CloudStack Management Server:
Configure Firewa
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216632803
@mike-tutkowski you may want to consider refactoring to use the
[``wait_until``
function](https://github.com/apache/cloudstack/blob/12d8e53dd54d83242b3dabf2151249a
Yes, I just realized that and am testing it. I have it installed and I am
doing my first set of tests with the latest code now...
Thanks...
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On T
Hi Will,
For me it is solved by installing two packages; did you pull this pr? We fixed
it in cosmic and ported it to the cloudstack config as well.
https://github.com/MissionCriticalCloud/bubble-toolkit/pull/123/files
Regards, Remi
Sent from my iPhone
> On 03 May 2016, at 19:25, Will Stev
Linas
Congrats on first java project ever!
CloudStack supports custom pluggable APIs that you dont have to bake
into code base - unless you feel many other users will benefit from it.
We do it all the time and i'm sure many others orgs do the same...
Search the web for CloudStack custom API, the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216603725
I'll play with pyenv, jenv tomorrow and keep you posted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
It looks like we now have a dependency on 'python-cffi', but the following
does not help.
$ sudo yum install python-cffi
Ideas?
On Tue, May 3, 2016 at 1:18 PM, Will Stevens
wrote:
> I have been running into this the last couple days and I am trying to
> understand what I need to change in my C
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216603249
@swill I'm fine with all changes, I've ran a final set of tests as well.
@jburwell please share any outstanding issue that should be fixed,
@borisstoyanov and I are L
Hi Anil,
I assume you have followed this guide?
http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.5/hypervisor/xenserver.html
Also, there is a section for FC:
"Primary Storage Setup for XenServer"
Hope this helps
Kind Regards,
Timothy Lothering
Timothy Lothering
Solution
I have been running into this the last couple days and I am trying to
understand what I need to change in my CI environment.
My CI environment has not changed and everything that went into master is
stuff I have run through my CI, so I am trying to figure out what happened
here.
It is like we got
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216597727
That is a nice suggestion.
I have done that, what do you think now?
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user/
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-216585629
rebased with apache/4.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216582523
Can you force push again to see if we can get Jenkins green. The errors in
Jenkins are not ones I am used to seeing, but Travis is green, so I suspect
that a force p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216581383
Perfect, this one is queued up to be merged... Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216578573
My CI does not have the capability of testing this, so even if I ran CI it
would not cover this. I tend to agree that his is fine as is.
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216576816
Yes, this one is ready. I just need to verify master is in a good state
before I continue merging into master. We had a merge conflict yesterday which
we resolved,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216576269
I was having problems with this in my CI, but I am still trying to
determine if it is my environment or not. I will try again once I get master
tested (since we fixe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-216575327
@nitt10prashant no problem. Thanks for the work. I just want to remind
you that the 4.9 release will be frozen on May 16th, so if you want to get it
into that relea
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216574386
All checks have been passed after squashing. @swill did you CI run pass? If
so can you merge it please?
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216573789
Since both Jenkins and Travis are green, I agree that we don't need to do
any further testing on this one.
I will give this a LGTM, can I get one more?
---
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216572547
No worries @GabrielBrascher, I realized after I CCed you that you really
just fixed a typo. :) Thanks for the feedback...
---
If your project is set up for it, you
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216571886
@swill I haven't worked much on that file (I had fixed a typo in the name
of the "ROOT_DISK_CONTROLLER" variable).
At the first look I would agree w
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216569013
@rafaelweingartner just checked that the first commit indeed is by someone
else, though I think it would be still valid to note in your commit (the 2nd
one) the JIRA
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216564080
@rhtyd @DaanHoogland @swill I don't think any tests are necessary for this
PR. Would y'all mind reviewing for LGTM?
---
If your project is set up for it, you can
Nice feature :)
I did not look at the code but I'm curious on how you're powering off hosts, I
think with my out-of-band management PR you can use the oobm subsystem to
perform power management operations for IPMI 2.0 enabled hosts.
Also curious how you implemented the heuristics and wrote test
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216560467
Thank you @sanju1010, I will get this in for testing again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216560940
Thank you sir...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216559351
Great, thanks for the additional details @borisstoyanov. ð Once Rohit
and John are in agreement on the final details, I think we are ready to merge
this one. T
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1525#issuecomment-21603
A few more details.
The full run took: `55h 59m 30s`
The following tests took longer than an hour to complete:
```
1h 01m 46s => /tmp/MarvinLo
Github user borisstoyanov commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216550819
Thanks @swill as Rohit mentioned we did migration testing of 4.8.1 to 4.9
without enabling the feature, to confirm users are able to continue using CS
without
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216541819
@mike-tutkowski, yes I think the change is expected. I just want some more
eyes on this since it did not go through the usual CI and code review channels
because we
Hi All,
Please some body guide me to add new host to existing cluster in CloudStack.
Host: XenServer 6.2
CloudPlatform version: 4.5
My existing cluster is configured with Fiber channel storage.
Now, i need to add new xen host to existing cluster.
I was able to add new host to existing cluster
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216524904
@remibergsma, down from 15 to 2 seconds is pretty big in terms of computing
time. Is there an internal retry in CS might this script give a timeout? I
think this is
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216524259
@swill , added check to see if m has any match object and fail if not.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517829
Well, the open version of it - PR 1483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517631
I'm about to start testing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216516629
@swill This has 2 x LGTM. Simple change and probably doesn't require any
additional CI IMO.
This is Ready to Merge
---
If your project is set up for it, you
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively you
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216515896
@rhtyd you are right, I rebased against master instead of 4.7, sorry, will
close and reopen against master
---
If your project is set up for it, you can reply
Hello.
I implemented a new API call for myself, which returns the VNC url for a VM.
Currently i'm using some classes from the consoleproxy servlet package as well
as copied some code over to my own package/class (specifically the encryption
stuff)
Now i have questions regarding this way of doing
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216513556
According to the explanation of @remibergsma, and the code changes : LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-216513459
@swill thanks for your comment and time , it seems the code is not in the
master for which i have written the test script , it will take another 2 weeks
to g
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-216511879
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r61870927
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseVi
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216508737
@rhtyd, I understand and I agree with your concerns. The point here is that
I am not fragmenting commits, I just cherry picked a commit that was reverted
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216508518
@swill 4 x LGTM + CI from Daan.
This is Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-216507445
@ustcweizhou Could you rebase this to resolve the conflicts? I'll pull this
in for testing once you've had a chance to do that. Thanks!
---
If your project is se
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216489209
@swill all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216488843
@jburwell I did not get the question, is it for oobm? dynamic-checker has
no update counter in any of the api or schema. If this was for oobm, the update
counter is u
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216487485
@swill I think you mentioned the wrong Boris :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216486309
@rhtyd for optimistic locking, is the update counter returned on the get
APIs and required on the update APIs?
---
If your project is set up for it, you can reply
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216476619
Fixed issues with the added multi-zone support to "nuageTestCase.py" and
"test_nuage_vpc_network_multizone" testcase in "test_nuage_vpc_network.py":
Test ba
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216472391
@jburwell I've fixed based on your review, please re-review and advise
further improvements, thanks
Integration test after last PR review changes:
==
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-216466217
rebased with master and moved the db changes to schema481to490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61850479
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apache S
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61850255
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61850243
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61849798
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61849729
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216462358
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61848360
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61847657
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61847561
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apache S
1 - 100 of 124 matches
Mail list logo
