[GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1418#issuecomment-217089000 @rhtyd Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-217082822 @serg38 LGTM. Verified on my test env. @swill This is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply

Re: [ANNOUNCE] New committer: Simon Weller

Congrats Simon! Thanks, Jayapal > On 04-May-2016, at 7:19 pm, Suresh Sadhu wrote: > > Congrats Simon. > > -Original Message- > From: Ahmad Emneina [mailto:aemne...@gmail.com] > Sent: Wednesday, May 4, 2016 8:11 AM > To: dev@cloudstack.apache.org > Subject: Re: [ANNOUNCE] New committer:

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217018726 hi @miguelaferreira Yeah, after working on this PR last September, I got side tracked with other, higher-priority items and haven't gotten back to it until re

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-217011034 Thanks for this! In the future I'd like to see this done through the Qemu Guest Agent, but that is still waiting for something, see: #985 --- If your project is set u

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1533#discussion_r62118856 --- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py --- @@ -0,0 +1,80 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-217010122 Done @rhtyd ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Re: RM after 4.9

Will, you are taking RM work yet another step in to our future, good work. I of course hope the next RM will make us almost forget your achievements as you are making us work to remember your predecessors (building on their work of course). On Wed, May 4, 2016 at 4:18 PM, Will Stevens wrote: > H

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-216987677 Hi @mike-tutkowski It has indeed been a long time :) None the less, it's great that you took the time time write that integration test. I think i

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1497#discussion_r62102918 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216970419 @swill Looks like we are good to go with this review. Thanks for the reviews @rhtyd and @DaanHoogland! --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-216970070 @miguelaferreira I know it's been a while since you and I were talking about this. I attached a Marvin test for this, but I don't have a way to run it yet wit

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-216968844 Thanks @jburwell and @shwetaag for the reviews! @swill We are good to go from a review standpoint here. I will update the commit SHA and re-push this

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1497#discussion_r62095734 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216967912 @rhtyd I just finished QA of changes on MySQL 5.1, 5.5, 5.6 and 5.7. No issues. 64byte index on ssh_keypairs table is created fine on all DB platforms. @koushik-

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216957591 @koushik-das, You are right. Those variables that were introduced are all primitives; if they have not being loaded, their default value will be zero.

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-216945403 @swill conflicts fixed. Push with force done, ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216910739 Thanks @nvazquez did you test this against mysql 5.1, 5.6 and 5.7? The Travis run will check against MySQL-Server 5.5 --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216908315 For the issue reported by Travis, I force it to install ipmitool version 1.8.16; but looks like even that version causes the same failure (some times). --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216907666 @swill the issue is actually with ipmitool binary itself https://bugzilla.redhat.com/show_bug.cgi?id=1286035 where it may sometimes fail due to errors in ipmitool's

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216906241 Thanks @swill for verifying --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216901961 @koushik-das @swill @serg38 I modified index length for ssh_keypairs table --- If your project is set up for it, you can reply to this email and have your reply ap

Build failed in Jenkins: build-master-jdk18 #511

See Changes: [abhinandan.prateek] Quota: consolidated lockable account check to a method. Added unit tests [Daan Hoogland] CLOUDSTACK-9336 surround the execution of baremetal-vr.py with condition [slair] Cloudstack Usage Brea

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216896697 @serg38, I just saw your communication with @koushik-das. I will let him verify the fix you are working on and we will go from there. Thanks... --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216893678 The one failure above is unrelated to this fix and pops up periodically in my environment. Above is a passing CI result... --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216893394 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 4h 28m 09s ``` **Summary of the p

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216893135 Just as an update for everyone. CI ran against master with the merge conflict fix and everything went smoothly, so we are all set. Thanks for the help on this @rhty

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-216889967 This PR currently has merge conflicts, but #1515 is next in line, so you may want to wait till it is merged before you fix these conflicts. --- If your project is

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-216889762 Please rebase this PR to fix the merge conflicts. Thanks... #1527 has been merged into 4.7 and then forward merged to 4.8 and then master. Once the merge conflicts

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1455#issuecomment-216887066 @sanju1010 can you address @DaanHoogland's concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-216885592 @wido can you rebase for me? We apparently have merge conflicts now. Thanks... --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216884501 BTW, travis is showing exceptions in OOBM now, so you probably want to review those... --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216884149 Please force push to kick off travis again. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-216883803 @mike-tutkowski I agree with you about the use of assertions. A very nice improvement in the quality of the test. LGTM based on code review --- If your

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: RM after 4.9

Haha, ya I am hearing crickets... :) We are slowly working towards systems which will remove a lot of the day to day work for the RM and will spread that work over the community better. Things like managing the status of the PRs and what is needed for them to move forward and testing to make sure

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216876560 Thanks @koushik-das. Looks like before 5.6 Mysql auto restricted length of InnoDB indexes to 255 characters without giving trouble if index length is not specified.

RE: [ANNOUNCE] New committer: Simon Weller

Congrats Simon. -Original Message- From: Ahmad Emneina [mailto:aemne...@gmail.com] Sent: Wednesday, May 4, 2016 8:11 AM To: dev@cloudstack.apache.org Subject: Re: [ANNOUNCE] New committer: Simon Weller Congratulations Simon! On Thu, Apr 28, 2016 at 12:23 AM, Erik Weber wrote: > The Pr

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-216865360 SystemVM templates with quagga etc if anyone wants to test --https://packages.shapeblue.com/systemvmtemplate/custom/ospf/ --- If your project is set up for it, you c

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

GitHub user sverrirab opened a pull request: https://github.com/apache/cloudstack/pull/1533 Convert patchviasocket to python (removes perl dependency for KVM agent) As requested here: https://github.com/apache/cloudstack/pull/1495 No scripts are using perl so that install re

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216853436 @rhtyd @NuxRo sound like a regession. I will look at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Vmdk findbugs

GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1530 Vmdk findbugs replacing #1351 You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs Alternatively y

[GitHub] cloudstack pull request: Vmdk findbugs

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

GitHub user marcaurele opened a pull request: https://github.com/apache/cloudstack/pull/1532 DAO: Hit the cache for entity flagged as removed too I came along this part of the code and I don't see any reason why the cache should not be used when fetching with the "removed" ones. It

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216851115 We performed end-to-end testing of this PR by building packages today [1] and found an issue with maven (not related to this PR) where users get sent to error.jsp due

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1531 systemvmtemplate: fix build and upgrade to debian 7.10 iso - Bumps base debian iso to version 7.10 - Upgrade ruby version to 2.3.0 (latest/stable) - Fix Gemfile - Update README

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-216847988 LGTM. Verified that a configuration entry is added with default 8 as pool size. Increased the default threadpool size, restarted MS and verified that when multip

RE: [ANNOUNCE] Rafael Weingartner joining the PMC

Congrats Rafael Kind Regards Giles Regards, Giles Sirett giles.sir...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: 28 April 2016 12:01 To: dev Subject: [

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216812806 Ah, indeed. It should be running the test against a Security Group zone, not Adv. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1444#discussion_r62006414 --- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java --- @@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView vi

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216792938 Looks like a cleanup/env issue, can you push -f again @DaanHoogland In Travis, scroll down at the end -- see the table which test failed (exception/failed et

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216785465 LGTM. Verified before and after fix and things are working as expected. The integration test works fine and properly cleans up stuff on completion. --- If you

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216781424 Any idea why Travis fails that 1 job? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...

Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: RM after 4.9

Hi Will, Staying awfully silent in this thread. > Op 3 mei 2016 om 0:43 schreef Will Stevens : > > > Hello All, > As you all know, I am the RM for the 4.9 release. Unfortunately, this is > not a position I will be able to maintain for the long term, so we should > start this discussion sooner

RE: how to go about codebase quality when colisions occur?

Yes, i used the tutorial. Someone from irc gave me the link to it. And yes, I implemented my api call using that. But that's when the question poped up in regards of dependent code. After this email, Dahn from irc suggested i create a code restructure proposal (to move vnc related libs to some

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-216763100 @jburwell, I think that would be a nice solution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If