[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63136000 --- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java --- @@ -260,4 +268,41 @@ public boolean remove(Long id) {

Update docs using reStructuredText - Need help

Hi, I want to update information in the Downloading vhd-util section of the Installation Guide (version 4.6). Would like to know how I can access the Install Guide files that I can edit using reStructuredText. I have installed Sphinx and can access Online reStructuredText editor

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218957622 I was able to build the packages on Ubuntu 16.04: cloudstack-agent_4.9.0-SNAPSHOT~xenial_all.deb cloudstack-common_4.9.0-SNAPSHOT~xenial_all.deb

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63133626 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +600,205 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63132551 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +600,205 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63132440 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63132242 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63132177 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63132007 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63131882 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -55,65 +68,98 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63131753 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +608,225 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Fix test failures on CI

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1544#issuecomment-218948374 Closing this one, moving the commit to the Nio cpu fix PR #1543 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Fix test failures on CI

Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63131338 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +448,153 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63131303 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63131310 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218947733 @kiwiflyer Thanks you for testing this so quickly and sharing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218947527 Thanks for the fix @rhtyd and for testing this @kiwiflyer. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218947359 @rhtyd This patch seems to have fixed the cpu issue. I've got this running on a hardware lab right now. We'll also install this on a larger lab tomorrow and

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-218945981 @swill screenshots to prove it does not break the existing; in the screenshot we see pagesize passed as -1 (i.e lists all). The pagesize change is only in zone and

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r63130081 --- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java --- @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218945625 @swill I've tried to fix them here: https://github.com/apache/cloudstack/pull/1544 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Fix test failures on CI

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1544 CLOUDSTACK-9299: Fix test failures on CI - Fixes oobm integration test to skip if known ipmitool bug is hit - Fixes ProcessTest unit test case to use sleep /cc @swill @kiwiflyer

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218945458 @wido thanks, much needed. I had a quick look, I could not find a cloudstack-management.sysconfig. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218944171 @swill thanks, will have a look at it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218943901 PR that aims to fix CPU issue - https://github.com/apache/cloudstack/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1543#discussion_r63129136 --- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java --- @@ -615,7 +615,10 @@ public static boolean doHandshake(final SocketChannel socketChannel,

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1543 CLOUDSTACK-9348: Make NioConnectio loop less aggressive - Reverts ea2286 that introduced a wakeup on each connection loop run. - In SSL handshake code removes delegated tasks to be run in

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218943044 @rhtyd Sounds good. Thanks for taking a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218942524 @kiwiflyer thanks, I think I've found two issues -- I'll tag you on another PR, please test that in your lab and share if that fixes your CPU issue. /cc @swill let's

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r63127043 --- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java --- @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63112842 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +608,225 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63112811 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +600,205 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63112751 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +600,205 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63112646 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +608,225 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63111964 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +448,153 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63111842 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63111740 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63111670 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63111572 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +258,207 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63110910 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@ public

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63110957 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@ public

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63110833 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -55,65 +68,98 @@ import

Build failed in Jenkins: build-master-noredist #4863

See Changes: [hogni] writeIfNotHere requires an array of strings, not a string [rafaelweingartner] Removed classes with no reference [meaux] CLOUDSTACK-9334: Support jenv and pyenv to manage Java and Python

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63108616 --- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java --- @@ -260,4 +268,41 @@ public boolean remove(Long id) {

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user ntavares closed the pull request at: https://github.com/apache/cloudstack/pull/1535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user ntavares commented on the pull request: https://github.com/apache/cloudstack/pull/1535#issuecomment-218901584 @DaanHoogland closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: ACS PRs Status - 2016/05/12

Thank you sir. I totally missed that one. I will get it merged later tonight. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, May 12, 2016 at 5:10 PM, Daan Hoogland

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

Github user olivierlemasle commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-218893171 Thanks @swill ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1536#issuecomment-218887457 @swill, given that @ustcweizhou gave his ok on #1535, this one can be merged. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1535#issuecomment-218887203 @ntavares can you close this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: ACS PRs Status - 2016/05/12

just resurfaced from testing 1536. I'm missing it in your list. Get sleep and maybe a weekend now and again! On Thu, May 12, 2016 at 11:02 PM, Will Stevens wrote: > ACS PRs > >- 1537 - master (ready, pending Jenkins) >- 1514 - 4.7 (pending Jenkins) >- 1520

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1536#issuecomment-218885699 CI RESULTS: initial fails due to environmental issues all tests passed after rerun:

ACS PRs Status - 2016/05/12

ACS PRs - 1537 - master (ready, pending Jenkins) - 1514 - 4.7 (pending Jenkins) - 1520 - master (ready, pending Jenkins) - 1482 - 4.7 (pending Jenkins & LGTM) - 1403 - master (pending LGTM, run CI again to be sure) - 1532 - master (ready, pending LGTM and Jenkins) - 956 -

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Remove classes with no references

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Disable NioTest

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218879096 I have forced pushed this because it is blocking other PRs that are only pending Jenkins and Travis and since we are so close to freeze date, I don't want stuff to

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218879748 Sorry to do this to you again @marcaurele. Can you rebase and force push again. I have disabled the test in `master` that was blocking this in Jenkins because we

[GitHub] cloudstack pull request: Disable NioTest

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218875130 Jenkins for #1537 is also being held up by these tests: ``` --- T E S T S

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1542 CLOUDSTACK-9379: Support nested virtualization at VM level on VMware Hypervisor ## Introduction [JIRA TICKET](https://issues.apache.org/jira/browse/CLOUDSTACK-9379) It is

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218874072 @DaanHoogland I had to put the "Void" return types back. It is used for AOP and won't compile with "void" for those two methods. --- If your project is set

[GitHub] cloudstack pull request: CPU socket count reporting correction

GitHub user NuxRo reopened a pull request: https://github.com/apache/cloudstack/pull/1520 CPU socket count reporting correction CPU socket count reporting correction From https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16 You can merge this pull

[GitHub] cloudstack pull request: CPU socket count reporting correction

Github user NuxRo closed the pull request at: https://github.com/apache/cloudstack/pull/1520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1269#issuecomment-218869828 Can I get some code review on this? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-218869670 This PR currently have merge conflicts. Can you rebase please? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218869697 I don't see anything wrong with this PR. However, the point made by @rodrigo93 is interesting. At the class "VolumeOrchestrator" (lines 1068-1081

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218869567 @DaanHoogland I think I addressed all your concerns. I plan to rebuild this locally, then push to GitHub in a bit. --- If your project is set up for it,

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218869277 @DaanHoogland I agree we have some strange patterns in the codebase. For this feature, I simply followed those patterns when I saw them because I wasn't

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63086591 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void

[GitHub] cloudstack pull request: Disable NioTest

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1538#issuecomment-218868153 @rhtyd Can you re-push now that we have fixed the issue that is failing in travis? Thx... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63086019 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -347,38 +395,87 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-218867747 Can we get screenshots or something to verify this works? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63082964 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +473,123 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218865225 LGTM with one extra comment: This is adding a much wanted feature and not worsening the code base we have but some bad patterns are being maintained that we

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63083577 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +473,123 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63083834 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -289,7 +291,7 @@ public boolean

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63083633 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -289,7 +291,7 @@ public

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63083245 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63083184 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@

Travis failure

Anyone know why this would be failing? +-+-+-+ | test_01_scale_vm| marvin.cloudstackExcept | 0.051 | | | ion.CloudstackAPIExcept | | | | ion |

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218861696 I see the following error which is causing the PR #1297 to fail. Suggestions? ```

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63082184 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63082200 --- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java --- @@ -260,4 +268,41 @@ public boolean remove(Long id) {

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63080850 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-218858373 yep, sounds good... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63079362 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63078617 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-218854911 @jburwell Thanks, I'll look into that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218852007 @kiwiflyer I'll see if I can get it out completely ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218851513 @mike-tutkowski I don't mind ignoring most of the remaining comments I made except for - the ones about returning null. - the renamed exception, the

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218850613 @DaanHoogland @ustcweizhou I noticed that there is four 'if' with the condition `(io != null) && (io > 0)` at the _KVMStorageProcessor_ class (lines 1009 -

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-218848727 tag:needsreview --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-218848337 so @swill, I may find time to review later. In the meanwhile let's use tag:needsreview makes sense? --- If your project is set up for it,

[GitHub] cloudstack pull request: writeIfNotHere requires an array of strin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1456#issuecomment-218847217 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218846952 This failed during compiling: ``` [INFO] Apache CloudStack Plugin - Hypervisor KVM . FAILURE [11.036s] ``` Here is the error ```

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-218844975 I think this one is ready... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   3   >