[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread ustcweizhou
GitHub user ustcweizhou reopened a pull request: https://github.com/apache/cloudstack/pull/1410 CLOUDSTACK-6928: fix issue disk I/O throttling not applied Disk IO throttling (for KVM) is not applied in the merge of 4.2. Tests passed: (1) start vm (2) attach volume

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread ustcweizhou
Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/1410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
CI is running. Thx... :) On May 20, 2016 11:11 PM, "Tutkowski, Mike" wrote: Hi, Please feel free to review the following PR that should address this matter by reverting certain variable names back the way they were prior to PR #816: https://github.com/apache/cloudstack/pull/1556 Thanks! Mike

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Hi, Please feel free to review the following PR that should address this matter by reverting certain variable names back the way they were prior to PR #816: https://github.com/apache/cloudstack/pull/1556 Thanks! Mike From: Will Stevens Sent: Friday, May

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

2016-05-20 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1556 Hyper-V communication broken by change in variable names Change variable names back to fix communication with Hyper-V Agent: https://issues.apache.org/jira/browse/CLOUDSTACK-9383

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-220755087 the sweet sweet color green... 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don't

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
Yes, the mirror site would be on github or apache.org Step 6 in the install guide would have instructions like: a. Install System VM Templates: b. Installing other templates cloud-install-tmplt > enter OS (linux only) > Ubuntu 16.04 Installing... Or, step (b) could generate a cloudmonk

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220745686 Have a nice weekend. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220742798 I might find the time but it is long since I worked with xen. Also I must find new joy for this hobby. So no promises --- If your project is set up for it, yo

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Unless that PR was not already accounted for in a grandfathered exception. On May 20, 2016 7:26 PM, "Daan Hoogland" wrote: > In the mutiny PR I had to change the names that I put final in front so > that implies line level. > > send by tablet, no warranties in existence > On 21 May 2016 01:19, "W

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220741573 OK. I don't really have the bandwidth to troubleshoot this (unfortunately). This is one of the many PRs that are on the bubble which I am trying to figure out what t

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
In the mutiny PR I had to change the names that I put final in front so that implies line level. send by tablet, no warranties in existence On 21 May 2016 01:19, "Will Stevens" wrote: > Does it take offense at a file level or a line of code level? If it is at > the file level, then it makes sens

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220740982 Yes, I'm just not sure it is Travis or the xen plug-in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Does it take offense at a file level or a line of code level? If it is at the file level, then it makes sense because people follow the standard presented in the file and that file is already accounted for in the checker threshold. On May 20, 2016 7:06 PM, "Daan Hoogland" wrote: Concerning the _s

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220739661 @DaanHoogland you think the issue that travis is having is a genuine issue, is that what you mean? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1464#issuecomment-220739360 @sanju1010 I don't know what to do with this one. I don't have any verification that this PR works, so I am not sure what information I am supposed to be going on to

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220739198 @swill I think it is genuine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread Daan Hoogland
Yes, Will. And it is xen specific. send by tablet, no warranties in existence On 21 May 2016 00:59, "swill" wrote: > Github user swill commented on the pull request: > > https://github.com/apache/cloudstack/pull/1297#issuecomment-220737825 > > This is one of the only PRs I have seen con

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-220739003 @syed please close and reopen or repush. we are close to freeze and I want to get some of these PRs in... --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-220738801 @syed: Getting close to freeze, please repush to see if we can get jenkins green. Thx... --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-220738889 @ustcweizhou ^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
Concerning the _s, checkstyle takes offence of those in changed lines of code. So i am wondering how people can get new _s in. send by tablet, no warranties in existence On 21 May 2016 00:55, "Will Stevens" wrote: > I can confirm we currently have Zero HyperV tests in CI. Once we have more > pe

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-220738747 Getting close to freeze, please repush to see if we can get travis green. Thx... --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220738431 I would like to get this one re-pushed or closed and reopened so we can kick the CI again to see if we can get things green. I am getting very close to freezing and

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-220738113 @remibergsma can you give me a status on this PR. I know you reverted it because of missing licenses. Should I be trying to wait for this one to get back in for 4.9

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220737825 This is one of the only PRs I have seen consistently failing on the scale vm test. I am not sure what to think about that. Can you rebase and force push or close an

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
I can confirm we currently have Zero HyperV tests in CI. Once we have more people contributing to CI we can try to get better coverage, but right now I am pretty much just testing on KVM. I know the accelerite guys are testing on Xen. Once I freeze, I will try to do testing of master in as many

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
You are right Will. I am sorry for the link, here it is: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions On Fri, May 20, 2016 at 7:52 PM, Will Stevens wrote: > Can you add your link for [1], I think you forgot to add the link. I was > not aware of a coding standard for

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Can you add your link for [1], I think you forgot to add the link. I was not aware of a coding standard for this project. I know there has been debated a lot recently about the preceding `_` on some variables. Historically it was done that way, but recently a lot of people have taken offense to i

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220735448 @rhtyd uggg... The first two builds on master after merging this back in have both resulted in the `addHost` error. :( Let me know what you need to troubleshoot th

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Will Stevens
Cant we just host the mirror list in apache.org and then actually host the mirrors in different places around the world? A company could sponsor the few bucks a month for AWS and have one of the mirrors be in AWS and the mirror list in apache.org would just be updated to add the AWS mirror. Isn't

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220716022 I think since it is an intermittent issue, we did not catch it on the actual PR it was introduced in. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220715917 I am getting it on almost every PR right now (if you notice the last 6 or 7 CI runs), so I will have to review this as it seems to have been introduced recently...

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220715486 @rhtyd can you specify the logs you need if I run into this issue so you can track down why it is happening? I will leave it in for now but I would like to send you

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220715003 And of course the first build I do after I merge it into master I get the `addHost` error and I did not get it once after I pulled it out. Haha... I will build agai

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220675936 @swill thank you for your time in testing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220675652 Thanks @swill if we keep getting this error, I'll try to find some time to see what's causing this as well --- If your project is set up for it, you can reply to thi

Re: [Discuss] CloudStack documentation

2016-05-20 Thread Ron Wheeler
A couple of comments. The definition of the audience for each document should be clearly understood. Size: What is targeted for large organizations (hundreds of servers) with dedicated staff and sophisticated needs - what is targeted for SMB (5-50 servers) with limited staff and simple needs.

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64080090 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java --- @@ -0,0 +1,370 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64078451 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -270,15 +258,15 @@ public PingCommand g

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx
Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799 Thanks @swill. Folks, pls review :) Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Daan Hoogland
is there no way, within foundation bylaws, to host this somewhere on apache.org? we are using peoples wibesites for tests as well, aren't we. On Fri, May 20, 2016 at 7:04 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > We could host a mirror here. We are in South America, Brazil. >

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Rafael Weingärtner
We could host a mirror here. We are in South America, Brazil. On Fri, May 20, 2016 at 2:01 PM, Chiradeep Vittal wrote: > I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I > realized that someone needs to own the account. There is no legal entity > for Apache CloudStack (e

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I realized that someone needs to own the account. There is no legal entity for Apache CloudStack (except the ASF) that can enter into a contract with AWS (even if it is for a few bucks a month). To make this work, alternatives

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V. From: Rafael Weingärtner Sent: Friday, May 20, 2016 10:42 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents You are right Mike about the “_”. The p

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
Agree with Daan : we shouldn't be pushing these ancient insecure templates! On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal wrote: > :) According to Raja, there is some time before download.cloud.com is > doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec > 25, 2016 and

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
I noticed ;) Yes, we do not have Marvin tests for Hyper-V (at least that is what I know). I believe most of the tests that are being executed nowadays use either KVM or XenServer; some people might be executing few of them too in VMware environments. On Fri, May 20, 2016 at 1:50 PM, Tutkowski, M

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
:) According to Raja, there is some time before download.cloud.com is doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec 25, 2016 and we're still debating mirror list vs steps and what not. Now, just change the 2017 to 2016 and re-consider. We need this done yesterday!

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V. From: Rafael Weingärtner Sent: Friday, May 20, 2016 10:49 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents I think that if we say we support H

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Also, does this mean that we have zero Hyper-V integration tests run during CI? From: Tutkowski, Mike Sent: Friday, May 20, 2016 10:47 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents Yeah, it has to go into 4.9.

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
I think that if we say we support Hyper-V we should care about it. On Fri, May 20, 2016 at 1:47 PM, Tutkowski, Mike wrote: > Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V. > > From: Rafael Weingärtner > Sent: Friday, May 20, 2016 10:4

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
You are right Mike about the “_”. The point is that in some other language the use of “_” makes sense, whereas in Java it does not, at least not the way it has being used in ACS. We have code conventions, it can be found in [1]. The problem is that it is a bit outdated and I think it could benefit

[GitHub] cloudstack pull request: Refactor system VM default network creati...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-220656774 Ran again because the error was not something I had seen often. The errors in the new run are not related to this PR. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Refactor system VM default network creati...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-220656462 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 1 Errors: 4 Duration: 10h 22m 36s ``` **Summary of the

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
It sounds like most people don't like a preceding "_" for member variables and that is fine. Do we have any formal Java coding standards for CloudStack, by the way? I'm not aware of any. The main problem here, though, is that this particular piece of code is super fragile, so it would be great

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018 @swill Travis passed. Looks like it is ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread sverrirab
Github user sverrirab commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220644228 Rebased the PR to latest master and reverted the relevant commit (64b72a5c5a410f41bd869cc9d40807d888e05055.). I think we should be good to go @swill ? --- If y

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
Hahaha, do not get addicted to it Daan ;) That is probably due to the environment I am living in right now. I am not a member per se of the GsonLD project [2]; I have just used it in another research/work. So, there is this protocol called OpenID Connect, and one of the things we did not like muc

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220640589 Ok. Travis has been pretty consistently green for PRs recently, so I have not seen this problem elsewhere. I am not sure why there are sometimes more than once Trav

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
Rafael [2] is a members only link (pornographia academia?) On Fri, May 20, 2016 at 5:12 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi guys, > I agree with Daan that if class fields have improper (not descriptive or > not suitable) names we should change them. However, I do not

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
It might be a total pipe dream, but if the API was also Swagger compliant, it would simplify our API documentation and would make API tooling much easier. I have not looked into what would be required, but it would definitely be a nice to have. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cl

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220637398 @swill please see my comment above about the travis failures. BTW why is there sometimes two travis runs (pr and push) and sometimes only one? --- If your pro

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
Hi guys, I agree with Daan that if class fields have improper (not descriptive or not suitable) names we should change them. However, I do not find the change (on variable names) introduced by PR #816 good. It added an “_”(underline) before variable names; even though Apache CloudStack has a lot of

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220633650 @sverrirab thank you. Would you mind adding the revert of #1495 into this commit in order to clean up unnecessary packages once this PR is accepted? I think we are

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220632778 Ya, sorry, I had a backlog of commits that were ready while I sorted out some merge conflicts doing a forward merge from 4.8 and then testing the resulting master to

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-220631924 Ok, thanks @nitt10prashant. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220629640 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 44m 23s ``` **Associ

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220629958 This one is coming back clean. If we can get Jenkins and Travis green I think this one is ready... --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220628965 Similar issues on this run. They are not related to this PR. Still need some review on this one... --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220628656 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 4 Duration: 8h 31m 38s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220628402 BTW, thank you for your quick response time to work through issues on your PRs and get things stabilized. I really do appreciate it. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220628087 Two clean runs in a row. I think this one is ready to put back in now... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220627907 ### CI RESULTS ``` Tests Run: 83 Skipped: 0 Failed: 0 Errors: 2 Duration: 8h 27m 27s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220627549 Thanks @koushik-das, I need to track down what changed to cause that intermittent problem of the `template.status`. I need some code review on this one. Thanks...

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220626559 @rhtyd thank you. I will review what happened there. This is something that has started showing up intermittently, but only started happening in the last few weeks.

RE: [Discuss] CloudStack documentation

2016-05-20 Thread Rajsekhar K
Hi, All, I agree with Dag Sonstebo that we need to improve the layout and navigation of CloudStack documentation. I think that the improvement should begin from the home page. New users may not find the way the information presented on the home page very intuitive. A few tweaking on the home p

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220624878 I have seen similar issues in a couple other PRs. Since this is a PR related to connectivity, I do want to try to get a cleaner CI run if I can. Also, travis is fai

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220622074 Can I get some code review on this one. It is looking to be in pretty good shape otherwise. Thanks... --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220621430 @DaanHoogland yes, I will retest now. Thanks guys... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220619741 For some reason Travis is unhappy. Would you mind trying again. Sorry for the inconvenience... --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220615109 @swill nothing outstanding on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734 LGTM :) It seems to work correctly on my 4.8.0 setup. Thanks. Best regards, Aurélien --- If your project is set up for it, you can reply to

Re: Refactoring CitrixResourceBase

2016-05-20 Thread Syed Mushtaq
Thanks guys for the Ideas. I will open a JIRA ticket and start working on it. -Syed On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi Syed, > That is a great idea; however, it is a very hard task. > The idea of Tim is great; actually, we already have

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r64042208 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java --- @@ -0,0 +1,30 @@ +package org.apache.cloudstack.s

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220608044 Thanks @swill @koushik-das! Sorry I was missing a license header, I pushed it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1553#discussion_r64040574 --- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java --- @@ -1014,6 +1014,13 @@ public static void initDataSource(Properties dbProps

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141 @DaanHoogland, triggering you for review as well, this is only a small code change --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220599638 LGTM, do we retest @swill? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220596270 I am getting similar errors in other PRs, so I don't think they are related to this PR. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220595991 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 12m 50s ``` **Summary of the p

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220595800 Im not sure what to think of those failures. I will run again in clean setup to see if I can get rid of those. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1555 Add Java Default Certificat Authorities into the keystore if using a custom cert SSL Related to CLOUDSTACK-1475 You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220595610 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 21m 39s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220595138 This is a passing CI now. @koushik-das do you have anything outstanding with this PR? @nvazquez can you close and reopen or do a force push to kick off a Jen

  1   2   >