[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-222046182 Hi @ustcweizhou @DaanHoogland @remibergsma, I moved global config definitions to `ConfigKey.java` instead of `Config.java` and `schema-481to490.sql`.

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-222045623 ### ACS CI BVT Run **Sumarry:** Build Number 61 Hypervisor xenserver NetworkType Advanced Passed=66 Failed=2 Skipped=3

[GitHub] cloudstack pull request: Refactor test_vpc_vpn, add test for multi...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1355#issuecomment-222025028 ### ACS CI BVT Run **Sumarry:** Build Number 60 Hypervisor xenserver NetworkType Advanced Passed=67 Failed=5 Skipped=3

[GitHub] cloudstack pull request: Removed unused methods from XenServerConn...

Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/1557#issuecomment-222007302 Hello again @rafaelweingartner, I did as you suggested. I also checked that the variable **file** was not used anywhere else besides lines 60 - 76, so I also

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-221985483 ### ACS CI BVT Run **Sumarry:** Build Number 59 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3

Build failed in Jenkins: build-master-jdk18 #527

See Changes: [Remi Bergsma] lower the time we wait for interfaces to appear [sanjeev] CLOUDSTACK-9388: Remove string conversion in assertion statement -- [...truncated 430 lines...]

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-221960352 I have attempted to run CI against this one 3 times in a row on different CI environments. Every time it is failing with the following: ``` Deploy

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-221940475 ### ACS CI BVT Run **Sumarry:** Build Number 58 Hypervisor xenserver NetworkType Advanced Passed=67 Failed=4 Skipped=3

Re: Refactoring CitrixResourceBase

Got it, maybe when you open the PR we can work together to use spring framework to manage those beans. On Thu, May 26, 2016 at 2:05 PM, Syed Mushtaq wrote: > Yes Rafae. I saw that XenServer classes are not plugged into Spring. I am > instantiating the objects manually

Re: Refactoring CitrixResourceBase

Yes Rafae. I saw that XenServer classes are not plugged into Spring. I am instantiating the objects manually in the configure() method of the base class and using them. On Thu, May 26, 2016 at 12:16 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Indeed, this is a non-trivial job,

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1499#issuecomment-221921405 @swill Sure can do, sorry for the delay, I haven't had much time lately but that will be done soon. --- If your project is set up for it, you can

Re: Refactoring CitrixResourceBase

Indeed, this is a non-trivial job, and it will take a pretty good amount of time and effort. Sorry, I did not understand what you meant with "reference" file. Is that the base file that you are using to create a hierarchy? The solution you are creating looks promising, I am just wondering; you

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1491 Fixes regarding VOLUME_DELETE events resulting from account deletion. New version of #1373, but updated for the 4.7 branch with another fix that allows it to properly find expunged root

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-221916927 @ProjectMoon and again. :( sorry... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221904814 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 3 Duration: 8h 17m 54s ``` **Summary of the

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-221904409 I actually had a test running overnight for this one and it had similar results. ``` Tests Run: 85 Skipped: 0 Failed: 14 Errors: 6

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-221901259 I will retest this one. Thanks for kicking it off again, we are green now. :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221900033 Thanks guys. This one is ready... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221893016 Maybe you meant to change on this table: `` alter table `vm_template` modify column `url` varchar(2048) DEFAULT NULL COMMENT 'the url where the

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221891214 @remibergsma, sounds fair. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221888640 @nlivens We shouldn't wait more than 2s, because that means the interface is not there and will not come yet. Currently it's horribly slow because every

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221876586 @wido I have the 255-chars problems here too, and this particular table is empty; did you add a patch on the API too to unlock the API limitation to 255 chars ?

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1491 Fixes regarding VOLUME_DELETE events resulting from account deletion. New version of #1373, but updated for the 4.7 branch with another fix that allows it to properly find expunged root

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-221873700 @ProjectMoon try to close and reopen this one to try to get it green. thx... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221873120 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 23m 38s ```

[GitHub] cloudstack pull request: Add lsb-release dependency to mgmt server...

GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1565 Add lsb-release dependency to mgmt server and agent on Debian/Ubuntu. New version of #1412, based on the 4.7 branch. You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: Add lsb-release dependency to mgmt server...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Add lsb-release dependency to mgmt server...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1565#issuecomment-221872868 @ProjectMoon please close and reopen to kick off travis again. Thanks... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-221871305 I think the only thing we are missing with this one is verification that the change works and does not break anything. @pedro-martins is there anything you can

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-221867807 @swill no worries. Happy to do that - the CI output was vast and I wasn't looking forward to combing through it. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

GitHub user dsclose reopened a pull request: https://github.com/apache/cloudstack/pull/1519 Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces This PR addresses CLOUDSTACK-9339 and may need a code review from someone familiar with the System VM scripts. In

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user dsclose closed the pull request at: https://github.com/apache/cloudstack/pull/1519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1561#issuecomment-221863597 @sanju1010 thanks for posting the test results with this change. This one should be good now. Thanks everyone... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-221863141 this one just does not want to turn green. :( wanna give it another shot @rhtyd? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-221862724 @dsclose sorry to do this to you. Can you close and reopen again to kick off the jobs again? Thanks... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-221862006 @bvbharatk can you close and reopen this PR to kick off jenkins again to see if we can get this green? I will rerun CI on it to make sure we are still good

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-221861017 Can I get one more review on this one? I think we are basically set otherwise. Thx... --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user sverrirab closed the pull request at: https://github.com/apache/cloudstack/pull/1526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: L10n update master 20160127

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-221846787 ### ACS CI BVT Run **Sumarry:** Build Number 56 Hypervisor xenserver NetworkType Advanced Passed=72 Failed=1 Skipped=3

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1566 Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. New version against #1330, opened against master. ``` Moving stop of management

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-221846556 Closing to open against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-221846391 Rebased against latest 4.7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-221846283 Rebased against latest 4.7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Add lsb-release dependency to mgmt server...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1565 Add lsb-release dependency to mgmt server and agent on Debian/Ubuntu. New version of #1412, based on the 4.7 branch. You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: Add lsb-release dependency to agent and m...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Add lsb-release dependency to agent and m...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1412#issuecomment-221845606 Closing to open new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Emit template UUID and class type over ev...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1564 Emit template UUID and class type over event bus when deleting templates New version of #1378 for the 4.7b branch instead of 4.6. You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1378#issuecomment-221844538 Making a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-221841462 LGTM. This file seems to be remains from the previous attempt of HyperV support which was talking to SCVMM. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9389:changing check_string fro...

GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/1563 CLOUDSTACK-9389:changing check_string from 3 packets received to 3 re… test cases were failing due to invalid check_string so changing check_string from "3 packets received"

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-221834704 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221825423 commit 5c35bd1b3e0184842ed80a9c465549c2a61f5fd9 copied all the data from template_host_ref to template_store_ref --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221824946 LGTM 👍(code review only) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221823209 @karuturi Are you sure about that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221821581 This table is not used anymore. the table should be dropped. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1561#issuecomment-221821063 Simple change. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221791953 @remibergsma, I understand your concern regarding the wait_until method. Perhaps we could use the wait_until with a 2s interval and a max wait of 4s? That's 1

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9380: fix NPE in listDomains A...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-221788191 I ran bunch of tests(related to network functionality) from the regression test suite(test/integration/component) on this PR branch and I don't see any test

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

GitHub user dsclose reopened a pull request: https://github.com/apache/cloudstack/pull/1519 Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces This PR addresses CLOUDSTACK-9339 and may need a code review from someone familiar with the System VM scripts. In

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers do not h...

Github user dsclose closed the pull request at: https://github.com/apache/cloudstack/pull/1519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-221785775 @swill Rebased with master and resolved the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub