If you could get 2 LGTMs(any one from your team can also review
and give LGTM) and if you can run BVT suite on
PR(https://github.com/apache/cloudstack/tree/master/test/integration/smoke),
they can be immediately merged.
~ Rajani
http://cloudplatform.accelerite.com/
On August 30, 2016 at 3:47 AM,
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1660
Minor improvements suggested, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76731318
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +198,10 @@ public static void scpTo(String host, int port, String
user,
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r76731031
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -43,9 +43,9 @@
protected static final int DEFAULT_AGGREGATION_RANGE = 1440;
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r76730973
--- Diff: usage/conf/log4j-cloud_usage.xml.in ---
@@ -48,7 +48,7 @@ under the License.
-
+
---
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r76730939
--- Diff: debian/cloudstack-usage.postinst ---
@@ -43,6 +43,10 @@ case "$1" in
rm -rf /etc/cloudstack/usage/key
ln -s
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1560
LGTM (code/logic seems alright, did not run any tests).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1511
### ACS CI BVT Run
**Sumarry:**
Build Number 82
Hypervisor xenserver
NetworkType Advanced
Passed=100
Failed=1
Skipped=3
_Link to logs Folder (search
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1560
@rhtyd @jburwell Can this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@rhtyd @jburwell Can this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@rhtyd @jburwell Can this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Hi All,
The Nuage Networks team is investing in ACS 4.10.0 and has several feature
PR's outstanding for review :
- https://github.com/apache/cloudstack/pull/1578
- https://github.com/apache/cloudstack/pull/1580
- https://github.com/apache/cloudstack/pull/1579
-
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1511
### ACS CI BVT Run
**Sumarry:**
Build Number 81
Hypervisor xenserver
NetworkType Advanced
Passed=100
Failed=1
Skipped=3
_Link to logs Folder (search
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@jburwell I will check with @nitt10prashant on this. Will try to add the
tests in PR #1417 to this PR.
---
If your project is set up for it, you can reply to this email and have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@jburwell Commit message amended. Is it ok like this? Yes, it should be ran
against VMware.
We also made some individual tests for `SshHelper.sshExecute` by adding a
test API method
We have done more investigations. An error happens when the script
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh is
executed:
MGMT LOGS:
2016-08-29 16:00:11,342 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-12:null) (logid:) Seq 8-1837187172990452475:
Processing: { Ans: ,
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1511
### ACS CI BVT Run
**Sumarry:**
Build Number 79
Hypervisor xenserver
NetworkType Advanced
Passed=100
Failed=1
Skipped=3
_Link to logs Folder (search
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@jburwell With this PR test_network_acl is successfull
[root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt
Test network ACL lists and items in VPC ... === TestName:
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1621
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1586
code change LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1622#discussion_r76589032
--- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java
---
@@ -347,4 +351,11 @@ public String getZoneId() {
return
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1622#discussion_r76588913
--- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java
---
@@ -169,6 +169,10 @@
@Param(description = "additional
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r76588305
--- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
---
@@ -102,6 +102,14 @@
@Param(description = "indicates whether
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@leprechau You may add an unit test as well for
NetUtils.validateGuestCidr(). Check NetUtilsTest.java, there is already an
existing test for 192.168.
---
If your project is set up for it,
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1618
Please add/modify Marvin tests based on these scenarios.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r76588109
--- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
---
@@ -199,4 +207,20 @@ public boolean isRevertable() {
public
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1660
@jburwell I don't have a VMware setup, maybe when we got Trillian back I
could have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1624
Until #1654 is fixed and merged, all 4.8 will fail due to db upgrade
failures. /cc @jburwell
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
Have rebased to latest 4.8. Travis build failed with what looks like
`Unable to execute
/home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql:
Unknown column
GitHub user ProjectMoon reopened a pull request:
https://github.com/apache/cloudstack/pull/1624
Fixes regarding VOLUME_DELETE events resulting from account deletion
New version of #1491.
**Original Description**
New version of #1373, but updated for the 4.7 branch with
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1624
Jenkins build log has vanished into 404 oblivion. Will see what happened
with Travis (https://travis-ci.org/apache/cloudstack/builds/154436801).
---
If your project is set up for it, you
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1623
Yeah. Unfortunately I have not had any time to work on the pull requests
lately. When I have time I will reopen it against 4.9.
---
If your project is set up for it, you can reply to this
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1663
Thanks a lot for implementing this properly :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user NuxRo closed the pull request at:
https://github.com/apache/cloudstack/pull/1653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo this PR can be closed as we've moved to a new one with a marvin test
#1663
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1663
[LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflection attacks
CLOUDSTACK-6432: Prevent DNS reflection attacks
DNS on VR should not be publically accessible as it may be prone
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1663
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76569173
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String
thanks Simon and Rohit for the valuable inputs! After applying the
following procedure the ssl errors are gone and host state is UP.
# service cloudstack-management stop
mysql> delete from configuration where name = "ssl.keystore" ;
# mv
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1636
@jburwell @milamberspace due to version change in poms already merged on
4.8 without a valid db upgrade path (which I had added in a separate PR), we'll
see db failures for all PRs targeting 4.8
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1663
@jburwell @NuxRo thanks for the reviews, I've fixed the outstanding
issues. Please re-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76561440
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76561383
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76561300
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76561273
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76561209
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76560781
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1663#discussion_r76560808
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1648
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1648
We've enough LGTMs and Travis test is passing, I'm merging this now. Thanks
@jburwell @abhinandanprateek .
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell changing code version (in pom.xml) to 4.8.2.0-SNAPSHOT is a valid
change, but due to the way our db upgrade path works please revert the change
on db upgrade path names and string
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1621
@jburwell the cause of failure is due to an env issue
(`java.lang.OutOfMemoryError: PermGen space issue`), @milamberspace can you
close and open the PR, or do a push -f to force Travis to run
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1665
@jburwell -1
The db upgrade version only considers the major/minor fields such as a.b.c,
the last `.d` is ignored (for that matter any other suffix in the version). Due
to the current
54 matches
Mail list logo
