[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

2016-12-30 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1812 ### ACS CI BVT Run **Sumarry:** Build Number 202 Hypervisor xenserver NetworkType Advanced Passed=98 Failed=7 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1882: CLOUDSTACK-8737: Removed the missed out-of-band VR r...

2016-12-30 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1882 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1861#discussion_r94216180 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -230,6 +230,7 @@ import

[GitHub] cloudstack pull request #1882: CLOUDSTACK-8737: Removed the missed out-of-ba...

2016-12-30 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1882 CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. You can merge this pull request into a Git repository by running: $

[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1861#discussion_r94216151 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -123,12 +125,14 @@ import

[GitHub] cloudstack issue #865: CLOUDSTACK-8856 Primary Storage Used(type tag with va...

2016-12-30 Thread koteswararavipati
Github user koteswararavipati commented on the issue: https://github.com/apache/cloudstack/pull/865 LGTM: I tested this issue manually and looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #865: CLOUDSTACK-8856 Primary Storage Used(type tag ...

2016-12-30 Thread koteswararavipati
Github user koteswararavipati commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/865#discussion_r94215572 --- Diff: server/src/com/cloud/server/ManagementServerImpl.java --- @@ -2488,6 +2479,23 @@ public int compare(final SummedCapacity arg0, final

[GitHub] cloudstack pull request #865: CLOUDSTACK-8856 Primary Storage Used(type tag ...

2016-12-30 Thread koteswararavipati
Github user koteswararavipati commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/865#discussion_r94215553 --- Diff: server/src/com/cloud/server/ManagementServerImpl.java --- @@ -2488,6 +2479,23 @@ public int compare(final SummedCapacity arg0, final

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2016-12-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1862 @sateesh-chodapuneedi Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1819: CLOUDSTACK-9653 The system capacity was not g...

2016-12-30 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1819: CLOUDSTACK-9653 The system capacity was not g...

2016-12-30 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1819 CLOUDSTACK-9653 The system capacity was not getting calculated correctly When listCapacity is used with the sortBy=usage option, the capacity was not getting calculated correctly.

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1841 Thanks @sureshanaparti --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1862: CLOUDSTACK-9704 Remove dependency on VmwareCo...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1862#discussion_r94214404 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -5620,4 +5623,39 @@ private

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2016-12-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1841 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1862 Thanks @sureshanaparti for review. I have addressed that now. Pushed the code changes, please check. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2016-12-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1879 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2016-12-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2016-12-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1879 @sureshanaparti can you push -f on the PR, Travis failed. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2016-12-30 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1880 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1871: [4.9] CLOUDSTACK-9692: Fix password server issue in ...

2016-12-30 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1871 @rhtyd Could you please run the test again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #775: CLOUDSTACK-8805: Domains become inactive automaticall...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/775 LGTM for code. Looks like tests are successful too based on results published by @bvbharatk @karuturi Should we consider this for merge OR re-run tests again as the previous

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1758 @nitin-maharana LGTM for code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1881 @karuturi As this PR is about removal of a deprecated configuration setting which is no more referenced any where in the repo, can we merge this without functional tests? Or we

[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2016-12-30 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1880 @sureshanaparti Travis tests ended with timeout. Can you please try force push? ```The job exceeded the maximum time limit for jobs, and has been terminated.``` --- If your