rhtyd merged pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rhtyd commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r444666360
##
File path: src/views/network/CreateL2NetworkForm.vue
##
@@ -164,7 +190,8 @@ export default {
networkOfferings: [],
networkOffering
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648613412
@utchoang please avoid making changes to core widgets including ListView,
ResourceView etc; as/when necessary put slots in them and create components
that embed them and
rhtyd commented on a change in pull request #298:
URL: https://github.com/apache/cloudstack-primate/pull/298#discussion_r444665581
##
File path: src/components/view/ListView.vue
##
@@ -16,220 +16,272 @@
// under the License.
-
-
-
-{{ `Selected ${select
shwstppr commented on a change in pull request #441:
URL: https://github.com/apache/cloudstack-primate/pull/441#discussion_r444655129
##
File path: src/views/AutogenView.vue
##
@@ -740,7 +740,8 @@ export default {
this.currentAction.paramFields.map(field => {
le
davidjumani commented on pull request #235:
URL:
https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648575657
Tested. LGTM. However, would it make sense to change the colour of the
filter icon or the placeholder in the search tab to show that there is a filter
in effect ?
rhtyd merged pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
blueorangutan commented on pull request #444:
URL:
https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648567018
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/444 (JID-2
blueorangutan commented on pull request #373:
URL:
https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648567047
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2
blueorangutan commented on pull request #413:
URL:
https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648566737
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/413 (JID-2
blueorangutan commented on pull request #170:
URL:
https://github.com/apache/cloudstack-primate/pull/170#issuecomment-648566072
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/170 (JID-2
shwstppr commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648565445
@rhtyd already LGTM'd the latest changes. Now it only fixes the create form
This is an automated mess
blueorangutan commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648564555
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/446 (JID-2
blueorangutan commented on pull request #419:
URL:
https://github.com/apache/cloudstack-primate/pull/419#issuecomment-648564508
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/419 (JID-2
blueorangutan commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648564362
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/298 (JID-2
blueorangutan commented on pull request #428:
URL:
https://github.com/apache/cloudstack-primate/pull/428#issuecomment-648564296
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/428 (JID-2
blueorangutan commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648564010
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/298 (JID-2
blueorangutan commented on pull request #379:
URL:
https://github.com/apache/cloudstack-primate/pull/379#issuecomment-648563912
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/379 (JID-2
blueorangutan commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648560159
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #428:
URL:
https://github.com/apache/cloudstack-primate/pull/428#issuecomment-648559920
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #419:
URL:
https://github.com/apache/cloudstack-primate/pull/419#issuecomment-648560014
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648560109
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #373:
URL:
https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648559692
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648559782
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
rhtyd commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648559916
@shwstppr can you re-review the PR and also check against old UI and if
that's wrong what ideal parameters must be sent as part of API request
@blueorangutan package
blueorangutan commented on pull request #444:
URL:
https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648559830
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
rhtyd commented on pull request #419:
URL:
https://github.com/apache/cloudstack-primate/pull/419#issuecomment-648559482
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #428:
URL:
https://github.com/apache/cloudstack-primate/pull/428#issuecomment-648559535
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
blueorangutan commented on pull request #413:
URL:
https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648559550
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
blueorangutan commented on pull request #379:
URL:
https://github.com/apache/cloudstack-primate/pull/379#issuecomment-648559617
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
rhtyd commented on pull request #444:
URL:
https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648559603
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #413:
URL:
https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648559404
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #373:
URL:
https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648559283
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
blueorangutan commented on pull request #170:
URL:
https://github.com/apache/cloudstack-primate/pull/170#issuecomment-648559266
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
rhtyd commented on pull request #379:
URL:
https://github.com/apache/cloudstack-primate/pull/379#issuecomment-648559340
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
rhtyd commented on pull request #170:
URL:
https://github.com/apache/cloudstack-primate/pull/170#issuecomment-648559132
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the mess
rhtyd commented on pull request #298:
URL:
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648559207
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the mess
rhtyd commented on a change in pull request #441:
URL: https://github.com/apache/cloudstack-primate/pull/441#discussion_r444621521
##
File path: src/views/AutogenView.vue
##
@@ -740,7 +740,8 @@ export default {
this.currentAction.paramFields.map(field => {
let f
Hi Rohit,
I’m guessing in your case (since you say this storage is similar to RBD) that
it would, as you say, be simpler to make changes to
CloudStackPrimaryDataStoreLifeCycleImpl to support this new storage type.
Of course, this then adds yet one more storage type that that particular class
i
blueorangutan commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648222332
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian
:heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/446 (JID-2
blueorangutan commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648216561
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep
you posted as I make progress.
---
rhtyd commented on pull request #446:
URL:
https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648215991
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the messa
ravening commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444277670
##
File path: src/config/section/offering.js
##
@@ -27,7 +27,6 @@ export default {
docHelp:
'adminguide/service_offerings.html#compute-a
shwstppr commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444270921
##
File path: src/config/section/offering.js
##
@@ -27,7 +27,6 @@ export default {
docHelp:
'adminguide/service_offerings.html#compute-a
ravening commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444263000
##
File path: src/views/offering/AddDiskOffering.vue
##
@@ -358,6 +358,9 @@ export default {
}
},
isAdmin () {
+ if (