Re: Issue https://github.com/apache/cloudstack/issues/8280 with 4.19.0

2024-02-21 Thread Wei ZHOU
It is already in 4.19 and main branch. -Wei On Thursday, February 22, 2024, Rahul Rai wrote: > Hi Team, > > I have experienced the same error with rhel 9 kvm with UEFI enabled > instance. > > I see that the code was merged with 4.18. Can we expect that to be merged > in 4.19 as well? > > https:

Issue https://github.com/apache/cloudstack/issues/8280 with 4.19.0

2024-02-21 Thread Rahul Rai
Hi Team, I have experienced the same error with rhel 9 kvm with UEFI enabled instance. I see that the code was merged with 4.18. Can we expect that to be merged in 4.19 as well? https://github.com/apache/cloudstack/pull/8282 Thanks Rahul

Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]

2024-02-21 Thread via GitHub
weizhouapache commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956977692 > Next time we generate the code, we will have to do these changes again. If we plan to support this for next release only, then it's fine. Otherwise it would be better to make it

Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]

2024-02-21 Thread via GitHub
vishesh92 commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956808293 Next time we generate the code, we will have to do these changes again. If we plan to support this for next release only, then it's fine. Otherwise it would be better to make it part

Re: [PR] restore methods with 4.19 optional API params [cloudstack-go]

2024-02-21 Thread via GitHub
weizhouapache commented on PR #77: URL: https://github.com/apache/cloudstack-go/pull/77#issuecomment-1956139850 looks ok to me @hrak @rohityadavcloud what's your opinion ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-21 Thread via GitHub
shwstppr commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1956134999 @weizhouapache @rohityadavcloud I've created #77 to restore breaking changes from ACS 4.19. Do we need to do it for 4.18 as well since this issue relates to that? -- This is an

[PR] restore methods with 4.19 optional API params [cloudstack-go]

2024-02-21 Thread via GitHub
shwstppr opened a new pull request, #77: URL: https://github.com/apache/cloudstack-go/pull/77 ACS 4.19 makes some parameters optional for some of the APIs. If they are removed from the constructors it may break compatibility with older ACS releases. Since golang doesn't support method overl