b8da4c8
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyThumbnailHandler.java
06f21d3
utils/src/com/cloud/utils/net/NetUtils.java 6350986
Diff: https://reviews.apache.org/r/19917/diff/
Testing
---
Thanks,
Ding Yuan
> On April 2, 2014, 4:41 p.m., daan Hoogland wrote:
> > Ding Yuan, I like your work and explanation why it should be done. I would
> > like to see more distinct messages in the log statement. To often exactly
> > the same line is logged from different locations, not
// and IllegalAccessException setting one of the parameters.
226: throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Internal error
executing API command " + cmd.getCommandName().substring(0,
cmd.getCommandName().length() - 8));
227: }
The "FIXME" comment seems to suggest for getter
exceptions.
Please let me know if this is not desirable so I can further update.
Thanks,
Ding
On Apr 2, 2014, at 5:17 PM, Ding Yuan wrote:
> Thanks all for the quick comments!
> If i understand the discussion correctly, I will just change all the added
> log printing statements to debu
/utils/net/NetUtils.java 6350986
Diff: https://reviews.apache.org/r/19917/diff/
Testing
---
Thanks,
Ding Yuan
/utils/net/NetUtils.java 6350986
Diff: https://reviews.apache.org/r/19917/diff/
Testing
---
Thanks,
Ding Yuan
pening that we
> need done.
>
> I don't see a new version of the diff in the review request. Did you
> 'Update' -> 'Upload Diff'?
>
> regards,
> Daan
>
> On Thu, Apr 3, 2014 at 12:34 AM, Ding Yuan wrote:
>> Uploaded a new patch to 1
will also work on assigning the proper reviewers now.
Thanks,
Ding
On Apr 3, 2014, at 12:04 PM, Daan Hoogland wrote:
> thanks Ding,
>
> I saw your update. Did your run a cloud with this code; i.e. did you
> monkey-test it?
>
> On Thu, Apr 3, 2014 at 5:26 PM, Ding Yuan wrote
ls/src/com/cloud/utils/net/NetUtils.java 6350986
Diff: https://reviews.apache.org/r/19917/diff/
Testing
---
Thanks,
Ding Yuan
ance. You explained the background of your effort and I am
> curious as to how it satisfied your objectives.
>
> I will let the patch rest a few days to see if we get any more
> reactions and apply it from Denver next week.
>
> On Sat, Apr 5, 2014 at 2:03 AM, Ding Yuan wrote:
&g
On April 5th, 2014, 3:16 a.m. UTC, Ding Yuan wrote:
Review request for cloudstack, Alena Prokharchyk, Alex Huang, Chiradeep Vittal, daan Hoogland, edison su, David Nalley, Laszlo Hornyak, Mike Tutkowski, Prachi Damle, and Venkata Siva Vijayendra Bhamidipati.
By Ding Yuan.Updat
oesn't apply, I'm afraid. Can you rebase it to latest master? Make sure it is only one commit.On Mon, Apr 14, 2014 at 8:48 PM, Ding Yuan <y...@ece.utoronto.ca> wrote:
Hi Daan,Here you go! Please let me know if this is not what you want...
Thanks a lot for this!DingOn Apr 14,
es me the chance to you diffs between your
> diffs so after a big diff I can see if nothing deteriorated next time. For
> now I'll just edit the comment and apply (after a unit test run).
>
> regards,
> Daan
>
>
>
>
> On Mon, Apr 14, 2014 at 11:18 P
13 matches
Mail list logo
