Re: Review Request 13882: CLOUDSTACK-4434: EN: Ubuntu: Direct input "- _ ", "? /", "keyboard /" , "keyboard -" keys are not working well for the US keyboard.

2013-08-28 Thread Fang Wang
> On Aug. 28, 2013, 7:39 p.m., Fang Wang wrote: > > Ship It! Looks fine. - Fang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13882/#re

Re: Review Request 13882: CLOUDSTACK-4434: EN: Ubuntu: Direct input "- _ ", "? /", "keyboard /" , "keyboard -" keys are not working well for the US keyboard.

2013-08-28 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13882/#review25681 --- Ship it! Ship It! - Fang Wang On Aug. 28, 2013, 9:21 a.m

Re: Review Request 13547: Extend listCapabilities API support to verify KVM snapshot enabled or not

2013-08-13 Thread Fang Wang
listCapabilities command again: { "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} } < reflect the true value. Verified the fix through the tests. Thanks, Fang Wang

Review Request 13547: Extend listCapabilities API support to verify KVM snapshot enabled or not

2013-08-13 Thread Fang Wang
://reviews.apache.org/r/13547/diff/ Testing --- Thanks, Fang Wang

Review Request 13459: cloudstack-3759: deployVM with state set to be stopped, attach volume to it. The volume should not be created.

2013-08-09 Thread Fang Wang
/VolumeManagerImpl.java 100aad3 Diff: https://reviews.apache.org/r/13459/diff/ Testing --- Thanks, Fang Wang

How to clean deployed system vm on xen host

2013-08-01 Thread Fang Wang
Hi, I started running MS , host is xen hypervisor. After 2 system vms are up, there were issues. So I made changes in source code, rebuild, did deploydb to clean DB. Now I am running ms again, but failed to bring up ssvm and cpvm, because of the existing old system vm from previous run. I kno

Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

2013-07-31 Thread Fang Wang
. Diffs - server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 Diff: https://reviews.apache.org/r/12958/diff/ Testing --- Thanks, Fang Wang

Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

2013-07-26 Thread Fang Wang
--- On July 25, 2013, 11:15 p.m., Fang Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12958/ > ---

Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

2013-07-25 Thread Fang Wang
--- Thanks, Fang Wang

Review Request 12712: Add a new snapshot flag in cloudstack for KVM 6.3 and verify it during the upgrade

2013-07-17 Thread Fang Wang
f89c862 server/src/com/cloud/configuration/Config.java e77f6ce server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 2c9ef82 Diff: https://reviews.apache.org/r/12712/diff/ Testing --- Thanks, Fang Wang

Review Request 12591: CLOUDSTACK-3566 Not able to create snapshot for KVM host -- backup snapshot fails

2013-07-16 Thread Fang Wang
/ Testing --- tested a snapshot created, and it got successfully backedup after the fix. Thanks, Fang Wang

RE: Review board inaccessible

2013-07-16 Thread Fang Wang
The review board is working now Thanks a lot! -Original Message- From: Fang Wang [mailto:fang.w...@citrix.com] Sent: Tuesday, July 16, 2013 3:28 PM To: dev@cloudstack.apache.org Subject: RE: Review board inaccessible Yes, the review board is still down. I just tried and wanted to post

RE: Review board inaccessible

2013-07-16 Thread Fang Wang
Yes, the review board is still down. I just tried and wanted to post a review When will it be fixed? Thanks, -Fang -Original Message- From: Nguyen Anh Tu [mailto:ng.t...@gmail.com] Sent: Tuesday, July 16, 2013 11:01 AM To: dev@cloudstack.apache.org Subject: Review board inaccessible Hi

Re: Review Request 12245: CLOUDSTACK-1960: Fix for UK Keyboard Bar symbol.

2013-07-09 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12245/#review22921 --- Ship it! looks good, ship it. - Fang Wang On July 3, 2013, 11

Review Request 12144: Create template from snapshot, failed due to the vmdk file failure.

2013-06-27 Thread Fang Wang
-4034-8053-3ed011d1be6e.ova.meta -rw-r--r-- 1 root root 299 Jun 27 14:19 template.properties -rw-r--r-- 1 root root 3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15.ovf Thanks, Fang Wang

Review Request 12143: Template created from snapshot: the vmdk path needs to be modified to accomodate the changed snapshot UUID format.

2013-06-27 Thread Fang Wang
3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15.ovf Thanks, Fang Wang

Re: Review Request: Fix a logging issue in my previsous hypervisor template code.

2013-06-13 Thread Fang Wang
/template/HypervisorTemplateAdapter.java 322f32e Diff: https://reviews.apache.org/r/11052/diff/ Testing --- Thanks, Fang Wang

Re: Review Request: CLOUDSTACK-1960: Key remapping fails to input the keys \ | ? of UK Keyboard

2013-06-12 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11650/#review21807 --- Ship it! Ship It! - Fang Wang On June 5, 2013, 8:09 a.m

Re: Review Request: Protect VNC port with password on KVM.

2013-05-13 Thread Fang Wang
and Kelven Yang. Description --- Add the protection for VNC port with password on KVM. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 Diff: https://reviews.apache.org/r/11058/diff/ Testing --- Thanks, Fang Wang

Re: Review Request: Protect VNC port with password on KVM.

2013-05-13 Thread Fang Wang
ity enhancements. - Fang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11058/#review20430 --- On May 10, 2013,

Review Request: Protect VNC port with password on KVM.

2013-05-10 Thread Fang Wang
protection for VNC port with password on KVM. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88 Diff: https://reviews.apache.org/r/11058/diff/ Testing --- Thanks, Fang Wang

Review Request: Fix a logging issue in my previsous hypervisor template code.

2013-05-10 Thread Fang Wang
--- Thanks, Fang Wang

Re: Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

2013-05-09 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11021/#review20386 --- Ship it! ship it! looks good - Fang Wang On May 9, 2013, 12:29

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-06 Thread Fang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20209 --- Ship it! Ship it! - Fang Wang On April 29, 2013, 9:09 a.m

Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support

2013-05-03 Thread Fang Wang
deleted. Those are needed for handling the JP keyboards. Did you replace them with other key combinations? just make sure it won't break the JP keyboards. Thanks. - Fang Wang On April 29, 2013, 9:09 a.m., Sanjay Tripathi

Review Request: Volume snapshots enhancements for Vmware

2013-05-01 Thread Fang Wang
, Fang Wang

Review Request: Volume snapshots enhancement for Vmware

2013-05-01 Thread Fang Wang
--- Retested the template create/extract, vol and snapshot commands, as in previous patches. Thanks, Fang Wang

Re: Review Request: Volume snapshot enhancements for vmware

2013-04-30 Thread Fang Wang
cluded in the newer patch - Fang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10815/#review19941 --- On April 27, 2013, 5:28 a.m.,

Review Request: Volume snapshot for vmware support

2013-04-29 Thread Fang Wang
/TemplateManagerImpl.java c7eaa64 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 4503349 Diff: https://reviews.apache.org/r/10845/diff/ Testing --- Done as described in previous patch. Thanks, Fang Wang

Review Request: Volume snapshot enhancements for vmware

2013-04-26 Thread Fang Wang
/PrepareOVAPackingCommand.java PRE-CREATION Diff: https://reviews.apache.org/r/10815/diff/ Testing --- Tested the snapshot creation; volume creation, copy, donwload; template creation, download,delete, and related commands. Thanks, Fang Wang

ssvm service name (vmware)

2013-04-20 Thread Fang Wang
Hi, I'd like to stop and restart the SSVM. I login to ssvm and tried "service cloud-agent restart" On SSVM, but it did not find any cloud-agent service. Is the service name "cloud" instead of "cloud-agent"? This is on 4.1 branch , and hypervisor is Vmware, Thanks, -Fang