[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...

2017-04-05 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/876#discussion_r109859606 --- Diff: plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

2017-04-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

2017-04-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1246 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2017-04-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1734 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

2017-04-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/892 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

2017-04-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/899 LGTM for the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_poo...

2017-04-01 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/876 @rhtyd As suggested I have added a marvin test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

2017-03-31 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/899 @yvsubhash Jenkins failed. Please force push the changes again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #2021: CLOUDSTACK-9854: Fix test_primary_storage test failu...

2017-03-30 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2021 LGTM for the code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

2017-03-30 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 @jayakarteek Thanks for testing. I have made the respective code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-30 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2002 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to ...

2017-03-30 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2012 LGTM for the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

2017-03-30 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/899 @yvsubhash your template related changes are not relevant to the issue fixed. Please remove the changes. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1722: CLOUDSTACK-9558 Cleanup the snapshots on the primary...

2017-03-29 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1722 LGTM for the code changes. @yvsubhash please change the base branch to 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-28 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2019 @koushik-das As suggested by you, I have added changes to correct the maxDataVolume limits. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2019 Thanks @koushik-das for reviewing this. So Let me close this and root volume detach should also be fixed as a part of PR #1953. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2019 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #2019: CLOUDSTACK-9851 travis CI build failure after...

2017-03-26 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/2019 CLOUDSTACK-9851 travis CI build failure after merge of PR#1953 & CLOUDSTACK-9850 Fixed travis CI failures happening after merge of PR#1953. Also fixed root volume detach that

[GitHub] cloudstack issue #2017: CLOUDSTACK-9847 vm_network_map is not getting cleane...

2017-03-23 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2017 @serg38 This is different from #1613. In #1613 vm_network_map was getting cleaned only when nic reservation strategy is Start, but not for Create. --- If your project is set up for it

[GitHub] cloudstack pull request #2017: CLOUDSTACK-9847 vm_network_map is not getting...

2017-03-23 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/2017 CLOUDSTACK-9847 vm_network_map is not getting cleaned While releasing nic for Create reservation strategy, vm_network_map is not getting cleaned. I have added corresponding code to

[GitHub] cloudstack pull request #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails some...

2017-03-21 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/2013 Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes This is a specific case when vm state gets updated by the vmsync before it can be updated by the api-job-executor thread. I could

[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...

2017-03-12 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1875 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

2017-03-06 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1875#discussion_r104600403 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -707,6 +709,23 @@ private String

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

2017-03-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/892 @alexandrelimassantana As suggested I have moved the code snippet to a method and also added unit tests. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1877: CLOUDSTACK-9716: Change of network to rvr for bareme...

2017-03-03 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1877 @rashmidixit Could you add a marvin test case? It looks with your changes, master VR Redundant state will be stuck in unknown state. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1797 LGTM on the code changes. Make sense to keep listVirtualMachines and listNics in sync for nic response. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached ...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1911 @mrunalinikankariya Can you provide some marvin test? Also is it possible to add some snapshots/test results? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1246 @nlivens As suggested I have moved the getValidNetworkCidr to common class NetworkModel. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

2017-03-02 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 Previous CI failures were not relevant to my changes. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2017-03-01 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1734 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

2017-03-01 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/892 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-03-01 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1978 LGTM for the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2017-03-01 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1734 @jburwell As suggested, I have added a marvin test case to verify the fix. Should I add it to smoke test suite. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1972 @niteshsarda I don't see any change in file createNetworkOffering.xml, but still there are many lines being removed and added. As there is not change in this file, please r

[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1972#discussion_r103159426 --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java --- @@ -29,4 +30,6 @@ List

[GitHub] cloudstack issue #1810: CLOUDSTACK-9647: NIC adapter type becomes e1000 , ev...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1810 LGTM for code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1725 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1869: CLOUDSTACK-9701: When host is disabled/removed, capa...

2017-02-26 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1869 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

2017-02-22 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1942 LGTM on the code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-22 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1957 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...

2017-02-16 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1909 @niteshsarda I see a problem here. The listNics command can be used to list both primary and secondary ips. In case if we pass nicid parameter with it, i feel we should use keywork to

[GitHub] cloudstack issue #1924: CLOUDSTACK-9766 : Executing deleteSnapshot api with ...

2017-02-16 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1924 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

2017-02-16 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1942 @niteshsarda Can you add some screenshots of the impact before the fix and after the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-15 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1910 Code changes looks good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-02-06 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1913 @nvazquez I think in case if connection to vcenter fails there are changes as the disk may get created on vcenter. In such case we may need to remove the vmdk. we can improve the logic to

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

2017-01-13 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1246 Moved the getValidNetworkCidr to common class NetworkModel and Rebased with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2016-12-14 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1734 @jburwell I have added a Marvin test case to verify the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2016-12-07 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1734 Manual Test on local environment ### Before Applying the fix http://localhost:8080/client/api?command=listPods&id=9b409cf0-a227-488d-87ea-0033aea2dcc5&

[GitHub] cloudstack issue #1736: CLOUDSTACK-9562 Linux Guest VM get wrong default rou...

2016-11-11 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1736 @ustcweizhou You are right. This is not fixing the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1736: CLOUDSTACK-9562 Linux Guest VM get wrong defa...

2016-11-11 Thread SudharmaJain
Github user SudharmaJain closed the pull request at: https://github.com/apache/cloudstack/pull/1736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1738: CLOUDSTACK-9566 instance-id metadata for bare...

2016-10-27 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1738 CLOUDSTACK-9566 instance-id metadata for baremetal VM returns ID There is difference in instance-id metadata across baremetal and other hypervisors. On Baremetal [root@ip

[GitHub] cloudstack pull request #1737: CLOUDSTACK-9561 Unable to delete domain/Accou...

2016-10-26 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1737 CLOUDSTACK-9561 Unable to delete domain/Account While deleting the UserAccount Cleanup for the removed VMs/volumes are not happening. For the removed VMs, snapshots doesn't get cl

[GitHub] cloudstack pull request #1736: CLOUDSTACK-9562 Linux Guest VM get wrong defa...

2016-10-26 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1736 CLOUDSTACK-9562 Linux Guest VM get wrong default route when there are… … multiple Nic REPRO STEPS == 1. Log as admin, create a VM CentOSx64 integrate

[GitHub] cloudstack pull request #1734: CLOUDSTACK-9567 Difference in the api call ou...

2016-10-26 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1734 CLOUDSTACK-9567 Difference in the api call outputs for CAPACITY_TYPE_… …CPU = 1 The total capacity reported listPods and listCapacity is different, ideally they have to be

[GitHub] cloudstack pull request #1733: CLOUDSTACK-9563 ExtractTemplate returns malfo...

2016-10-26 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1733 CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating… … NFS to s3 While downloading the template for the first time install path was not available. During

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-16 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-219617936 Rebased and pushed the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-12 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218960573 Getting following error with Jenkins Running org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest Testing don't block on newly created c

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-12 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218830874 @swill Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-10 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218362347 Rebased and pushed it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-09 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218056032 @swill I force pushed again and still it is failing. In logs I see following error. fatal: write error: No space left on device --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

2016-05-02 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/892#issuecomment-216196848 @rhtyd Rebased again master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-24 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-214143155 LGTM. Code Reviewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

2016-04-21 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/876#issuecomment-212794906 @alexandrelimassantana This method is about a query execution on database. Could you suggest how can i add a unit test for it? --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/892#issuecomment-212745452 Rebased the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212742630 The existing implementation for logrotation that works with xenserver 6.0 and earlier does not works with 6.0.2 and later. That is the reason I have added this

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/876#issuecomment-212725838 Rebased with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-212724576 @bhaisaab I pushed it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212718578 @bhaisaab Thanks for the comment. I have updated with the latest now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-212418415 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-212416597 @bhaisaab Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212408609 Rebased against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212404120 @bhaisaab Rebased the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

2016-04-20 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212360074 @pedro-martins On line 503, It is not a function but It is a way to define callback method. It has been used all over the cloudstack code. On line 504

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-04-19 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-212258625 @alexandrelimassantana I have made changes with respect to ur last comment. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2015-12-15 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1246 CLOUDSTACK-9165 unable to use reserved IP range in a network for exte… …rnal VMs Repro Steps -- 1. Create an isolated network with CIDR 192.168.200.0

[GitHub] cloudstack pull request: CLOUDSTACK-9166:Build failed in Jenkins: ...

2015-12-14 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1243 CLOUDSTACK-9166:Build failed in Jenkins: cloudstack-rat-master #7038 With my last PR#1196, I missed to place the license disclaimer into CitrixHelperTest.java. Updated the file with the

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-13 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164350819 Fixed the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-11 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1196#discussion_r47336103 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java --- @@ -236,4 +236,15 @@ public static

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-08 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1196 CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise… … Server 10 SP2 and SP3" ISSUE STOP-START of SUSE Linux VMs fail, as PV-bootl

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

2015-12-03 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1157 CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREATE event missing for usage_e… …vent by template sync thread If there is a Management server restart while template is in downloading

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-11-03 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/883#discussion_r43846616 --- Diff: scripts/vm/hypervisor/xenserver/logrotate --- @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2015-10-19 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/956 CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} guest OS mapping for vmware is n… …ot available You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

2015-10-19 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/955 CLOUDSTACK-8969 VPN customer gateway can't be registered with hostname When we have VPN customer gateway which is resolved by a hostname , we should be able to register the VPN cus

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-10-11 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/880#discussion_r41722125 --- Diff: setup/db/db/schema-452to460.sql --- @@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` ( UNIQUE KEY

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-11 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147233273 @remibergsma @koushik-das I have made the changes and have removed reimplementation of XenServer 6.0.2 resource. I have added changes to patch file for

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-06 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-146083023 @remibergsma @koushik-das For incorporating the change in XenServer600Resource, I need to test the change for Xenserver 6.0. After checking it for 6.0, I will

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-06 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-146081053 @koushik-das This bug exist in xenserver 6.0.2 and later. For XenServer 6.0, logrotation works. Thats is the reason i have implemented XenServer602Resource and

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-09-29 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/880#discussion_r40756846 --- Diff: setup/db/db/schema-452to460.sql --- @@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` ( UNIQUE KEY

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

2015-09-29 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/895#discussion_r40755936 --- Diff: server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java --- @@ -297,6 +297,7 @@ s_logger.debug

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

2015-09-28 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/895 CLOUDSTACK-8911: VM start job got stuck in loop looking for suitable … …host VM instance creation job get stuck in the loop, when VMs require local storage there are host that

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-09-28 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/880#discussion_r40543530 --- Diff: server/src/com/cloud/configuration/Config.java --- @@ -1999,7 +1999,9 @@ // StatsCollector StatsOutPutGraphiteHost

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-09-27 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143645025 @remibergsma Rebased against the current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

2015-09-27 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/892 CLOUDSTACK-8910: The reserved_capacity field increases suddenly after… … a vmware host failure In case of vmware host failure, all the VMs including stopped VMs migrate to the

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-09-26 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143478261 @remibergsma I didn't checked the PR #861. I was looking to fix the issue with xenserver 6.0.2 and higher. For this I have added a logrotate script and a

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-09-24 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/883 CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver After integrating XS with CCP the following folder gets created: /var/log/cloud/ however the logs in that ar

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-09-23 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/880 CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads The thread pool was hardcoded to use 8 threads, com.cloud.template.TemplateManagerImpl.configure(String, Map

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

2015-09-22 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/876 CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry… … for disabled host This causes VM deployment failure on the host that was disabled while addin

[GitHub] cloudstack pull request: CLOUDSTACK-8864: Not able to add TCP port...

2015-09-19 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/851 CLOUDSTACK-8864: Not able to add TCP port forwarding rule in VPN for … …specific ports Setting port forwarding rules for port 500,1701 and 4500 after enabling VPN, gives the

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-16 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/836#issuecomment-140687549 @bhaisaab, using service conntrackd status don't provide the status and always gives the usage information for conntrackd. So i have added the change

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-15 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/836 CLOUDSTACK-8863: VM doesn't reconnect to internet post VR RESTART/STO… …P-START/RECREATE The ongoing ICMP request reply session is broken when the VR is down, the expect

  1   2   >