Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139910486
@rafaelweingartner I committed and pushed the new changes. I also changed
the commit comment like you requested.
---
If your project is set up for it, you
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139927888
@resmo Do you know the reason for the 2 aborted messages above? Is there
anything I should do?
---
If your project is set up for it, you can reply
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139920903
@rafaelweingartner Okay so should I still squash the commits or leave it as
it is since it says the pull request has been merged and closed? Also I
received
GitHub user ashwinswaroop opened a pull request:
https://github.com/apache/cloudstack/pull/810
This is the fix for the JIRA issue CLOUDSTACK-8817.
This is my first contribution to Apache CloudStack. The return values for
endpoint and startpoint have now been changed to Integer
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139697149
Sorry for not changing the setter. I'm using eclipse now and I can see that
there is a FirewallResponse.java file in both cloud and cloudstack-api. Should
I
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139703362
Okay that makes sense. I went through the entire project and found only one
caller of setStartPort and setEndPort which was from the relevant
class(Firewall
