[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

2016-01-14 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171685523 @borisroman Because VARCHAR can handle 'most common' supported URL lengths perfectly fine. Most modern browsers have a limit somewhere around 2000

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

2016-01-14 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171659089 Should resolve problems with template extracts where the generated URL exceeds the 255 character limit. BTW: 2048 is somewhere in the middle of what

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155020178 @davidamorimfaria @borisroman Took the commit for a spin, looks like it does what it suppose to do. (Adding form elements when certain conditions are met

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155012289 The code looks fine to me. @DaanHoogland @borisroman I agree decoupling the UI from the main Cloudstack project would be the better choice. Development

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
GitHub user kevindierkx opened a pull request: https://github.com/apache/cloudstack/pull/670 Made interface changes related to CLOUDSTACK-8580 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevindierkx/cloudstack CLOUDSTACK

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/670#issuecomment-129381995 Looks like the changes to listCapabilities aren't merged yet. (@borisroman) Ignore this pull-request =D --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
Github user kevindierkx closed the pull request at: https://github.com/apache/cloudstack/pull/670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

2015-08-07 Thread kevindierkx
GitHub user kevindierkx opened a pull request: https://github.com/apache/cloudstack/pull/664 Removed leading tabs and trailing spaces from ui/scripts/*.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevindierkx/cloudstack

[GitHub] cloudstack pull request: Removed leading tabs and trailing spaces ...

2015-08-07 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/664#issuecomment-128695172 I've removed the above mentions of commented code. Should be all set. --- If your project is set up for it, you can reply to this email and have your reply