Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1561#issuecomment-221780495
Very small change , conversion of firewall port to string was not necessary
and that seems to be removed. Looks Good to me !!
---
If your project is set up
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-212892204
Done code review ,a part from the above comment , the code LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1304#discussion_r60570371
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-212886925
@sanju1010 Have done code walk through and LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1183#discussion_r60533545
--- Diff: test/integration/component/test_vpn_users.py ---
@@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):
self.fail
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1183#discussion_r60532757
--- Diff: test/integration/component/test_vpn_users.py ---
@@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):
self.fail
Github user pavanb018 closed the pull request at:
https://github.com/apache/cloudstack/pull/566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212753742
Have done the code review and LGTM !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-196152972
Doesn't seem to be much of a code(functionality) change. The changes made
in testdata.py LGTM !!
---
If your project is set up for it, you can reply
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-189116369
I have reviewed the code and it looks good to me as per the code review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1322#issuecomment-171271657
@DaanHoogland You will need two primary storage pools to test this , no
advanced setup is needed to test the script. The script will skip if there are
less than
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1322#issuecomment-171298675
The above configuration is good. No need to have two clusters
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1322#issuecomment-171534991
From the results it looks like , suitable pools for migration for the
volume returned no pools...
I too didn't look at the file in detail. If you have setup
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/1322
Automation for CLOUDSTACK-9217
This script automates the below functionality:
CloudStack should block migration to a Storage pool which is in maintenance
mode.
You can merge this pull
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1322#issuecomment-169954673
Test Results:
==
Trying to migrate a volume to a pool in maintenance mode should fail ...
=== TestName
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/1315
Automation for CLOUDSTACK-9214 , detect wrong GW or NM
Automation for CLOUDSTACK-9214
This script automates the validation of network address or broadcast
address given for gateway
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-142819336
An LGTM is given after going through the code and understanding what the
code is accomplishing. The PR already has the test results and if i am not
wrong an LGTM
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/683#issuecomment-142531937
The result of operation is captured in the list volume validation following
the call to query_async_job method. Hence didn't capture the return value of
call
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-142497091
@Desc: Test that Volume snapshot for root volume not allowed ... ===
TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS ===
ok
Sanju1010
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-141880475
The test Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/683
CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a
new VM
Attach multiple Volumes simultaneously to a Running VM ... === TestName:
test_attach_multiple_volumes
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129720549
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/581
Newb
Test Create/Delete a LB rule and verify correct usage is recorded ... ===
TestName: test_01_lb_usage | Status : SUCCESS ===
ok
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/581#issuecomment-121164744
Created an ACS ticket describing the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pavanb018 closed the pull request at:
https://github.com/apache/cloudstack/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/565#issuecomment-119905456
The changes Look Good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/569
Handling Basic Zone scenarios for starting VM in stopped state
Basic Zone result:
Test Deploy Virtual Machine with no startVM parameter ... === TestName:
test_01_deploy_vm_no_startvm
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/567#issuecomment-119841442
The commit looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/569#discussion_r34239937
--- Diff: test/integration/component/test_blocker_bugs.py ---
@@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
#all it's
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/241#issuecomment-119507984
All the comments in this PR are addressed and those commits are in PR 566
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/566#issuecomment-119533762
test_project_private_template
(integration.component.test_project_template.TestProjectPrivateTemplate) ...
=== TestName: test_project_private_template | Status
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/566#issuecomment-119533859
On Advanced Zone:
Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags |
Status : SUCCESS ===
ok
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/566#issuecomment-119533805
On Basic Zone:
Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags |
Status : SUCCESS ===
ok
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/566
Privtmpl
Comments provided in PR 241 are addressed and the commits for those are in
this PR.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user pavanb018 closed the pull request at:
https://github.com/apache/cloudstack/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/241
Automation for issue, Private template not visible in project for user
STEPS TO REPRODUCE:
Create an account and a user.
Create a project for that user.
Change view from default
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/241#discussion_r30032670
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,162 @@
+from marvin.codes import FAILED, PASS
+from
37 matches
Mail list logo
