Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259395
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixResizeVolumeCommandWrapper.java
---
@@ -48,6
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259959
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r98259432
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
---
@@ -436,7 +436,7
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1829
@rhtyd @koushik-das definitely a blocker IMHO. Being unable to start/reboot
a VM that has 3 volumes is unacceptable in a public cloud scenario
---
If your project is set up for it, you can reply
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1830
Oops, closed by accident
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1830
CLOUDSTACK-9677: Adding storage policy support for swift as secondaryâ¦
⦠storage
Added support to use storage policies with swift
You can merge this pull request into a Git
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1830
@syed Think you could take a look? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1858
Happy holidays!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1830
CLOUDSTACK-9677: Adding storage policy support for swift as secondaryâ¦
⦠storage
Added support to use storage policies with swift
You can merge this pull request into a Git
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@rhtyd Thanks for the speedy responses
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
@rhtyd Changed the PR to be against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1820
CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default
role when not found
https://issues.apache.org/jira/browse/CLOUDSTACK-9656
This is a workaround to avoid NPE
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1820
Ok will do, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1820
CLOUDSTACK-9656 Preventing autoboxing NPE in Usage by setting a default
role when not found
https://issues.apache.org/jira/browse/CLOUDSTACK-9656
This is a workaround to avoid NPE when
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1616
Added missing rules on router config, fixed ordering of multiple ruleâ¦
â¦s, removed duplicate rules, added fix for network stats, added a check
for b64 decoding (to pad incorrect b64). Also
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1611
Nice. LGTM, code reviewed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1611#discussion_r71037734
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -224,6 +225,16 @@ def createClusters(self, clusters, zoneId, podId,
vmwareDc=None
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1609
Excellent. @leprechau were you able to test the fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1609
[CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering
BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
The issue occurred because all of the ACL rules get
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1609
The issue was with the teardown of a snapshots test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1609
[CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering
BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
The issue occurred because all of the ACL rules get
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1609
[CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering
BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
The issue occurred because all of the ACL rules get
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@kishankavala I think that the ultimate fix will be in the VR. However, the
inversion of the list is fixed with this patch, and does not require a VR
update. This is a good enough fix for now, as
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
Thanks @dmabry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
The Travis build has timed out 3 times now. Is there any known issue with
Travis right now @swill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@remibergsma Yes, the rules should appear in the right order now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube Travis timed out, you may want to try the Travis Lottery again ;-)
Is this ready for testing?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1581#discussion_r65701961
--- Diff:
core/test/com/cloud/agent/api/routing/SetNetworkACLCommandTest.java ---
@@ -0,0 +1,34 @@
+package com.cloud.agent.api.routing;
--- End
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-213822378
LGTM. Do you think we should translate this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1476#issuecomment-213116347
Hey @remibergsma just noticed that you had a PR open for this. I fixed it
as well with #1505 so we might be able to close this one
---
If your project is set up
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1505#issuecomment-212950771
Screen shot from
[before](https://issues.apache.org/jira/secure/attachment/1250/Screen%20Shot%202015-12-15%20at%2015.32.12.png)
the fix
After
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1504#issuecomment-212587181
Pushing towards 4.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1505
CLOUDSTACK-9172 Added cross zones check to delete template and iso
Added a check to ignore the zoneid, in the delete template UI, if the
template is cross zones.
reference : CLOUDSTACK
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1504
CLOUDSTACK-9172 Added cross zones check to delete template and iso
Added a check to ignore the zoneid, in the delete template UI, if the
template is cross zones.
reference : CLOUDSTACK
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59812425
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59777518
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730927
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730334
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59730081
--- Diff: api/src/org/apache/cloudstack/acl/RoleType.java ---
@@ -16,18 +16,90 @@
// under the License.
package org.apache.cloudstack.acl
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644462
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644306
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209026629
Just trying to help get things merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209023846
@rafaelweingartner @swill The only thing changed was the unit tests, which
I ran. And the only code change he did was to remove useless variables. @swill
also gave
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-209017286
@swill this looks ready, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207537198
Simply added a log warning. Built it LGTM
[INFO]
[INFO] Reactor Summary:
[INFO
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207490720
Built the package LGTM after review
[INFO]
[INFO] Reactor Summary:
[INFO
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026874
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026830
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -1340,37 +1340,31 @@ public String getSerializedApiError(final
ServerApiException ex, final Map
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026583
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -223,10 +226,7 @@
private static ExecutorService s_executor = new ThreadPoolExecutor(10
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-203469470
I built, ran the unit tests and ran the server with the simulator. Thanks
for cleaning up! LGTM
[INFO
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-203437320
Hi @hogniRunar,
The code change LGTM. I verified for references to the function, but did
not test it. Could you create a JIRA ticket for it please? Could you
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203434250
Hi @GabrielBrascher
Travis noted:
Failed during checkstyle execution: There are 1 checkstyle errors.
Have you run *mvn validate* on your code
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1445#issuecomment-199858341
Built and ran the unit tests. LGTM
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration
SUCCESS [ 1.106 s]
[INFO] Apache CloudStack
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-179502626
Tested on local setup, the template.properties is now uploaded correctly
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176825081
LGTM Tested with a XenServer host and Swift as secondary storage. Got the
link and downloaded the template
https://cloud.githubusercontent.com/assets/2355044
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-175089677
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1369#issuecomment-175058378
Versions LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259649
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259430
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259249
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259089
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-172715155
Code LGTM, as a general comment though, I think it is cleaner to be as
precise as possible with exception handling.
---
If your project is set up for it, you can
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r50066929
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1135#issuecomment-172710149
@DaanHoogland np, I will close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1337#discussion_r50060205
--- Diff: ui/scripts/network.js ---
@@ -3667,8 +3652,16 @@
return 2;
//hide Autoscale
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50058474
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1342#discussion_r50058625
--- Diff: ui/scripts/ui-custom/instanceWizard.js ---
@@ -429,12 +427,52 @@
$step.find('.custom-size-
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057844
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057840
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-171666469
Code changes LGTM, looked in the UpdateVpnGatewayCmd and checked the
response name (it is 'updatevpngatewayresponse').
---
If your project is set up for i
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606982
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606572
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606475
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49605888
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604
Null check LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1281#issuecomment-166911537
lol @DaanHoogland . +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961
Shouldn't we log this information? Doesn't this mean that some resources
could be freed up on the hypervisor?
---
If your project is set up for it, you ca
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265
How do you know if there are no jobs associated with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1260#issuecomment-166691207
Did you try rebuilding CS with each type of event queue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48278591
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void
1 - 100 of 154 matches
Mail list logo
