[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213593763 First read-through didn't raise any eyebrows on my end. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166830690 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78251684 @bhaisaab now in apache/cloudstack-docs-admin#28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack-docs-admin pull request: Document Kafka event bus

2015-03-11 Thread pyr
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/28 Document Kafka event bus You can merge this pull request into a Git repository by running: $ git pull https://github.com/pyr/cloudstack-docs-admin feature/event-bus-kafka

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78245063 @bhaisaab yes, where is the repo ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78220517 @bhaisaab I made the topic configurable and provided some more explanation in the PR description. Thanks for the review. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78219876 @bhaisaab the producer has a thread which handles this and knows what broker is responsible for what partition, it maintains its own internal broker topology, so there

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread pyr
Github user pyr commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/109#discussion_r26194042 --- Diff: plugins/event-bus/kafka/pom.xml --- @@ -0,0 +1,45 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-10 Thread pyr
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/109 Add Apache Kafka event-bus support - producing only. This commit produces event bus messages to a "cloudstack" topic in Apache Kafka. Configuration is expected to be found in /etc/

[GitHub] cloudstack pull request: Support all pythons from 2.6 up.

2015-02-27 Thread pyr
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/89 Support all pythons from 2.6 up. These small changes allow the build to succeed on all versions of python from 2.6 up (2.5 will break). This covers all serious candidate platforms for running

[GitHub] cloudstack pull request: Use constant-time comparison functions wh...

2015-01-14 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/65#issuecomment-69926943 thanks @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Use constant-time comparison functions wh...

2015-01-14 Thread pyr
Github user pyr commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/65#discussion_r22930247 --- Diff: server/src/com/cloud/api/ConstantTimeComparator.java --- @@ -0,0 +1,36 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: Use constant-time comparison functions wh...

2015-01-14 Thread pyr
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/65 Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full

[GitHub] cloudstack pull request: Remove AWS api bridge

2014-12-01 Thread pyr
Github user pyr closed the pull request at: https://github.com/apache/cloudstack/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove AWS api bridge

2014-12-01 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/44#issuecomment-65030920 closing this since a new branch has been created by @runseb --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Remove AWS api bridge

2014-11-21 Thread pyr
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/44 Remove AWS api bridge This has been a discussion point for a while. The (mostly generated) code for the AWS api bridge is by far the largest source component in Cloudstack, while seldomly