Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1290
CLOUDSTACK-9202 Bump ssh timeout for VR commands
It seems the VR needs more time for some of its commands. Until we figured
out the root cause, this allows the VRs to start again
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167155923
@DaanHoogland Jenkins failed due to this (missing artifact). Any hint on
the cause?
```
Archiving artifacts
ERROR: No artifacts found that match the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-167148441
Nice work guys!
@nvazquez This will be merged to master, which is now at `4.8.0-SNAPSHOT`.
Can you please rebase with master, and move your SQL change
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-166888961
@pvr9711 Where is your LGTM based on? I'd like to see some background, as
otherwise we don't know what you tested / reviewed.
---
If your project is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/384#issuecomment-166888535
It was not merged, see also #720.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594
@bhaisaab Thanks, makes sense. Will test an upgrade and report back.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-166881123
@koushik-das Github cannot display large diffs. This is how you can show it
on your local checkout:
```
prId=1277
git checkout master
git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268
@pvr9711 Please make sure we have 2xLGTM of which at least one run the
test. Will not merge without.
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1249#issuecomment-166871427
@michaelandersen Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1249#issuecomment-166871327
@mandersen Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1268#issuecomment-166437027
Tested upgrade, works fine:
```
INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Grabbing lock to
check for database upgrade.
INFO
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1268#issuecomment-166436615
@pdube Indeed, as we speed up releases this becomes a real bottleneck. We
should handle db upgrades out of the repo. There was some discussion already.
Let&#
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1268
Set version 4.8.0-SNAPSHOT in master branch
- setnextversion.sh
- upgrade path to `4.8.0` via `4.7.0` -> `4.7.1` as this is the one set in
`4.7` branch. Then we also have the n
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166407832
Once this is merged (and fwd-merged to master, I will create the upgrade
paths for `4.8`.
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166407342
@DaanHoogland Jenkins failed, seems not related to PR. Is this y our
experiment?
```
FATAL: Unable to find coverage results
java.io.IOException
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166405759
Tested an upgrade from `4.7.0` to `4.7.1` and that works:
```
INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version =
4.7.0 Code
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1259#issuecomment-166401238
Hey @wilderrodrigues that's awesome! Would you mind pointing this PR to the
4.7 branch? I created it today and it finally got mirrored :-)
---
If your pr
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1267
Set version 4.7.1-SNAPSHOT in 4.7 branch
- setnextversion.sh
- upgrade path
Build succeeds:
```
[INFO
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166311506
And it works:
```
INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system
integrity checker com.cloud.upgrade.DatabaseUpgradeChecker
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166305178
@rafaelweingartner True story, the faster we release versions the harder it
becomes. It needs to be changed, preferably in a tool outside of CloudStack. We
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1265
Set version 4.6.3-SNAPSHOT in 4.6 branch
- setnextversion.sh
- upgrade path
Build succeeds:
```
[INFO
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1258#issuecomment-166112617
@nitin-maharana Thanks. Are there any other api calls that have the same
issue?
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-166087210
@andrijapanic Merge without testing and LGTMs? Really?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1249#issuecomment-165892090
Integration tests are OK:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1249#discussion_r47776850
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/checkrouter.sh ---
@@ -17,21 +17,20 @@
# under the License.
STATUS=UNKNOWN
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1247#issuecomment-165061200
@bhaisaab Thanks for fixing / improving this. Will have a look and test it.
Are you OK with handling this in 4.7.1 (due in say 2 weeks)? By that time 4.5.3
is
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1249
CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
Added quotes to prevent syntax errors in weird situations.
Error seen in mgt server:
```
2015-12-15 14:30:32,371
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1249#issuecomment-165060510
Ping @sspans @wilderrodrigues to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#discussion_r47476361
--- Diff: source/upgrade/_sysvm_templates_pre45.rst ---
@@ -18,8 +18,9 @@
Update System-VM templates
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#issuecomment-164388952
- Quota plugin, see PR 768 for screenshots.
- Nicira and Nuage plugins updated
- UI improvements
- >100 smaller bugfixes and improveme
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1239#issuecomment-164291346
@borisroman we should separate it from the CloudStack repo ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1239
build_asf.sh: fix debian changelog altering
The script already adds a new entry so we shouldn't replace the
previous one. That is done only in the next version script.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-164288191
@borisroman @DaanHoogland Let's ask someone to test whether HyperV is still
happy and then we'll know.
---
If your project is set up for it, you ca
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-164288018
For the sake of it, I run a some generic integration tests and they are
happy.
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164258629
Integration tests make no real sense, but tried a few to be sure:
```
Check the password file in the Router VM ... === TestName
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1234#issuecomment-16428
Ping @bhaisaab any chance to get this reviewed today? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438
The new script ends up on the router:
```
root@r-15-VM:~# cat /etc/logrotate.d/cloud
# Licensed to the Apache Software Foundation (ASF) under
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164254871
Before PR this was seen after log rotate:
```
root@r-996-VM:/etc# lsof | grep cloud.log.1
_plutorun 767 root 3w REG 202,10 26054919 71 /var/log
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164253007
@DaanHoogland There are many different solutions in place, some are
bash/python scripts that do `>/var/log/cloud.log` etc, some use `nohup` to keep
running
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164247329
Pinging @wilderrodrigues @fborn @DaanHoogland @borisroman to review.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1235
CLOUDSTACK-9155 make sure logrotate is effective for cloud.log
Many processes on the VRs log to cloud.log. When log rotate kicks in, the
file is rotated but the scripts still write to the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164201764
@milamberspace Are we good to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164194791
As discussed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164190196
Have discussed the upgrade paths with @DaanHoogland We are implementing
them as we speak.
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164186662
Update: this resolved our production problem. It now works fine in
master+this PR.
LGTM :+1:
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164177507
Update: Verified the same as above in our pre-production environment (aka
Employee Cloud). Will now deploy to production as it works as expected. When
the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164176585
@DaanHoogland Thanks. Deploying to a real cloud as we speak. Will verify
there too.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164174462
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164174368
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164174234
@borisroman I can't get it to run. It builds but after start it errors out
like this:
```
2015-12-12 10:01:33,843
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058
LGTM based on these tests (run on KVM):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164172595
First test results:
keepalived.conf looks as expected:
```
vrrp_instance inside_network {
state EQUAL
interface eth2
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164171363
Jenkins error unrelated to PR change:
```
Build timed out (after 120 minutes). Marking the build as aborted.
```
---
If your project is set up for
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164170827
LGTM based on the above tests. Makes no sense to run the same tests again
:-)
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1229#issuecomment-164170453
Ping @milamberspace to have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164170412
@bhaisaab nice suggestion! Not sure if it is needed though. The vrrp is
done over the first guest network, so it cannot clash with other router pairs.
Other
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164163749
You can read the following from man keepalived.conf:
```
# arbitary unique number 0..255
# used to differentiate multiple instances of vrrpd
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164163586
Thanks for the quick fix @wilderrodrigues.
Bit explanation: redundant routers worked fine in our 4.7 cloud, then all
of a sudden were broken. Root
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164151105
Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164146123
Ping @wilderrodrigues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431243
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431233
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1227#issuecomment-164138076
Example of merging PR 1221:
https://cloud.githubusercontent.com/assets/1630096/11761460/05e97f22-a0c4-11e5-8c4a-da8cf67c973e.png";>
---
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164137434
LGTM based on running the tests:
```
[root@cs1 integration]# cat
/tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt
Test create, assign
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1227
Show actual diff in commits after merge with git-pr / git-fwd-merge
This shows the diff in commits after using `git-pr` and `git-fwd-merge`
tools, like this:
```
44e8c92 Merge
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164132726
@syed Thanks!
@bhaisaab @DaanHoogland Do you guys know why this was put in? It was in the
original source import years ago.
---
If your project is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1211#issuecomment-164129115
LGTM based on the below test.
Original on current master:
- create domain, account and login
- create vpc
- create acl
- no option to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-164127282
Hi @nitin-maharana thanks for the info! I built a new cloud and still have
the issue that after creating a project it keeps loading forever (see image
above
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164126939
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1219#issuecomment-164125989
LGTM, I could still do all my deployments using Marvin. So, didn't test
this feature but did prove the existing functionality still works.
---
If your pr
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164125758
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1192#issuecomment-164125653
Jenkins error is unrelated to PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1192#issuecomment-164125511
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164021612
@wido please have a look:
```
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164019927
I have started the integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164015841
Hi @syed can you please squash the commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-164014731
LGTM, both offerings mentioned above are created fine:
```
[root@cs1 integration]# cloudmonkey
â Apache CloudStack � cloudmonkey 5.3.2
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163980980
@terbolous If you'd use a setup like that, you'd also use NAT in which case
it will still work. I think we're fine.
---
If your project is set
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163980356
Integration tests pass:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163977752
Not sure what happened, the test passes fine now. LGTM.
```
Test redundant router internals ... === TestName
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163908940
@terbolous I found an easier solution. When the public nic is on RFC1918,
we do not set the routes. When it is a real public ip, we can safely set the
routes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163905174
@terbolous OK, I see what you mean. Let me have a look and handle this
scenario.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163898820
Working console:
---
If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163578041
Integration tests are also OK:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-163570286
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169
LGTM, both users and admins can login with/without this plugin enabled.
User login with plugin disabled:
