Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820
@wilderrodrigues Testing this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-152161769
@wido I will also test it again today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152202839
Ping @bhaisaab you may want to backport this small fix to 4.5
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-152208509
@K0zka If you know of a fix for Tomcat6 we can merge that. Otherwise I
think we should consider reverting. We can wait a bit but if there is no
solution
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152208845
@serbaut If you think this should go into master, please comment LGTM
(Looks Good To Me) with any testing / verification you did. We need 2 LGTMs
before we can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-152201239
LGTM as well!
:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/927#issuecomment-152284702
@karuturi I tested the `test_vpc_site2site_vpn ` two more times, and it
keeps failing. The same tests on master succeeds and also on other branches I
recently
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152293339
Will run the tests again since the commit changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152282736
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968
Agree that the Jenkins failure is unrelated. Will soon merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-152300766
@borisroman Can you force push this PR please and rebase it with current
master? Then we can run some tests! Pinging @dahn to look at the code.
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152303070
@xenserverarmy Sure, it works. It's very easy, the files end up in
`/etc/xapi.d/plugins`. Are you able to verify yourself?
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1006#issuecomment-152306235
Thanks for the fix @nnesic ! Pinging @DaanHoogland @bhaisaab to review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152304547
@DaanHoogland @wilderrodrigues You can do this to test this PR:
```
./kvm_local_deploy.py -r xenserver65
/data/shared/helper_scripts/cloudstack
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/998#issuecomment-152106800
Will merge when Travis and Jenkins are green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-152106955
@serbaut Will merge when Travis and Jenkins are green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/999#issuecomment-152105724
This doesn't touch CloudStack itself, so I'm OK with merging this after
some extra pair of eyes. @runseb @terbolous can you please review?
---
If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-152113648
@borisroman FYI: I already started a test on this branch (which I rebased
myself first) and it doesn't look too good:
```
nosetests --with-marvin
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/927#issuecomment-152116250
Results of set of tests that I run on this branch (which I rebased myself
first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/929#issuecomment-152117456
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-152127233
@wido Please send a new PR with this commit, I tried merging it again but
that gives issues. We can proceed fast with this when you link the new one to
this PR
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-152127321
@wido Would be nice if the commit hash changed, so Github doesn't recognise
it as already being merged.
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-152118673
@ProjectMoon Thanks for the PR. I cannot judge the actual change you made.
I did run some generic tests and they seem to pass just fine
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/995#issuecomment-152119427
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-152120874
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-152137705
@terbolous To get started, we need people actually testing / reviewing this
and there also are some unaddressed comments. Testing this requires building
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151812042
@bhaisaab Maybe you can force push again, because it failed
(https://builds.apache.org/job/cloudstack-pull-analysis/1031/). probably not
related to what you did
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151841925
Hi @insom It might be rotated already. Usually when you force push your
commits to the branch again, Jenkins will notice this and run again. I think
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-151804656
@pdube @pdion891 Could you please look at this PR? Would be nice to include
it soon.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151843525
Hi @serbaut Did the deployDatacenter.py actually work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151804289
@ustcweizhou Can you please rebase against current master (and resolve
conflict)? Thanks!
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-151832340
@wido Thanks for working on this, awesome!
I was testing this PR and found that the SSVM and CPVM systemvms do not
start properly. This is the error
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151836687
LGTM, tested on `CentOS 7` and the logrotate file gets properly installed:
```
[root@kvm1 logrotate.d]# pwd
/etc/logrotate.d
[root@kvm1
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151805630
@bhaisaab Thanks, can you please make Jenkins happy? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-151838470
Hi @wido :
SELinux is off:
```
[root@kvm1 channel]# getenforce
Permissive
```
The generated XML:
```
2015-10-28 13:02
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151845449
@serbaut Sorry to hear that! Good that the deploy actually works. I'm not
using DevCloud so I cannot help with that. I do know that I have no issues
running
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151879029
Hi @Insom, Jenkins succeeded, see:
https://builds.apache.org/job/cloudstack-pull-analysis/1034/ There is a
different job with a slightly different name
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151936598
@borisroman Can you please review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151936406
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/991#issuecomment-151940210
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-151939066
@borisroman Isn't there already another process logging to
`/var/log/cloud.log` ? Will this work properly if multiple processes write to
it at the same time
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-151993024
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-151993447
@bvbharatk we are almost ready to merge. Could you please respond to the
comment made by @wido? Thanks!
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-151792666
FYI,run a set of tests that on this branch (which I rebased myself first),
just to make sure no existing functionality is broken by this PR. Looking good
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/895#issuecomment-151794288
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-151795514
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151798263
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/979#issuecomment-151798750
LGTM, test runs fine:
```
=== TestName: test_deploy_vm | Status : SUCCESS ===
=== TestName: test_deploy_vm_multiple | Status : SUCCESS
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151801262
@michaelandersen can you review this please?
@insom Travis failed, please investigate or push again. Thanks!
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/996#issuecomment-151803068
@karuturi Thanks! Will test soon :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/984#issuecomment-151455654
Thanks for the update @milamberspace !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151455578
@pvr9711 There are so many things to do for 4.6, do you really want _me_ to
send a PR for moving a file? Please send it yourself, and both @miguelaferreira
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/978#issuecomment-151487786
@borisroman Can you review this again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151489464
pinging @wilderrodrigues to have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151489875
@rodrigo93 it helps when running the tests. But never mind, I will rebase
myself and then run the tests :-)
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-151475559
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/979#issuecomment-151476883
@borisroman If you make Jenkins happy, I'll try to run this test as well ;-)
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-151037118
@miguelaferreira Can you please have a look why both Travis and Jenkins are
unhappy again? Thx!
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/894#issuecomment-151130113
LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151182430
I will test if renaming the plugin works (and make sure there are no links
to its name).
---
If your project is set up for it, you can reply to this email
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/982
Rename xapi plugins for s3 and swift to make them work after renaming the
calls
Make renaming introduced in a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 work
for S3 and Swift xapi plugins
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-151213457
@pvr9711 Can you please share the test results or explain what you did to
test?
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151206019
New PR #982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-151028340
OK @mike-tutkowski thanks! I'll merge this now so you can build it from
master. Please let us know if you still have issues, as I'd love to resolve
those
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-151028024
Just talked to @karuturi and we think we should merge this now and look
into the remaining VMware issue (as reported bu @mike-tutkowski) as a separate
issue
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-151027065
@mike-tutkowski currently only RM can merge, so I'll do that once the
criteria are met. I need 2x LGTM and some tests run on this branch. So far, I
see only
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150946842
@DaanHoogland Could you please do a code review of this PR? Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150947060
@DaanHoogland Could you please paste the nose command you run and the
output. Thanks!
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/849#issuecomment-150948113
LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/976#issuecomment-150948580
LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-150948753
Hi @kansal Can you please rebase this with current master? I tried running
some tests but face old problems. Also, what about the db migration script to
fix old
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/894#issuecomment-150948834
@sudhansu7 Can you please rebase with current master so I can run some
tests? Thanks!
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150965104
Pinging @snuf to respond to the comment here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-150966983
@KrisSterckx Please rebase against current master. That will allow me to
run some tests once @jburwell reviews the changes. Then we'll have to discuss
when we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-150967148
Hi @rodrigo93 can you please rebase against current master? Then I can run
soms tests. Thanks!
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150836024
Hi @nitin-maharana can you please rebase with current master? I'd like to
test your patch. Thanks!
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-150820547
@sspans Can you review this xenserver logrotate change please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150836618
@ustcweizhou Can you please rebase with current master so I can test this?
Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r42936389
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150835745
Thanks @rodrigo93, please also rebase with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/924#issuecomment-150836950
Pinging @borisroman @michaelandersen to review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-150834484
Thanks for the fix @K0zka !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/921#issuecomment-150836992
@yvsubhash can you please respond to the comments and also rebase with
current master please?
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/899#issuecomment-150838585
@yvsubhash Please squash the commits and rebase with current master, thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-150838537
@sanju1010 Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/896#issuecomment-150838644
@michaelandersen can you please review this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838920
@michelandersen can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/864#issuecomment-150838798
@bvbharatk Can you please rebase this against current master so I can run
some tests? Let mw know if you need help!
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-150834389
LGTM, I also see the sessionid no longer there:
```
[root@cs2 cloudstack]# curl -v 192.168.22.62:8080/client/ >/dev/null
* About to conn
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-150837929
@sarathkouk For my understanding, is this the integration test for the
feature @karuturi recently developed in #755 ?
For the sake of it, please force
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/822#issuecomment-150839334
Hi @DaanHoogland LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-150836810
Hi @atrbgithub Thanks for your response. We indeed need to reimplement your
fix on current master. Once that is in place and tested, we merge it on master
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-150838491
@nitin-maharana Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150832830
LGTM, based on a set of tests that I run on this branch (on a KVM cluster):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838939
@insom Please rebase against current master so we can run some tests.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
701 - 800 of 1275 matches
Mail list logo
