[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan test centos6 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 Addressed all the changes suggested and rebased against latest master. - Used CollectionUtils.isEmpty() as suggested. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1257#discussion_r90532049 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -138,6 +142,8 @@ @Inject

[GitHub] cloudstack issue #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1248 This PR is no longer valid since #1257 replaces this. Closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti closed the pull request at: https://github.com/apache/cloudstack/pull/1248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/828 @rhtyd Changed base branch to 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-11-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/828 @rhtyd Rebased against lastest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2016-11-30 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 Addressed all the changes suggested and rebased. With vSphere 4.0/4.1, when the ports per dvportgroup is set to less than 256 (current default), then it is set to the default 256, else

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-02-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-181232447 @resmo Shall I close this PR (as #1257 replaces this one)? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

2015-12-22 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1256#issuecomment-166815006 @bhaisaab Got this exception on VM power sync when router is migrated back (due to a DRS rule set for VMs together) after manual migration from CCP. During

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-18 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165715666 @resmo ok sure. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165412102 @resmo, You mean findOldestExistentHypervisorHostInCluster. I'm OK with it. Shall I create new PR without all these merges? --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165414155 @resmo Sure. I'll do that. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1257 CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. Summary: When a new host is added to a cluster, Cloudstack doesn't create all

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165547302 @resmo Raised a clean PR: https://github.com/apache/cloudstack/pull/1257. Shall I close this one? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...

2015-12-16 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1253 CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards Modify the default value of this setting, which is currently 256

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165339578 @resmo, Out of all the running hosts present in the cluster, the port groups are fetched from the host which was first added to the cloudstack, assuming

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

2015-12-16 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1256 CLOUDSTACK-9185: [VMware DRS] VM sync failed with exception due to out-of-band changes Summary: The target "ClusteredVirtualMachineManagerImpl.HandlePowerStateReport" invo

[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...

2015-12-16 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1252 CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance. CLOUDSTACK-9182: Some running VMs turned off on manual

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1248 CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. Summary: When a new host is added to a cluster, Cloudstack doesn't create all

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-12-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/830#issuecomment-162493826 @ustcweizhou , Same with my result set as well. mysql> select * from vm_instance where state is null; Empty set (0.00 sec) mysql> SEL

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-12-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/830#issuecomment-162483571 @DaanHoogland , @ustcweizhou This issue is reproduced when the volume associated vm instance has null or invalid state (vm_state in volume_view

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-12-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/830#issuecomment-162494808 The volumes, in Ready state and are not attached to any VM have their vm_state has null and querying such volumes may result in NPE. These changes are only

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-12-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/830#issuecomment-162612642 @ustcweizhou , Yes. I agree. In case on instance id, vm_state is not null. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-7151: Support multiple physica...

2015-09-21 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/862#issuecomment-142004394 Tested database upgrade and updated API cmds addcluster and updatecluster to support multiple physical networks at cluster level. --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-7151: Support multiple physica...

2015-09-21 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/862 CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments. CLOUDSTACK-7151: Support multiple physical networks at cluster level

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-18 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-141356708 @bhaisaab @sateesh-chodapuneedi Update code as per the existing conventions. Please check. Working on the unit test. Thanks. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-09-16 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/834#issuecomment-140641999 Reschedule time is always based on the work type. Code changes are OK. LGTM. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-16 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39624157 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/828 CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in ESXi hypervisors CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in ESXi hypervisors

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-140369704 @sateesh-chodapuneedi These changes were successfully tested on Apple hardware. When a VM is created with guest OS as Apple Mac OS, the USB controller (EHCI

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-09-15 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/830 CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE. CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE. Summary: listVolumes API fails

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-14 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140009394 @remibergsma That sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-14 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39372846 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -152,13 +152,26 @@ public void connect(String url, String

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-14 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39377834 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-14 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/806#discussion_r39378030 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java --- @@ -577,41 +590,48 @@ public ManagedObjectReference

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-11 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/806 CLOUDSTACK-8820: Showing error when try to add vCenter 6 CLOUDSTACK-8820: Showing error when try to add advance zone using VMware ESXi 6.0 host Summary: In vCenter 6.0, response

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

2015-07-24 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-124468346 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

2015-07-24 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/548#issuecomment-124476270 Code changes to update the volume chain info are perfect. --- If your project is set up for it, you can reply to this email and have your reply appear

<    1   2