[GitHub] [cloudstack-primate] rhtyd commented on issue #73: [WIP] Project: Project View and Actions

2019-12-25 Thread GitBox
rhtyd commented on issue #73: [WIP] Project: Project View and Actions URL: https://github.com/apache/cloudstack-primate/pull/73#issuecomment-568925865 @utchoang LGTM, can you address the following issues in this PR and other PRs: - Whenever any action/button needs to be added in a custom

[GitHub] [cloudstack-primate] rhtyd commented on issue #73: [WIP] Project: Project View and Actions

2019-12-24 Thread GitBox
rhtyd commented on issue #73: [WIP] Project: Project View and Actions URL: https://github.com/apache/cloudstack-primate/pull/73#issuecomment-568690453 @utchoang it's possible that some list APIs don't honour or implement the keywords based searching, in which case you may file a bug here:

[GitHub] [cloudstack-primate] rhtyd commented on issue #73: [WIP] Project: Project View and Actions

2019-12-22 Thread GitBox
rhtyd commented on issue #73: [WIP] Project: Project View and Actions URL: https://github.com/apache/cloudstack-primate/pull/73#issuecomment-568371192 Hi @utchoang ignore my last comment around the projectid/input type. But follow my last change (around handling changing resource to handle

[GitHub] [cloudstack-primate] rhtyd commented on issue #73: [WIP] Project: Project View and Actions

2019-12-20 Thread GitBox
rhtyd commented on issue #73: [WIP] Project: Project View and Actions URL: https://github.com/apache/cloudstack-primate/pull/73#issuecomment-567946661 Overall LGTM, except for few edge case issues (like refresh inside project resource view fails when account tab is opened). It needs a bit o