Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1282
@anshul1886 I've left a comment, the code to check and remove snapshot on
allocated state is already in that method?
---
If your project is set up for it, you can reply to this email and have
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1282
@swill @rhtyd can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1282
### ACS CI BVT Run
**Sumarry:**
Build Number 446
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1282
@swill Added the return true statement. @rhtyd Snapshot in Allocated state
means nothing is done for that snapshot so only deletion from DB is needed.
---
If your project is set up for it,
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1282
@Slair1 Its missing required reviews and tests.(We have a huge backlog. any
help in code review/test run is welcome). please refer to
Github user Slair1 commented on the issue:
https://github.com/apache/cloudstack/pull/1282
@anshul1886 any idea why this hasn't been merged yet? are there
concerns/issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
