[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-20 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 There have been a couple issues that have been reported on `master` so I don't expect the RC to be cut right away as we sort out those problems. I will probably merge this and we can then continu

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-20 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1547 ### ACS CI BVT Run **Sumarry:** Build Number 202 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _Link to logs Folder (search b

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-19 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 Great, if the RC is cut we can test that better. I'm about to leave on a 2 week holiday however. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-19 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1547 ### ACS CI BVT Run **Sumarry:** Build Number 195 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _Link to logs Folder (search b

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-18 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1547 ### ACS CI BVT Run **Sumarry:** Build Number 192 Hypervisor xenserver NetworkType Advanced Passed=72 Failed=1 Skipped=3 _Link to logs Folder (search b

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-14 Thread NuxRo
Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1547 +1 merging, I'm also interested in this if it affects Advanced zone + Security Groups. Will test ASAP. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-14 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 @ustcweizhou I can't wait forever on this. What I will likely do if I don't hear back from you is merge this and then cut the RC right away. I am hoping to cut the RC tomorrow, so if you can give

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-13 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 @ustcweizhou can you review this PR please. I think we are ready on this one and since it fixes issues on master I would like to get it in before I cut the RC. Thanks... --- If your project is

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-12 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 @swill Pinging @ustcweizhou again, I know leaseweb has an interest in this. They use advanced zones in several different setups so their ok is a good indication we can merge (together with

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-12 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 @swill: Yes, LGTM from me. But @The-Loeki and I tested this together, so I would prefer more LGTMs, but also want this bug fixed :) --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-10 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 @wido judging from your testing and commentary, I believe this has your LGTM? You have not officially specified that it does. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-10 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 @swill I agree, but that's also because this bug is hitting and hurting us. However, I need other people to say LGTM :) --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-09 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 BTW, these tests results are for the following tests ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=basic \ component/test_deploy_vm_userdata_multi_nic.py \

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-09 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 I ran the same network tests I mentioned above against master and I had the following results. ``` Tests Run: 24 Skipped: 0 Failed: 8 Errors: 2 Duration: 2h 35

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-09 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 Here is a run against advanced networking. I am trying to test a bunch of basic zone networking tests, but I had never previously verified if they were broken. I have run them against thi

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-09 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 4h 00m 38s ``` **Associated Uploads** **`/tm

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 Should this set of test have the "basic" tag? It only has the "sg" tag, which I am not targeting. `/Users/swill/Dropbox/code/cs/cloudstack/test/integration/component/maint/test_multiple_

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 Thanks for the feedback @remibergsma and @swill ! Hopefully the results come back positive. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 The tests run against basic networking hardly test the functionality of the network though. Apparently most of the tests for the network are only for advanced networking. I will run agai

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 Can you also run one against advanced please @swill? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 The above is a test against basic networking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1547 ### CI RESULTS ``` Tests Run: 22 Skipped: 1 Failed: 0 Errors: 0 Duration: 0h 32m 39s ``` **Associated Uploads** **`/tm

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 @wido FYI all Python code is shared between basic/advanced and router/vpc so it's important to test both. Will try to look into it again in the next days. Not saying it's broken, just want t

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 @remi: Thanks for the feedback! @DaanHoogland reported a failure as well, but his second test succeeded without any problems. I don't have experience with VPC, but as far as I can tell this

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-08 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 I see some tests failing on VPCs: ``` test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL test_02_redundant_VPC_default_routes ``` Will rebuild from scratch to see i

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-07 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 Ok, thanks @DaanHoogland , sounds good! Looking forward to more input or LGTMs :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-07 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 Yes @wido ,they look good to me but I am not running a cloud at the moment so hence I asked @ustcweizhou to have a look. He had concerns but I did not see him react since. The test I

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-07 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 Thanks @DaanHoogland for the tests! So it seems that the code looks OK to you? I just force pushed so Travis should trigger again. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-06 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 CI Results: ok one test failed but retest manually succeeded [1547.results.network.txt](https://github.com/apache/cloudstack/files/300726/1547.results.network.txt) [1547.result

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 Awesome @DaanHoogland ! As said, this is a problem currently on 4.8 when using multiple ranges inside a pod VLAN. I/we can't find any issues with the changes made by @The-Loeki , so additi

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-06 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 @wido, I am not in favour of squashing these. They seem to be different fixes with their own history. I will start an integration run. --- If your project is set up for it, you can reply t

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-03 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 @swill: Before we start squashing all these commits can we get a CI run on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

2016-06-02 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1547 I spend some more time testing this. After the latest commits from @The-Loeki it all seems to work: * Virtual Router listens on all addresses * Apache is configured properly * DHCP