[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 @rhtyd, in my opinion the two commits are functionally separate enough that they should remain separate (and this might have been asked for in one of the various previous incarnations of

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1559 Thanks @ProjectMoon can you squash your commits. @murali-reddy @abhinandanprateek can you help review this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Addressed the comments. For some reason the tests for VolumeDataFactoryImpl were being skipped. Will try to see why. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Updated to latest 4.8. Will also address the comments too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-20 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1559 @ProjectMoon can you fix the conflicts, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-12 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Looks like Travis worked this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-12 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 The OOBM power off test keeps failing. I've run the test locally with the simulator and it succeeds fine. Going to try to kick Travis again to see if it works (third time's the charm?).

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-07 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 This pull request has been updated with another commit that fixes a bug where volumes cannot be expunged because the loading of the volume fails to find a primary data store (despite the

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-08-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Updated to latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-06-11 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1559 ### ACS CI BVT Run **Sumarry:** Build Number 186 Hypervisor xenserver NetworkType Advanced Passed=68 Failed=5 Skipped=3 _Link to logs Folder (search