Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much
appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
LGTM. Few failures are related to env, merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Trillian test result (tid-422)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27764 seconds
Marvin logs:
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd I am afraid, the newly added integration test takes well beyond 20
mins (Ran 4 tests in 6729.698s in the previous run, refer earlier comments for
more details) to run all its
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Packaging result: âcentos6 âcentos7 âdebian. JID-241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@nlivens @prashanthvarma can the new integration test be moved to smoke
tests if this does not take a lot of time (say more than 20 mins)? I'll kick
some tests.
---
If your project is set up
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
LGTM - based on our Internal regression testing and code review on the
latest code in this PR.
@rhtyd @jburwell
---
If your project is set up for it, you can reply to this
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd @jburwell I have briefly investigated the above failed tests
"test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL" and
"test_oobm_enabledisable_across_clusterzones", here are my
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Packaging result: âcentos6 âcentos7 âdebian. JID-216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell I have squashed all the commits in this PR into one logical
commit as suggested by you.
Moreover, I have briefly investigated the above failed test
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Trillian test result (tid-345)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27721 seconds
Marvin logs:
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@prashanthvarma please squash all commits down into one logical commit for
the enhancement. Multiple commits for the same feature muddy the long term
history.
---
If your project is set up
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Packaging result: âcentos6 âcentos7 âdebian. JID-162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd The previous Jenkins failure was due to missing solidfire
plugin dependency.
I have re-based this PR with latest master, and we now only have two
commits (1
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@prashanthvarma @nlivens can you please investigate the Jenkins failures?
Once Jenkins and Travis go green, I will kick blueorangutan to regression test
this PR.
---
If your project is set
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
the Marvin test commits.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here.
Moreover, we can re-run the added Marvin tests and share the results after the
re-base.
Generally, we have two
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@nlivens I can help run tests on this if you can squash your changes,
thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@nlivens I would like to get this PR merged for 4.10.0.0. I will code
review in the next few days. In the meantime, please rebase this PR to pick up
the latest Marvin enhancements/fixes and
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Added Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150
test/integration/component/test_vpc_network_internal_lbrules.py
33 matches
Mail list logo
