Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
This is looking good. I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 3h 58m 45s
```
**Associated Uploads**
**`/tm
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
It is easier for you to just close and reopen, so that is usually the
method people use. You can force push as well, either work...
---
If your project is set up for it, you can reply to this em
Github user KrisSterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill, you prefer i close and reopen? Thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
Thank you. I am currently running CI on it as well to make sure it comes
back clean. Hopefully we can get travis clean as well with a close and reopen.
---
If your project is set up for it, you
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill Yes, this is a bug in current master, and IMHO is a candidate to be
merged into the frozen master to be released in 4.9.
Note: As of know, there have been two code reviews
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
This fixes a bug in the current master right? I suspect this is a
candidate to be merged into the frozen master to be released in 4.9?
Please close and reopen this PR or force push to kic
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
Marvin Test Run:
CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg
/test/integration/plugins/nuagevsp
Marvin Test Results:
Test user data and password reset fu
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@nlivens Ah, I was not aware that that's how it works for network plug-ins.
The code LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
PR contents:
1) Fix for this bug
2) Marvin test coverage for Nuage VSP device CRUD operations including
verifications for this bug fix.
PEP8 & PyFlakes compliance of the a
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1585
The Java code fix seems good to me, never hurts to check for NULL, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user nlivens commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@mike-tutkowski, pinging you because I made changes upon your recent merge
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
12 matches
Mail list logo
