[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 LGTM @ProjectMoon can you push -f, the Jenkins build failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1607 changes looks good. It would be great if a test case can be added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1607 Indeed, looke good to me, is there a simple way to test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 Testing is a bit difficult without running a local web server (which I think is overkill for a unit test). Maybe a test at the integration level (Marvin) would work? Also, closed an

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1607 Yes, I agree, hard to test this one with a Unit Test. Code changes look good to me. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 Looks like all checks have passed successfully now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 Rebased to the latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 @ProjectMoon can you close/open the PR to re-kick Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1607 Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1607 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 Nevermind @blueorangutan the jenkins job died due to git/github related errors: error: index-pack died of signal 15 fatal: index-pack failed I'll kick it again --- If your projec

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1607 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1607 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 LGTM. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1607 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1607 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 This one hasn't been rebased in quite a while, so the packages produced will be rather old. Going to rebase this against latest master. --- If your project is set up for it, you can reply t

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1607 @ProjectMoon this seems like a really good fix for LTS users as well. Could you please rebase and change the base branch to 4.9? --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 Closed in favor of #1746. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a