Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1607
LGTM @ProjectMoon can you push -f, the Jenkins build failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1607
changes looks good. It would be great if a test case can be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Indeed, looke good to me, is there a simple way to test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Testing is a bit difficult without running a local web server (which I
think is overkill for a unit test). Maybe a test at the integration level
(Marvin) would work?
Also, closed an
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Yes, I agree, hard to test this one with a Unit Test.
Code changes look good to me. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Looks like all checks have passed successfully now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Rebased to the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1607
@ProjectMoon can you close/open the PR to re-kick Travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1607
---
If your project is set up for it, you can reply to this email and have your
re
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Nevermind @blueorangutan the jenkins job died due to git/github related
errors:
error: index-pack died of signal 15
fatal: index-pack failed
I'll kick it again
---
If your projec
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1607
---
If your project is set up for it, you can reply to this email and have your
re
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1607
LGTM.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1607
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Packaging result: âcentos6 âcentos7 âdebian. JID-75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1607
This one hasn't been rebased in quite a while, so the packages produced
will be rather old. Going to rebase this against latest master.
---
If your project is set up for it, you can reply t
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1607
@ProjectMoon this seems like a really good fix for LTS users as well.
Could you please rebase and change the base branch to 4.9?
---
If your project is set up for it, you can reply to this em
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1607
Closed in favor of #1746.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
17 matches
Mail list logo