Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Hi @milamberspace, sorry for my late response, I'm out of work this week
but please let me know if there's something I can do to help.
---
If your project is set up for it, you can reply to
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd @jburwell @karuturi What is the easiest way to resolve this merge
conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@serg38 Root cause of the issue found.
In the 4.9.1.0 branch, the commit 2e77496601ab5420723ce8b955b3960faaba7d5c
(CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS version
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Can you check if file
/usr/share/cloudstack-management/setup/db/schema-481to490.sql in your
installation has the SQL alter image_store_details table line ?
---
If your project
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@serg38 My CS 4.9.1.0 installation is a fresh installation not an upgrade
from 4.8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@milamberspace Column details is supposed to be added during 4.8 to 4.9
schema upgrade. Most likely when you upgraded to 4.9 this PR hadn't been merged
yet. You can simply apply this statement
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Hello @nvazquez
Could you see this bug CLOUDSTACK-9671 It's related with this PR and
CLOUDSTACK-9438
Thanks
---
If your project is set up for it, you can reply to this
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
reran the test for delete account and it passes.
`Test for delete account ... === TestName: test_delete_account | Status :
SUCCESS ===
ok`
merging this PR now
---
If your project
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1615
### ACS CI BVT Run
**Sumarry:**
Build Number 125
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=6
_Link to logs Folder
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1615
### ACS CI BVT Run
**Sumarry:**
Build Number 124
Hypervisor xenserver
NetworkType Advanced
Passed=98
Failed=4
Skipped=6
_Link to logs Folder
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Trillian test result (tid-193)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25817 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Trillian test result (tid-191)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30139 seconds
Marvin logs:
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1615
### ACS CI BVT Run
**Sumarry:**
Build Number 123
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=6
_Link to logs Folder
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@karuturi a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
ok. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@karuturi tests are about to finish
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd any update on the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@karuturi there was a capacity issue at the backend, the tests have been
re-fired.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan @rhtyd any update on the tests? Is the job running?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1615
### ACS CI BVT Run
**Sumarry:**
Build Number 117
Hypervisor xenserver
NetworkType Advanced
Passed=18
Failed=3
Skipped=2
_Link to logs Folder
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@karuturi a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@koushik-das please see [this
thread](http://markmail.org/thread/xp7ckhxhip2rbnr7) regarding the testing
freeze discussion. Also, per our [community release
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell Was there a discussion thread for this on dev@, didn't remember
seeing one which mentions about freezing master.
These issues of test stability are known and were raised
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@koushik-das I would encourage you to discuss your concerns/perspective on
dev@ in order to allow us a community to find consensus.
There is never a good time to embark on such a
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Thanks for the update @jburwell. While I agree that smoke tests needs to be
stabilized, I don't quite agree to the idea of blocking master for this.
Lot of commits have already gone
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@koushik-das all merges remain on hold until the smoke tests are
stabilized. I will be updating the list shortly on status and next steps. In
short, #1692 and associated PRs should be moving
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell @karuturi I haven't heard anything so assuming that this is good
to get merged.
I checked #1692 and all fixes (test and code) are related to network
related functionality. So
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
I think this has all the necessary LGTMs.
@karuturi @jburwell Should I go ahead and merge this?
I thing fixing #1692 is fine but I see no reason to delay other PRs for
that when
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
LGTM for code review. We are currently investigating failures on #1692
which is intended to clean up a number of smoke test failures. Once we have
those issues resolved, this PR can be
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell I refactored added marvin test based on your comments. I think I
shouldn't have squashed commits before pushing because now I can't mark them as
solved, but replied on those I've
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Yes LGTM from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Packaging result: âcentos6 âcentos7 âdebian. JID-33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@koushik-das are you LGTM on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd can you add the configuration data to blueorangutan for the changes
to `test_ssvm.py`?
@serg38 @nvazquez once my review comments are addressed and blueorganutan
has been
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell @karuturi @rafaelweingartner Can you check if this PR can be
merged by the upcoming release?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell This PR is waiting for your review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez I will review the test case in the morning. In the interim,
please squash your commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell @koushik-das I added new marvin test. It requires adding
"nfsVersion" key and desired value on config file, if it is not provided test
is skipped
---
If your project is set up for
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@koushik-das Yes, an integration test is in the works. I will post results
here in few days
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez @serg38 From last comment looks like there is some open item
related to marvin tests. Can you please address it?
---
If your project is set up for it, you can reply to this email
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell Support for NFS version for Secondary storage is already merged
via PR 1361. Since there were integration tests developed and executed over
there we seem to be needed tests only for
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez could you please add Marvin test cases to verify the new API
behavior? The tests should not only verify that the endpoints return the
versions expected, but that the storage pools
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@serg38 @nvazquez the code seems ok.
Is there anything pending with the _blueorangutan_ test?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell Are there any outstanding issues with this PR? It is waiting for
second LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1615
Job ID-74
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan package
@jburwell @nvazquez since a new code commit was made, we need to call
package before we could kick in tests.
---
If your project is set up for it, you can reply
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell the test pipeline had issues, I'll rekick it once I can get the
issues sorted. For now, only package works without any issues. We also
found/fixed a blocker that failed all of our kvm
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell I understand these comments: "help", "hello", "thanks",
"package", "test"
Authorized contributors for kicking Trillian Jenkins test jobs are:
['rhtyd', 'jburwell',
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@jburwell a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests against packages at
http://packages.shapeblue.com/cloudstack/pr/1615
---
If your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Sure, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez thanks for updates. The Jenkins build failed. It appears to be
due a timeout. Could you please force a rebuild by executing ``git commit
--amend --no-edit && git push -f``?
---
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Done, thanks @jburwell for your review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez looking good. One small item on the ``checkstate`` comment.
Also, could you please squash your commits?
---
If your project is set up for it, you can reply to this email and have
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1615
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
A Trillian-Jenkins job has been kicked to build packages and start testing.
I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan kick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Alright, your PR did not break packaging! Packages built and available at:
http://packages.shapeblue.com/cloudstack/custom/github-1615
---
If your project is set up for it, you can reply
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Ping for second review -- @GabrielBrascher, @rhtyd, @wido,
@rafaelweingartner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Thanks @koushik-das!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
68 matches
Mail list logo