Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell looks like @rhtyd already tested this. Do you need another
testing? I am currently setting up my env
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@syed we received the LGTMs necessary overnight. Thank you for helping out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Based on the tests and review. I'll proceed with merging this and fwd-merge
this across 4.9, master branches.
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on master branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0, upgrade from 4.9.1.0
- Clean db deployment
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on 4.9 branch (after fwd-merge), all pass:
- Upgrade from 4.8.2.0 to 4.9.1.0
- Clean fresh db deployment
---
If your project is set up for it, you can reply to this
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1654
LGTM, I've stated management and the DB got updated to 4.8.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Tests on 4.8 branch, all pass:
- Clean db setup works, last upgraded version to 4.8.2.0.
| 17 | 4.8.1 | 2016-09-01 09:56:21 | Complete |
| 18 | 4.8.2.0 |
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Given Travis has passed with 2 LGTMs and test LGTM, I'll go ahead and merge
this after testing this across 4.8->4.9, 4.9->master.
---
If your project is set up for it, you can reply to this
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Looks good on code review
here is my LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@syed per our conversation on Slack, the following is the test procedure to
verify this PR:
1. Create a fresh install 4.8.1. Since we are verifying the database
upgrade, the install
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell I've fixed the issue failing db upgrade, it was a minor
comparison issue in the beginning of the upgrade process. On my local env the
upgrade worked as expected. LGTM.
---
If your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@rhtyd I have updated this patch to properly support four position version
numbers, as well as, remove the requirement that all versions have a
``DbUpgrade`` class defined and/or an upgrade
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell changing code version (in pom.xml) to 4.8.2.0-SNAPSHOT is a valid
change, but due to the way our db upgrade path works please revert the change
on db upgrade path names and string
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@rhtyd I have updated this PR to reflect version being 4.8.2**.0** rather
than 4.8.2. I also added empty migration scripts to maintain consistency with
previous releases (e.g. 4.8.1). Could
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell I've added an empty upgrade path. Tested the db upgrade locally.
LGTM.
When you fwd-merge on 4.9 use: `git merge -X ours 4.8` to avoid fixing
merge conflicts in pom.xm files by
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
I think a db upgrade path is missing causing Travis failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1654
Job ID-98
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
There seems to be build failure around db path or marvin, I can check this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
LGTM
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
21 matches
Mail list logo
