[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd @jburwell Please don't forget to close loop on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd @jburwell Actually ESX 6 mapping are here schema-461to470.sql INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` values (25,UUID(),'VMware','6.0',128,0,13,32,1,1); INSERT IG

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell rollback is not necessary. We've no guest os mappings for VMware 6.0, those need to be added. If needed, I can send a new PR. /cc @serg38 --- If your project is set up for it, you can

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @serg38 good catch regarding vSphere 6. As I noted earlier, I will be rolling back this merge, and we will address it on re-submission. Once we resolve the VMware 5.5, XenServer 6.5, a

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell @rhtyd I apologies. The issue in our environment was due to using ESX v6. Once I added new mapping for it Vmware properly assigned Os type. It would be nice to officially certify ESX6 f

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell @rhtyd Sorry for a flood of messages. I checked and we do have mapping for all OS for Vmware 6 in ACS. It was introduced in 4.7 so that means this PR needs to have those 2 lines added (

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @serg38 @rhtyd I am going to rollback this merge as it appears that the patch does not fix the issue. I would also like to explore @serg38's point that we shouldn't need to make code changes t

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd @jburwell @karuturi I confirm the same issue with this PR as with 'CLOUDSTACK-5922:Incorrect handling RHEL guests for 5.5 to 5.9 When Os type is specified as Ubuntu 16.04 ![image](

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd I might be mistaken but you also need to add mapping into cloudstack/vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper In the past if not added on vmware it would

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 The failures from the above result are not related to the change but with the env/tests, most of which have been addressed in #1692 With the enough test results, manual tests and lgtms, I

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1696 Trillian test result (tid-86) Environment: kvm-centos7 (x2), Advanced Networking Total time taken: 24408 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/d

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 Thanks @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1696 tested on KVM, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1696 LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @ustcweizhou @abhinandanprateek @murali-reddy @jburwell review? Manual tests confirm that it works on XenServer 6.5. @blueorangutan test --- If your project is set up for it, you can re

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd 4.8 is still supported. However, support is for bug fixes, and this change is not a bug fix. 4.9 is an LTS branch which can take changes such as these. So I am cool with it being 4.9+

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell As per our maintenance policy we only maintain n, n-1 branches i.e. master (upcoming 4.10) and 4.9. At no point we had ever maintained three branches, it's too much overhead. So, which i

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd do you think we should include this update in 4.8.2.0 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 With a manually deployed Trillian environment based on XenServer 6.5sp1, I was able to register Ubuntu 16.04 and launch a VM. Screenshots attached: ![screenshot from 2016-09-29 21-27-21](

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 I've manually kicked a trillian env (tid-84) to get an env against xenserver 6.5sp1, as soon as it comes up I'll perform the test to launch a Ubuntu 16.04 VM using templates from http://dl.openv

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1696 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 Thanks @ustcweizhou I'll fix as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd I think it is not an issue in KVM/LXC. the guest pv is checked by this line in plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @ustcweizhou Hi, I think I used your changes here. VMware is sane to interpret Ubuntu guest vms as either ubuntuGuest or ubuntu64Guest (identifier used), while to XS and KVM full names are passed

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1696 Hi @rhtyd there are some typo in my comment, it should be "Ubuntu 16.04" not "Ubuntu 14.04" in some lines. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @abhinandanprateek @murali-reddy please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav