[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1738 Thanks all, I'll proceed with the merging as build, travis and packaging works, without an explicit Trillian test or BVT as both don't run tests against baremetal and the change is a single line

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1738 LGTM as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-24 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1738 Code changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1738 The changes are in baremetal subsystem, which cannot be tested by current test environments. The changes LGTM, @karuturi @koushik-das can you review/lgtm on this and confirm any test results

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-20 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1738 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-20 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1738 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1738 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and