Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@ustcweizhou I will add disable and CLOUDSTACK-9413 in new feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1873
### ACS CI BVT Run
**Sumarry:**
Build Number 437
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@jayapalu LGTM
I have two questions
(1) Is it possible to disable the check ?
(2) Could you please fix CLOUDSTACK-9413 (with this PR or in new PR) ?
---
If your project
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Two LGTMs and no test failures from cloudmonger test results.
@ustcweizhou waited for your comments for this, I am putting the mergeready
tag. If you have anything to bring up let me
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1873
### ACS CI BVT Run
**Sumarry:**
Build Number 404
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@ustcweizhou can you review the updated code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1873
### ACS CI BVT Run
**Sumarry:**
Build Number 389
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7
_Link to logs Folder
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Trillian test result (tid-895)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43388 seconds
Marvin logs:
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Jenkins and travis are failing because of its internal failures.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@borisstoyanov unsupported parameters provided. Supported mgmt server os
are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6,
kvm-centos7, kvm-ubuntu,
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@blueorangutan test centos7 vmware-60u1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Packaging result: âcentos6 âcentos7 âdebian. JID-536
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@ustcweizhou changes for kvm were in new file. It is missed while
commiting, added now. Thanks for catching.
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@jayapalu Thanks. Have you made changes for kvm ? I cannot find
GetVmIpAddressCommand in plugins/hypervisors/kvm(actually only find it in
plugins/hypervisors/xenserver/)
---
If your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
code LGTM
one small suggestion:
Could you modify line 2253 (_vmIpFetchThreadExecutor.execute) to be
executed only when hypervisor is XenServer(already supported) or Vmware
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Packaging result: âcentos6 âcentos7 âdebian. JID-523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
There are not failed test cases on CI run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Code looks good.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1873
### ACS CI BVT Run
**Sumarry:**
Build Number 351
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder
26 matches
Mail list logo
