Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1907
code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1907
LGTM @karuturi this is ready for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1907
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
This has the required reviews and both @remibergsma (sbp) and us (cloud.ca)
have been using this fix in production.
---
If your project is set up for it, you can reply to this email and have
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1907
Ok, great.
Thanks for the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@rafaelweingartner the only change was to remove the extra gateway
verification if it was a 'guest' network because this is now handled by the
code in #1871.
```
+guest_gw =
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@swill LGTM for the changes.
The changes introduced now are different from the last ones, right? Now it
is basically the addition of a log and the skipping of a processing
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
I have squash merged the changes that @ustcweizhou requested. Would you
mind reviewing again so we can get this important fix into 4.10. Thanks...
@rafaelweingartner, it looks like I
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1907
LGTM We run this code in production without issues for a few months now
(https://github.com/MissionCriticalCloud/cosmic/pull/114)
---
If your project is set up for it, you can reply to
